phosphor-webui/app/common/directives/firmware-list.html, branch master

Consolidate button styles

2019-06-21T19:27:51+00:00

This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

Fix issue about menu not disappearing on firmware page

2018-12-21T15:40:50+00:00

In firmware update page "More info” dialog did not disappear until it is clicked again. With this push users can click anywhere outside the menu and it disappears. Resolves openbmc/phosphor-webui#32 Change-Id: I1519caf2428c702af03fb0e4dd8a08d0c0588abf Signed-off-by: Ryan Arnell

Fix setting image priority

2018-10-09T02:09:52+00:00

Let's say there are 2 images, A and B. A has a priority of 0 and B has a priority of 50. Lowest priority is the image used to boot from and appears at the top of the image tables (A in this case). If the user wanted image B to be the image with the lowest priority, they would have to hit the up arrow 50 times in the old logic. Move to setting the priority based on the image above, for the up arrow, or below, for the down arrow. If 2 images have the same priority, the image whose priority is being updated wins and the image who already has that priority gets bumped up 1, this is why when moving an image down we set to the below image's priority +1, but don't need this -1 when moving an image up in the table. Tested: Can still change the priority. Change-Id: If87e1d863ab909c276247072cc45e40b67cf686b Signed-off-by: Gunnar Mills

Remove tabs from HTML files

2018-09-25T21:11:35+00:00

From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time. Don't use tabs or mix tabs and spaces for indentation." Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills

Make wording consistent

2018-09-20T20:41:12+00:00

The IBM design team identified this wording as inconsistent. In the tables below the "running" image is called "Functional", here it is called "In-memory". Change to "Functional" to match the table below. Change-Id: I4b1a45f3cbcc578b0f807577dd2c3a9c54714a02 Signed-off-by: Gunnar Mills

Fix change priority down arrow logic

2018-07-27T02:22:28+00:00

If the Boot priority was an "Active" image then a "Functional" image. The down arrow would be grayed out on the "Active" image. It should not have been grayed out, i.e. the user should be able to lower the priority on an "Active" image if there is a functional image below it in the table. Resolves openbmc/openbmc#3228 Tested: Tested this case and uploaded an image of the result to 3228. Change-Id: I6033886354f76671a4d33c4d8a79097428311e93 Signed-off-by: Gunnar Mills

Allow a "Failed" image to be "Activated"

2018-05-15T13:48:56+00:00

A failed image is an image that was unsuccess during activation. The firmware code allows these images to be activated so should the GUI. Resolves openbmc/openbmc#3144 Tested: Verified I see an "Activate" button on a "Failed" image. Change-Id: I3a5623d186dafd7656a045ba28e6bd636ee39420 Signed-off-by: Gunnar Mills

Gray out the 'Boot priority' down arrow key

2018-05-14T12:06:17+00:00

Gray out (disable) the 'Boot priority' down arrow key for a 'Functional' or 'Active' image if the remaining images are 'Ready' images. Resolves openbmc/openbmc#2965 Change-Id: Id8dad6b5a8d7376fe2c1f167a2043aae87916884 Signed-off-by: CamVan Nguyen

Add server confirm activation modal

2018-03-29T13:44:58+00:00

Added text specific to server images that appears in the activation modal when a "server" image is activated. The "server" and "BMC" images use the same modal, but the text and if radio buttons appear differ. Resolves openbmc/openbmc#2967 Tested: Activated both a server and BMC image on a Witherspoon. Change-Id: I83693641ebfef802d403141ade55a950f359ba6e Signed-off-by: Gunnar Mills

Move from "Preserve settings" to "Confirm Activation"

2018-03-29T13:44:58+00:00

The "Preserve settings" popup that showed when a user activated an image was not useful and did not do anything. Saving network settings prior to activation is not needed so moved to a "Confirm Activation" modal. This modal will eventually include an "activate BMC firmware and reboot" selection, openbmc/openbmc#3027, for now it only holds the one selection. The "Preserve settings" and now this "Confirm Activation" modal both appear on "server" and "BMC" images, this is a bug that is fixed in a later commit. Tested: Activated an image on a Witherspoon machine. Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9 Signed-off-by: Gunnar Mills