From 3b4d06a1812566d4095524f2242e272e0b9f449f Mon Sep 17 00:00:00 2001 From: Nagaraju Goruganti Date: Thu, 8 Nov 2018 03:13:38 -0600 Subject: phosphor-ldap-conf: update nslcd.conf file with tls_cacertfile info tls_cacertfile specifies the path to the X.509 certificate for peer authentication. Also updated the file with "tls_reqcert hard", to force the behavior: if no certificate is provided, or a bad certificate is provided, the session is immediately terminated. Tested: tested using below given commands 1.curl -c cjar -b cjar -k -H "Content-Type: application/json" -X POST -d \ '{"data":[true,"ldaps:///","cn=,dc=Corp,dc=ibm,dc=com",\ "cn=Users,dc=Corp,dc=ibm,dc=com", "",\ "xyz.openbmc_project.User.Ldap.Create.SearchScope.sub",\ "xyz.openbmc_project.User.Ldap.Create.Type.ActiveDirectory"] \ }' https://$BMC_IP//xyz/openbmc_project/user/ldap/action/CreateConfig 2.curl -b cjar -k -H "Content-Type: application/json" -X PUT -d '{"data":true}'\ https://$BMC_IP/xyz/openbmc_project/user/ldap/config/attr/SecureLDAP 3.curl -b cjar -k -H "Content-Type: application/json" -X PUT -d \ '{"data":"ldap:///"}' \ https://$BMC_IP/xyz/openbmc_project/ldap/config/attr/LDAPServerURI when "/etc/ssl/certs/Root-CA.pem" doesn't exist on target, we get below given exception(if we try to set SecureLDAP is true): "DBusException: xyz.openbmc_project.Common.Error.NoCACertificate: \ Server's CA certificate has not been provided." Change-Id: I56ffe8b08bb71307b4f2bfe9cf935b6113e4579a Signed-off-by: Nagaraju Goruganti Signed-off-by: Deepak Kodihalli Signed-off-by: Nagaraju Goruganti --- phosphor-ldap-config/ldap_configuration.cpp | 41 +++++++++++++++++++++++------ phosphor-ldap-config/ldap_configuration.hpp | 15 ++++++----- phosphor-ldap-config/main.cpp | 3 ++- 3 files changed, 44 insertions(+), 15 deletions(-) (limited to 'phosphor-ldap-config') diff --git a/phosphor-ldap-config/ldap_configuration.cpp b/phosphor-ldap-config/ldap_configuration.cpp index 31e4e75..be6c1cc 100644 --- a/phosphor-ldap-config/ldap_configuration.cpp +++ b/phosphor-ldap-config/ldap_configuration.cpp @@ -24,13 +24,13 @@ using Val = std::string; using ConfigInfo = std::map; Config::Config(sdbusplus::bus::bus& bus, const char* path, const char* filePath, - bool secureLDAP, std::string lDAPServerURI, - std::string lDAPBindDN, std::string lDAPBaseDN, - std::string&& lDAPBindDNPassword, + const char* caCertFile, bool secureLDAP, + std::string lDAPServerURI, std::string lDAPBindDN, + std::string lDAPBaseDN, std::string&& lDAPBindDNPassword, ldap_base::Config::SearchScope lDAPSearchScope, ldap_base::Config::Type lDAPType, ConfigMgr& parent) : ConfigIface(bus, path, true), - secureLDAP(secureLDAP), configFilePath(filePath), + secureLDAP(secureLDAP), configFilePath(filePath), tlsCacertFile(caCertFile), lDAPBindDNPassword(std::move(lDAPBindDNPassword)), bus(bus), parent(parent) { ConfigIface::lDAPServerURI(lDAPServerURI); @@ -106,8 +106,8 @@ void Config::writeConfig() if (secureLDAP == true) { confData << "ssl on\n"; - confData << "tls_reqcert allow\n"; - confData << "tls_cert /etc/nslcd/certs/cert.pem\n"; + confData << "tls_reqcert hard\n"; + confData << "tls_cacertFile " << tlsCacertFile.c_str() << "\n"; } else { @@ -192,6 +192,13 @@ std::string Config::lDAPServerURI(std::string value) elog(Argument::ARGUMENT_NAME("lDAPServerURI"), Argument::ARGUMENT_VALUE(value.c_str())); } + + if (secureLDAP && !fs::exists(tlsCacertFile.c_str())) + { + log("LDAP server's CA certificate not provided", + entry("TLSCACERTFILE=%s", tlsCacertFile.c_str())); + elog(); + } val = ConfigIface::lDAPServerURI(value); writeConfig(); parent.restartService(nslcdService); @@ -204,6 +211,10 @@ std::string Config::lDAPServerURI(std::string value) { throw; } + catch (const NoCACertificate& e) + { + throw; + } catch (const std::exception& e) { log(e.what()); @@ -405,6 +416,13 @@ std::string Argument::ARGUMENT_VALUE(lDAPServerURI.c_str())); } + if (secureLDAP && !fs::exists(tlsCacertFile.c_str())) + { + log("LDAP server's CA certificate not provided", + entry("TLSCACERTFILE=%s", tlsCacertFile.c_str())); + elog(); + } + if (lDAPBindDN.empty()) { log("Not a valid LDAP BINDDN", @@ -438,8 +456,9 @@ std::string auto objPath = std::string(LDAP_CONFIG_DBUS_OBJ_PATH); configPtr = std::make_unique( - bus, objPath.c_str(), configFilePath.c_str(), secureLDAP, lDAPServerURI, - lDAPBindDN, lDAPBaseDN, std::move(lDAPBindDNPassword), + bus, objPath.c_str(), configFilePath.c_str(), tlsCacertFile.c_str(), + secureLDAP, lDAPServerURI, lDAPBindDN, lDAPBaseDN, + std::move(lDAPBindDNPassword), static_cast(lDAPSearchScope), static_cast(lDAPType), *this); @@ -571,6 +590,12 @@ void ConfigMgr::restore(const char* filePath) // object upon finding empty values in config, as // this can be a default config. } + catch (const NoCACertificate& e) + { + // Don't throw - we don't want to create a D-Bus + // object upon finding "ssl on" without having tls_cacertFile in place, + // as this can be a default config. + } catch (const InternalFailure& e) { throw; diff --git a/phosphor-ldap-config/ldap_configuration.hpp b/phosphor-ldap-config/ldap_configuration.hpp index 0dfb56d..0254d42 100644 --- a/phosphor-ldap-config/ldap_configuration.hpp +++ b/phosphor-ldap-config/ldap_configuration.hpp @@ -49,6 +49,7 @@ class Config : public ConfigIface * @param[in] bus - Bus to attach to. * @param[in] path - The D-Bus object path to attach at. * @param[in] filePath - LDAP configuration file. + * @param[in] caCertFile - LDAP's CA certificate file. * @param[in] secureLDAP - Specifies whether to use SSL or not. * @param[in] lDAPServerURI - LDAP URI of the server. * @param[in] lDAPBindDN - distinguished name with which to bind. @@ -61,8 +62,9 @@ class Config : public ConfigIface */ Config(sdbusplus::bus::bus& bus, const char* path, const char* filePath, - bool secureLDAP, std::string lDAPServerURI, std::string lDAPBindDN, - std::string lDAPBaseDN, std::string&& lDAPBindDNPassword, + const char* caCertFile, bool secureLDAP, std::string lDAPServerURI, + std::string lDAPBindDN, std::string lDAPBaseDN, + std::string&& lDAPBindDNPassword, ldap_base::Config::SearchScope lDAPSearchScope, ldap_base::Config::Type lDAPType, ConfigMgr& parent); @@ -112,6 +114,7 @@ class Config : public ConfigIface private: std::string configFilePath{}; + std::string tlsCacertFile{}; std::string lDAPBindDNPassword{}; /** @brief Persistent sdbusplus D-Bus bus connection. */ @@ -144,10 +147,10 @@ class ConfigMgr : public CreateIface * @param[in] bus - Bus to attach to. * @param[in] path - Path to attach at. * @param[in] filePath - LDAP configuration file. - * @param[in] caCertfile - LDAP's CA certificate file. + * @param[in] caCertFile - LDAP's CA certificate file. */ - ConfigMgr(sdbusplus::bus::bus& bus, const char* path, - const char* filePath) : + ConfigMgr(sdbusplus::bus::bus& bus, const char* path, const char* filePath, + const char* caCertFile) : CreateIface(bus, path, true), configFilePath(filePath), bus(bus) { @@ -198,7 +201,7 @@ class ConfigMgr : public CreateIface protected: std::string configFilePath{}; - std::string tlsCacertfile{}; + std::string tlsCacertFile{}; /** @brief Persistent sdbusplus D-Bus bus connection. */ sdbusplus::bus::bus& bus; diff --git a/phosphor-ldap-config/main.cpp b/phosphor-ldap-config/main.cpp index e285786..adbfdd3 100644 --- a/phosphor-ldap-config/main.cpp +++ b/phosphor-ldap-config/main.cpp @@ -27,7 +27,8 @@ int main(int argc, char* argv[]) // Add sdbusplus ObjectManager for the 'root' path of the LDAP config. sdbusplus::server::manager::manager objManager(bus, LDAP_CONFIG_ROOT); - phosphor::ldap::ConfigMgr mgr(bus, LDAP_CONFIG_ROOT, LDAP_CONFIG_FILE); + phosphor::ldap::ConfigMgr mgr(bus, LDAP_CONFIG_ROOT, LDAP_CONFIG_FILE, + TLS_CACERT_FILE); bus.request_name(LDAP_CONFIG_BUSNAME); -- cgit v1.2.1