<feed xmlns='http://www.w3.org/2005/Atom'>
<title>phosphor-time-manager/test, branch master</title>
<subtitle>OpenBMC Phosphor time manager sources</subtitle>
<id>https://git.raptorcs.com/git/phosphor-time-manager/atom?h=master</id>
<link rel='self' href='https://git.raptorcs.com/git/phosphor-time-manager/atom?h=master'/>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/'/>
<updated>2018-10-08T06:07:30+00:00</updated>
<entry>
<title>clang-format: Update to match docs repo</title>
<updated>2018-10-08T06:07:30+00:00</updated>
<author>
<name>Gunnar Mills</name>
<email>gmills@us.ibm.com</email>
</author>
<published>2018-09-14T19:42:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=ab4cc6a5585436a29b120429abaa48b416f8edb7'/>
<id>urn:sha1:ab4cc6a5585436a29b120429abaa48b416f8edb7</id>
<content type='text'>
Update the .clang-format file and run clang-format-6.0.
This .clang-format matches the example one in
https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#clang-formatting

Change-Id: Ic2c462525eb27b8295c2b298871e04268d93faf2
Signed-off-by: Gunnar Mills &lt;gmills@us.ibm.com&gt;
</content>
</entry>
<entry>
<title>Enable link time optimization</title>
<updated>2018-09-19T02:01:45+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2018-09-18T06:46:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=19b37ee2205ff4e772d344fe8a5fcfee2aa0d8ec'/>
<id>urn:sha1:19b37ee2205ff4e772d344fe8a5fcfee2aa0d8ec</id>
<content type='text'>
To enable link time optimization, several configures needs to be
changed:
1. Add -flto in Makefiles
2. Use C++17 to get inline constexpr
3. Use gcc-ar and gcc-ranlib to generate static library, otherwise it
   gets link errors.

Tested: Build OK and unit tests passes.

Change-Id: Ic58cbfb631c97f43c82d5669cbf6ac1ebc5e0ab9
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Use proper errors when failing to set time</title>
<updated>2018-09-12T02:45:04+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2018-07-13T08:35:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=f6fad82032fa2f43378294d3f5a860343f5d771b'/>
<id>urn:sha1:f6fad82032fa2f43378294d3f5a860343f5d771b</id>
<content type='text'>
Previously it reports InsufficientPermission when it is not allowed to
set time.

Now phosphor-dbus-interfaces defines proper errors for such case, so
report NotAllowed error when it is not allowed to set time, and report
Failed error when it failed to set time.

Tested: Get NotAllowed and Failed error with expected metadata from
        journal log.

Change-Id: I53610bf27ffc3f62608cea6fd0e66ca859d94675
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Use correct gtest/gmock flags</title>
<updated>2018-09-12T02:44:55+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2018-09-10T02:34:56+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=bd024395f6e34f4bc5eff4941991abc572e9707e'/>
<id>urn:sha1:bd024395f6e34f4bc5eff4941991abc572e9707e</id>
<content type='text'>
The test Makefile.am was using -lgmock -lgmock_main directly, which
cause link issues on compiling test.
Fix this by using the flags specified by gtest package.

Tested: Verify the CI passes build.

Change-Id: Id51134d7e2696e18f7439f15f8d899edba51856e
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Throw excpetion when it is not allowed to set time</title>
<updated>2018-06-13T03:30:20+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2018-06-07T09:06:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=33752c75e8bdadf13d983e94667de72f64ba3537'/>
<id>urn:sha1:33752c75e8bdadf13d983e94667de72f64ba3537</id>
<content type='text'>
When it is not allowed to set time depending on the time setting,
previously we only log an error and continue.
Now sdbusplus supports errors on properties, so we can throw exception
on such case.

Tested: Verify in unittest that exception is thrown when it is not
        allowed to set time.
        Verify in BMC that busctl gets the error message when it is not
        allowed to set time.
Change-Id: I4a04d1aa8c081abf0f9fd449118dc1107e12f689
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Spelling fixes</title>
<updated>2017-10-26T01:45:50+00:00</updated>
<author>
<name>Gunnar Mills</name>
<email>gmills@us.ibm.com</email>
</author>
<published>2017-10-26T01:45:28+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=7f25c53fa79f71a12b11593ac7eda23a9b8d3e1a'/>
<id>urn:sha1:7f25c53fa79f71a12b11593ac7eda23a9b8d3e1a</id>
<content type='text'>
Change-Id: Ia840360c00cc8d7baaafd797ae2411bc5cc03ed3
Signed-off-by: Gunnar Mills &lt;gmills@us.ibm.com&gt;
</content>
</entry>
<entry>
<title>Use host state object to check if host is on</title>
<updated>2017-10-16T12:41:02+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2017-10-13T05:21:37+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=debe1d8f47bab3d61b3340c84f802f1dc6388ca0'/>
<id>urn:sha1:debe1d8f47bab3d61b3340c84f802f1dc6388ca0</id>
<content type='text'>
The code was using pgood to determine if host is on or off. Now we have
host state object, which is a more appropriate way to check host on/off.
So change pgood related code to use host state object.

Change-Id: I553c1a40922ca2e8bc6904688c55e85971bd4720
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Let timedate1 to decide on setting time in NTP mode</title>
<updated>2017-10-16T12:41:02+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2017-08-01T09:37:41+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=1c2ce82c0c3226a94aeefcc6ff2ddee170792ca0'/>
<id>urn:sha1:1c2ce82c0c3226a94aeefcc6ff2ddee170792ca0</id>
<content type='text'>
In NTP mode, let timedate1 to set BMC time, for now, it results in
error.

Change-Id: I2d78cdcfe6868642f43198dd932b20b13fd8523d
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Use new settings API</title>
<updated>2017-10-16T12:41:01+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2017-08-01T09:10:17+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=710d49be2fc33f22e8f4a7ed43774fd9293d083f'/>
<id>urn:sha1:710d49be2fc33f22e8f4a7ed43774fd9293d083f</id>
<content type='text'>
The new time manager code was using the old settings daemon.
Now it uses the new settings API.

Change-Id: Id551d97c28a6cfbb81c87118b26292b1b5574e93
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
<entry>
<title>Use time mode owner enums in dbus interface</title>
<updated>2017-10-16T12:40:04+00:00</updated>
<author>
<name>Lei YU</name>
<email>mine260309@gmail.com</email>
</author>
<published>2017-07-25T06:27:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.raptorcs.com/git/phosphor-time-manager/commit/?id=ad14354fc17811ae585f13b1d52a275cf3daff35'/>
<id>urn:sha1:ad14354fc17811ae585f13b1d52a275cf3daff35</id>
<content type='text'>
Dbus interface defines time mode owners in xyz::openbmc_project::Time.
Use the enums from the interface instead of repo defined enums and use
the generated code to do convertions between strings and enums.

Update unit tests accordingly.

Change-Id: Ic304aa3b4137375d208bb1702e0f64df512fc5a0
Signed-off-by: Lei YU &lt;mine260309@gmail.com&gt;
</content>
</entry>
</feed>
