phosphor-time-manager, branch master

build: install into bin instead of sbin

2019-03-28T18:33:17+00:00

Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture Change-Id: I2f61cbda4721533610516c0c91da4b3a16d15b52

build: pkg anti-pattern: use defaults

2019-02-13T23:18:40+00:00

Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: I91e5407066976b4d03e8a6b8d105e9bb8aecf5f7 Signed-off-by: Patrick Venture

README: Add special note on NTP setting change

2019-01-23T02:34:06+00:00

Systemd timedated from v236 to v239 introduces a behavior change related to setting time while NTP setting is changed. This change causes phosphor-time-manager automation test failure. Add a special note in README to describe the issue, and the test case will be updated. Partially resolves openbmc/openbmc#3459 Change-Id: I8ee31e8de95d8b110bf9cbee7973c377a6d4330a Signed-off-by: Lei YU

Use a single dbus connection object

2018-12-19T13:38:46+00:00

Starting with sdbusplus 8ca6025, calling bus_new_default multiple times doesn't seem to work - making calls that generate dbus traffic on one of the objects results in something like: sd_bus_call: System.Error.ENOTCONN: Transport endpoint is not connected This wasn't ideal anyway - move to a single object, shared application-wide. Tested: Booted a witherspoon QEMU image and there were no coredumps Change-Id: I804a1b1438b22f48e45b26d395135e401ca98a06 Signed-off-by: Brad Bishop

build: Add missing inclusion of phosphor-logging

2018-12-06T15:36:34+00:00

Phosphor-logging is picked up by the configure_ac. Include it in the Makefile such that it's available as defined by the pkgconfig. Change-Id: I173fa376ab3419155267ab08350d7a7ad2e1a0f0 Signed-off-by: Patrick Venture

Fix std::variant usage

2018-11-07T00:06:40+00:00

We need to conform to the std::variant interface instead of the mapbox specific one. Change-Id: I3edbcb2682ddfebfcbca6e75284b11f2e18cfd11 Signed-off-by: William A. Kennington III

clang-format: Update to match docs repo

2018-10-08T06:07:30+00:00

Update the .clang-format file and run clang-format-6.0. This .clang-format matches the example one in https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#clang-formatting Change-Id: Ic2c462525eb27b8295c2b298871e04268d93faf2 Signed-off-by: Gunnar Mills

Enable link time optimization

2018-09-19T02:01:45+00:00

To enable link time optimization, several configures needs to be changed: 1. Add -flto in Makefiles 2. Use C++17 to get inline constexpr 3. Use gcc-ar and gcc-ranlib to generate static library, otherwise it gets link errors. Tested: Build OK and unit tests passes. Change-Id: Ic58cbfb631c97f43c82d5669cbf6ac1ebc5e0ab9 Signed-off-by: Lei YU

Fix un-initialized time owner/mode in manager

2018-09-12T02:45:04+00:00

The timeOwner/Mode in Manager class has no init value, and it is initialized with the cached time owner/mode in file system. In most of time it is OK because there is cached time owner/mode. But if the BMC does a factory reset, the cached values are cleaned up, and in next reboot the timeOwner/Mode will not be initialized at all. The fix is to give default time owner/mode, so when BMC comes from factory reset it uses default time settings. Tested: Verify the timeOwner/Mode have correct init values after factory reset. Change-Id: Ib1a8fba4d758f33ed09a7afdc9ed684867fca1c5

Handle SdBusError exception in setting NTP

2018-09-12T02:45:04+00:00

sdbusplus now throws SdBusError exception when a sd bus call fails. When setting NTP via systemd timedatectl service, it may potentially fail. So handle this exception. Also fix a typo in logging, where it should use `=` in meta. Change-Id: I6c5669b7f06cef47c8d62cb0cbcb0c7fbd2a46e7 Tested: Verify it sets NTP setting OK.