phosphor-state-manager, branch master

Handle mapper introspect race condition

2019-04-10T19:29:16+00:00

There is a pervasive issue within OpenBMC where a dbus service may be started and on the bus, but before mapper can introspect it, a dependent service queries mapper for that objects information. In most situations a service writer can avoid this by using the Wants=mapper-wait@-xyz* syntax. This does not work however if two or more dbus services implement the same dbus object path. The host_check_main application is one service that is hitting this issue. It requires the /xyz/openbmc_project/control/host0 object path which is implemented by two dbus services. The solution here is to first try mapper, but if that fails to use a hard coded dbus service name. The value of mapper for this type of function is up for debate within the community but for now, get a compromise in that first tries mapper, and if not available tries the hard coded well-known service name. Tested: Verified the following within QEMU: - Good path works as expected, mapper response used - GetObject fails for mapper call, successfully used hard coded path - Service not available on dbus, verified exception reported Change-Id: I14dfaf2ce43392a19a2a5a3131534f55c6eb6f4a Signed-off-by: Andrew Geissler

build: install into bin instead of sbin

2019-04-06T14:50:30+00:00

Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture Change-Id: I53614a64fa37f2b3bc2841794bf5aa8c137c31df

obmcutil: add more info to state subcommand

2019-04-03T13:29:57+00:00

Adds new subcommand to request the OS state. Adds bootprogress and osstate to the output of state/status subcommands. Tested: The output of `obmcutil state` must look like: ``` CurrentBMCState : xyz.openbmc_project.State.BMC.BMCState.Ready CurrentPowerState : xyz.openbmc_project.State.Chassis.PowerState.Off CurrentHostState : xyz.openbmc_project.State.Host.HostState.Off BootProgress : xyz.openbmc_project.State.Boot.Progress.ProgressStages.Unspecified OperatingSystemState: xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive ``` Change-Id: I59937986317fe2ac487d355a627de1070ba813f8 Signed-off-by: Alexander Filippov

build: pkg anti-pattern: use defaults

2019-02-19T15:09:44+00:00

Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: I21df28b0ad0a337e3af746b7cfb06ae9cc8f6087 Signed-off-by: Patrick Venture

obmcutil: Add chassiskill option

2019-02-14T19:20:57+00:00

Change-Id: I9b8289e433bfcf918d430c012ec8879b58e523b0 Signed-off-by: Anthony Wilson

obmcutil: Add to 'make install' list

2019-02-07T16:24:00+00:00

Testing: Verified obmc-phosphor-image build installs it correctly in obmc-phosphor-image/1.0-r0/rootfs/usr/sbin/obmcutil Change-Id: I386e726a653496ccd77549fa63603ddfb647bd78 Signed-off-by: Anthony Wilson

Update error handling on sdbusplus calls

2018-11-26T21:12:57+00:00

Error handling was added to the bus.call() routine, which effectively deprecated the is_method_error() check. Errors should now be handled in a try/catch block. Change-Id: I1dcbbaa91db443445ef6bb2f616bd37f06731d36 Signed-off-by: Anthony Wilson

std::variant: Fix use of incompatible api

2018-11-13T01:27:25+00:00

Refactors any uses of the mapbox variant specific api and converts them to an api compatible with std::variant and mapbox variant. Tested: Built and run through the unit test suite. Change-Id: Ie9b83fd638c495859fe98b5de86d9d3c7c1a27af Signed-off-by: William A. Kennington III

Include missing

2018-11-13T01:26:35+00:00

We are currently transitively depending on sdbusplus to provide the definition of assert(). Add the necessary include we should have requested. Change-Id: I9e348edc851fc922916942f522748f0bc59d5399 Signed-off-by: William A. Kennington III

obmcutil: Add wait/timeout option

2018-10-25T13:47:01+00:00

The option to block/wait for a state transition to complete has been added. The transition is expected to occur within a set timeout window and will terminate if the desired state has not been observed within that window. It may be possible for the state transition to complete outside this window, but it is assumed to be a failure. Change-Id: Icb9ff29f51b8712469fd9957b7e4b287704cb314 Signed-off-by: Anthony Wilson