diff options
| author | Deepak Kodihalli <dkodihal@in.ibm.com> | 2018-10-15 12:45:18 -0500 |
|---|---|---|
| committer | Brad Bishop <bradleyb@fuzziesquirrel.com> | 2018-10-16 12:58:26 +0000 |
| commit | 4b412ac926aaed11a9c335827d7c37d972399d0d (patch) | |
| tree | 7effd83582eff343614707c41f336e47a224f316 /module/obmc/wsgi/apps/rest_dbus.py | |
| parent | 844bb4e13bf53905f899760e1f4435576f334b11 (diff) | |
| download | phosphor-rest-server-4b412ac926aaed11a9c335827d7c37d972399d0d.tar.gz phosphor-rest-server-4b412ac926aaed11a9c335827d7c37d972399d0d.zip | |
LDAP config: don't log bind password
Add a way to prevent json body logging for routes with sensitive data
such as passwords.
This is basically done via a list of URLs. Add the LDAP create config
URL to this list.
Tested:
Before:
phosphor-gevent[1481]: <BMC IP> user:root POST
http://127.0.0.1:8081/xyz/openbmc_project/user/ldap/action/CreateConfig
json:{u'data': [False, u'ldap://<LDAP server IP>/',
u'cn=Sivas,cn=Users,dc=Corp,dc=ibm,dc=com',
u'cn=Users,dc=Corp,dc=ibm,dc=com', u'<password>',
u'xyz.openbmc_project.User.Ldap.Create.SearchScope.sub',
u'xyz.openbmc_project.User.Ldap.Create.Type.ActiveDirectory']} 200 OK
After:
phosphor-gevent[1710]: <BMC IP> user:root POST
http://127.0.0.1:8081/xyz/openbmc_project/user/ldap/action/CreateConfig
json:None 200 OK
Change-Id: I99979e5e373784c7eabb55861dae70bb283859a4
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Diffstat (limited to 'module/obmc/wsgi/apps/rest_dbus.py')
| -rw-r--r-- | module/obmc/wsgi/apps/rest_dbus.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/module/obmc/wsgi/apps/rest_dbus.py b/module/obmc/wsgi/apps/rest_dbus.py index f52032a..bf7db41 100644 --- a/module/obmc/wsgi/apps/rest_dbus.py +++ b/module/obmc/wsgi/apps/rest_dbus.py @@ -1600,6 +1600,9 @@ class LoggingPlugin(object): self.logging_enabled = None self.bus = dbus.SystemBus() self.dbus_path = '/xyz/openbmc_project/logging/rest_api_logs' + self.no_json = [ + '/xyz/openbmc_project/user/ldap/action/CreateConfig' + ] self.bus.add_signal_receiver( self.properties_changed_handler, dbus_interface=dbus.PROPERTIES_IFACE, @@ -1616,6 +1619,8 @@ class LoggingPlugin(object): json = request.json if self.suppress_json_logging: json = None + elif any(substring in request.url for substring in self.no_json): + json = None session = self.app.session_handler.get_session_from_cookie() user = None if "/login" in request.url: |
