phosphor-rest-server/module, branch master

Fixes the method signature generation logic

2019-01-16T08:32:01+00:00

During generation of the method signature, Both Input and Output argument is being used, where only Input argument should have been considered. This method signature is required as we convert the input values into its actual types by introspecting the interface. https://github.com/openbmc/openbmc/issues/1160 Fixes openbmc/openbmc#3453 Change-Id: I3eb99736295b76176a9964f7542f326007e1c4a4 Signed-off-by: Ratan Gupta

rest_dbus: get_host_interface: Iterate through busnames

2019-01-14T19:12:14+00:00

The mapper may return multiple busnames, as it's the case for an object that has associations. So if the path is not found on the busname, continue to see if there are more busnames to try instead of quitting on the first try. Fixes: openbmc/openbmc#3460 Tested: Verified the software interfaces are working again, and that a dummy busname still raises an exception for the case where none of the busnames returned by the mapper hold the requested path. Change-Id: Iaf36dd94f728d147f20c23666e5c19062b33f97a Signed-off-by: Adriana Kobylak

phosphor-rest-server: connect with the correct sockaddr size

2018-12-19T18:45:12+00:00

With the obmc-console-server binding to the correct socket, this is not needed. Abstract unix sockets start with the nul-charater, but are not nul terminated. In fact, the nul-character has no meaning in the path. According to the man page unix(7), abstract: an abstract socket address is distinguished (from a pathname socket) by the fact that sun_path[0] is a null byte ('\0'). The socket's address in this namespace is given by the additional bytes in sun_path that are covered by the specified length of the address structure. (Null bytes in the name have no special significance.) This means that when calling bind/connect, the size of the sockaddr structure is not sizeof(sockaddr_un), it is sizeof(sockaddr_un) - sizeof(sun_path) + (path_len) Change-Id: I1d978af9ace7fa137bab2f596a217d1ba243e5be Signed-off-by: Vernon Mauery

Ensure websocket termination handled correctly

2018-10-23T14:00:43+00:00

Currently when a websocket is terminated on the client side, the logic in EventNotifier continues to run. This is because the WebSocketError exceptions are detected in the properties/interface handlers where that exception is just ignored. This exception can not be sent back up to the main loop because it goes through the dbus libraries which will fail when it sees it. Use a class variable to indicate when a websocket error has been hit and break out of the loop. Also, remove signal handlers. Signed-off-by: Andrew Geissler Signed-off-by: Deepak Kodihalli Removed good path tracing. Signed-off-by: Brad Bishop Change-Id: I068f19fd75aa03fb71d98e9ff75f596941c8622f

LDAP config: don't log bind password

2018-10-16T12:58:26+00:00

Add a way to prevent json body logging for routes with sensitive data such as passwords. This is basically done via a list of URLs. Add the LDAP create config URL to this list. Tested: Before: phosphor-gevent[1481]: user:root POST http://127.0.0.1:8081/xyz/openbmc_project/user/ldap/action/CreateConfig json:{u'data': [False, u'ldap:///', u'cn=Sivas,cn=Users,dc=Corp,dc=ibm,dc=com', u'cn=Users,dc=Corp,dc=ibm,dc=com', u'', u'xyz.openbmc_project.User.Ldap.Create.SearchScope.sub', u'xyz.openbmc_project.User.Ldap.Create.Type.ActiveDirectory']} 200 OK After: phosphor-gevent[1710]: user:root POST http://127.0.0.1:8081/xyz/openbmc_project/user/ldap/action/CreateConfig json:None 200 OK Change-Id: I99979e5e373784c7eabb55861dae70bb283859a4 Signed-off-by: Deepak Kodihalli

certificate handler: fixup return code

2018-10-03T09:59:26+00:00

Map a certificate install fail to a 400. This is likely due to an invalid certificate. Change-Id: Ie451aa356e4a708889aa7475f10a1c122253e859 Signed-off-by: Deepak Kodihalli

Implement certificate delete

2018-10-02T18:44:24+00:00

Implement the DELETE verb on certificate endpoints. This calls the D-Bus delete interface on corresponding D-Bus objects. Change-Id: Id829f9064474edd2324ce3c4a66148041b70a95b Signed-off-by: Deepak Kodihalli

certificate handler: use mapper

2018-10-02T18:43:13+00:00

Use mapper to retrieve a D-Bus busname, instead of assuming a well-known busname. Change-Id: I668f750ab098b847bf3a662abdf6614170471c41 Signed-off-by: Deepak Kodihalli

Upload and activate new certificate file.

2018-09-28T15:10:34+00:00

Handle the rest interface to activate new certificate. Change-Id: Ida636a129a042eaa03c754f57fe1bb134446e086 Signed-off-by: Dhruvaraj Subhashchandran

Purge semicolons

2018-09-13T16:48:45+00:00

Change-Id: Ibca457d0721cce4a76152c2095026adc1bdcdfea Signed-off-by: Deepak Kodihalli