phosphor-pid-control/pid, branch master

rename away from RPM

2019-07-16T22:17:11+00:00

The SetPoint output from a thermal PID is likely RPM, and that value is then fed into a fan controller PID as the set-point (unit: RPM). This does not have to be RPM, however. Continue renaming variables and methods to remove the explicit unit-naming. Signed-off-by: Patrick Venture Change-Id: I570dee0c688338f9a458cac7123314717bee2b42

rename RPMSetPoint to SetPoint

2019-07-16T21:16:01+00:00

The PIDs were originally focused on collecting RPM set points from thermal PIDs and then having fan PIDs use the highest value collected, it doesn't need to be strictly an RPM set point. It does however need to be one type of value. Signed-off-by: Patrick Venture Change-Id: I1d589cf4b2688d7e86030c10496d737dc5bbdadf

Add stepwise parser

2019-05-28T20:11:54+00:00

The json parser cannot read stepwise setting from config. This change adds support to stepwise type of pid. Change-Id: I650c5bd6a0040bf25630e33b3bd36abf388f0cd8 Signed-off-by: Hank Liou

Check fans for failure

2019-05-23T05:33:46+00:00

Add check the fan fail. If detect fan fail then into the fail safe mode. Signed-off-by: Will Liang Change-Id: I6ef9d42e131500c1b38a708e1c6fda15dc712f60

Make dbusconfiguration reloadable without reboot

2019-05-09T17:08:41+00:00

Now that asio is being used instead of threads, we can reload the fan configuration without having to restart the application. This moves the ownership of the passive and host bus outside of the SensorManager so that it can be recreated each reload. Tested: Watched logs and saw full fan config get reloaded after changing fan configuration Tested: Ran on json configured system and it behaved as expected. Change-Id: I00e6b27f75384fd41de2017b723f159c9691ae97 Signed-off-by: James Feist

Consolidate all util.hpp

2019-05-08T22:33:33+00:00

This deletes all lower level util.hpp and cats them into the top level util.hpp to avoid name conflicts. Change-Id: Ia11e4a08053a3970b0aadf21d1156ab26def36bd Signed-off-by: James Feist

explicitly expect a directory for logging

2019-05-08T22:13:06+00:00

Verify the logging parameter is explicitly a directory. Treat the path as a directory for creating the logging files. Signed-off-by: Patrick Venture Change-Id: I84d6be79780df3f52deeb1ff1b7a50de6175c055

split parameters for logging and tuning

2019-05-08T22:11:43+00:00

add a flag to enable/disable tuning: default off add an option for specifying a folder for outputting logs. Closes: #10 Signed-off-by: Patrick Venture Change-Id: I43864768f1dee8672f13288d3cf5a0c87c373aed

Remove threads

2019-04-07T16:34:02+00:00

This converts phosphor-pid-control into an async single threaded application. The reason for doing this is on our systems phosphor-pid-control had the largest VSZ when viewed under top. Before this patch the VSZ was at 50720, after it is at 7760. Tested-by: Could still interact with all interfaces under rest-dbus and sensor override worked to ramp fans when changing cpu temps. Change-Id: Ie0a837bdf0d1b1df61dc7aff87e5d503b9e0e875 Signed-off-by: James Feist

bugfix: grab hystersis parameter from pid json

2019-03-26T14:13:12+00:00

The code incorrectly attempts to read the hystersis parameters from the wrong scope of the json object. This fixes it to read from the pid configuration's scope. Tested: Added a new unit-test to hit this case. Change-Id: I808bc907ec33a0b12d68a88fd316c3c9fae41516 Signed-off-by: Patrick Venture