phosphor-pid-control/pid/ec, branch masterOpenBMC Phosphor PID controller daemon sourceshttps://git.raptorcs.com/git/phosphor-pid-control/atom?h=master2019-02-26T18:31:58+00:00stepwise: Add ceiling type2019-02-26T18:31:58+00:00James Feistjames.feist@linux.intel.com2019-02-25T18:01:42+00:00urn:sha1:608304da320f232b9adc591301581a5fa5949fff
Add a stepwise ceiling type, this is used as a
upper clipping curve to limit the max output based
on a temperature sensor. This is commonly used for
quiet fan mode where CPU throttling is allowed to
preserve a max fan noise.
Change-Id: I181d5913c92e5498a34e6d3f67cf99b67471479c
Signed-off-by: James Feist <james.feist@linux.intel.com>
conf change: pid: all pid details are now camelCase2019-02-11T19:22:27+00:00Patrick Ventureventure@google.com2019-02-11T18:21:05+00:00urn:sha1:7442c37a1f037ae9615309cc1a22664b008eeac7
Convert all PID configuration details are now camelCase instead of snake
case.
Change-Id: Id132053f122dfcd8abaace17df91c99758eb2b0c
Signed-off-by: Patrick Venture <venture@google.com>
pid: rename variables with full names2019-02-11T17:26:54+00:00Patrick Ventureventure@google.com2019-02-11T17:25:56+00:00urn:sha1:a23468ef06b72ad2946e8f744c7e606435988253
Use full names and camelcase for the variables in the pid loop to
improve readability and consistency.
Change-Id: I86be69d94d3008faa497eace050d1f3b9b6a9ff4
Signed-off-by: Patrick Venture <venture@google.com>
pid: rename structure components for style2019-02-11T17:20:25+00:00Patrick Ventureventure@google.com2019-02-11T17:04:57+00:00urn:sha1:4b0df320fd94ae8f1109134e7227ede919f0ce67
Rename the struct components to camelCase.
Change-Id: I0e76c4bd5aed0ec2d78edd31ddef66f852ddc71e
Signed-off-by: Patrick Venture <venture@google.com>
Add Hysteresis to pid controllers2019-02-05T19:30:05+00:00James Feistjames.feist@linux.intel.com2019-01-31T23:52:22+00:00urn:sha1:572c43dab62f9e207781b96e7e48b7b38ca024e5
Add hysteresis to pid controllers to lower pwm changes.
It is defaulted to 0 so it should be transparent
to any controller that choses not to implement it.
This is the same pattern used by the stepwise controller.
Tested-by: Unit tests passed
Change-Id: Ib47114285b0017258b7f77eaf067d310f95a0c60
Signed-off-by: James Feist <james.feist@linux.intel.com>
Move all floats to doubles2018-11-11T20:57:02+00:00Patrick Ventureventure@google.com2018-11-11T20:55:14+00:00urn:sha1:5f59c0fdbda807ac54a58657fbd6cbde718e8678
The code was developed initially around a pid loop implemented using
floats. Therefore, the code was converting back and forth between
double for sensor values as inputs and outputs from this PID loop.
Change-Id: I2d2919e1165103040729c9f16bb84fde3dd6b81b
Signed-off-by: Patrick Venture <venture@google.com>
cleanup: reduce scope of variables2018-10-13T16:35:40+00:00Patrick Ventureventure@google.com2018-10-13T16:30:58+00:00urn:sha1:df766f251f25e32ccbfe1e3ea429f118478422bd
Various things caught by cppcheck that are non-critical.
Change-Id: I495453c84bc15788b85036a163ee36b0ac601fa1
Signed-off-by: Patrick Venture <venture@google.com>
Add hysteresis to stepwise controller2018-09-21T19:13:58+00:00James Feistjames.feist@linux.intel.com2018-09-20T22:46:58+00:00urn:sha1:3dfaafdacaeaf2b21ff24f3cb314b71c911e2cea
Tested-by: Ran on platform monitoring output and wrote
unit test
Change-Id: I74a1d21544c1a9cb4c1cb26dd4a353cbff0442d0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Add stepwise controller2018-09-12T14:38:03+00:00James Feistjames.feist@linux.intel.com2018-08-31T21:07:12+00:00urn:sha1:22c257abd27fd76ed5280ef5c717eef1f28bfca9
This adds the ability to use stepwise curves alongside
pid control. This creates a base controller class that
pidcontroller and stepwise controller inherit from.
Note: Hysteresis to come in follow-on patch
Tested-by:
Created a stepwise controller and noticed that when it
crossed a threshold that it contributed to the pwm setting.
Change-Id: I6cf842f80eaccafc905d620970afe91e2092d568
Signed-off-by: James Feist <james.feist@linux.intel.com>
add .clang-format2018-08-31T16:53:59+00:00Patrick Ventureventure@google.com2018-08-31T16:42:48+00:00urn:sha1:da4a5dd133b88ebfeb69e89d05b381f81ba70e50
Change-Id: I6627b5569c2e0f730be7331403218b823a2c622f
Signed-off-by: Patrick Venture <venture@google.com>