phosphor-pid-control/dbus, branch master

Set ignoreDbusMinMax for Stepwise

2019-11-12T00:54:46+00:00

Temperature readings should not be in percent. Add ignoreDbusMinMax as inheritFromDbus was removed. Tested: modified fan floor by changing stepwise controller Change-Id: I1bf4e15ca78bc894dc82dd68e787fd6fbd3d0aef Signed-off-by: James Feist

Add ignoreDbusMinMax to temp configurations

2019-11-12T00:12:45+00:00

Originally 'inheritFromDBus' was only set for fan configurations. This was removed, so now everything was inheriting from Dbus. Set the inverse of 'inheritFromDBus' of ignoreDbusMinMax to temp configurations so that they get the correct reading. Tested: Used sensor override in a loop on a sensor and saw the reading in the pid be correct Change-Id: I29dab298921f9c5204d29341555f2c5d2d011aa2 Signed-off-by: James Feist

conf: add ignoreDbusMinMax option

2019-09-10T17:47:17+00:00

Add an optional field to the sensor configuration, s.t. it'll tell a dbus passive sensor to ignore the MinValue and MaxValue properties from dbus. Signed-off-by: Patrick Venture Change-Id: Ia6a8c802c2dc5bf41e5e860b21d7764cc09e6b6b

Allow setting setpoint based on dynamic thresholds

2019-07-16T14:47:18+00:00

As we allow dynamic thresholds in dbus-sensors to track the t-control of dimms etc, we want to be able to set a setpoint based on a offset from a threshold. This adds the ability to create a "SetPointOffset" that is a threshold of the given sensor. For instance a "SetPointOffset" of "WarningHigh" would get the sensors "WarningHigh" value then add the "SetPoint" value to it (commonly negative for WarningHigh/CriticalHigh). Tested: Turned on debug print and saw correct setpoint being loaded into config Change-Id: Idb9760ea5a66347f24573fb26937f8f278834a19 Signed-off-by: James Feist

sensors: ignore min/max in json for D-Bus passive sensor read

2019-07-11T16:55:51+00:00

min/max values were meant to scale write to be PWM, but were overloaded in commit 75eb769d351434547899186f73ff70ae00d7934a to scale sensor read to percent as well. However currently the D-Bus sensors built from JSON can only specify one pair of min/max values,so they cannot be used for both read/write interfaces. Fix the behavior by ignoring min/max in settings when building D-Bus passive read interface and only read them from D-Bus. Tested: D-Bus passive sensor value is no longer scaled if there is no MinValue/MaxValue specified. Resolves: openbmc/phosphor-pid-control#14 Signed-off-by: Kun Yi Change-Id: I206bbe75c77e79f765eca76cfa015321dcba4aa7

util: Avoid division by invalid value

2019-07-11T04:58:32+00:00

Check for max > min before dividing by difference Signed-off-by: Kun Yi Change-Id: Ic2a983bb6f7c04f1deafcab228b76ff60012f011

dbuspassive: Fix typo in variable check

2019-07-11T04:55:58+00:00

When setting min, should check for min instead of max. Signed-off-by: Kun Yi Change-Id: I0097bb329408f807fea6d68ca0055c5d8215aba3

dbusconfiguration: Protect better against bad config

2019-06-24T23:18:40+00:00

Configurations with no input are not allowed. The current code looked for if there were any sensors avaiable. On our systems an input was not being displayed due to a bug, but the output was there, causing pid control to crash. Protect against this issue. Tested: Had sensor bug in tree, and pid control didn't segfault Change-Id: I42869748bac0b85affae5f5c671b859fec996a54 Signed-off-by: James Feist

Add Fan Redundancy Support

2019-06-05T17:21:16+00:00

This adds fan redundancy support to passive sensors. If there are redundancy interfaces on dbus, we'll fail a sensor if the status is set to failed. Tested: Set Redundancy to Failed On Dbus, saw all fans in collection boost. Then restarted swampd, came up and still boosted. Set redundancy OK, and they all slowed down. Change-Id: I8879bef1471bbc168435d6b22dd20006b9dca133 Signed-off-by: James Feist

Remove FanProfile configuration

2019-05-13T17:48:11+00:00

If we add a "Profiles" vector into the PID and Stepwise entity-manager configurations the logic becomes much more simple. We default to all profiles, and can limit the scope of some configurations to the selected profile. Tested: Switched between Acoustic/Performance mode and saw a UpperClippingCurve get added / removed. Change-Id: Ib0448b59210f696c8a28a99da06f98b065eadf08 Signed-off-by: James Feist