phosphor-pid-control, branch master

Set ignoreDbusMinMax for Stepwise

2019-11-12T00:54:46+00:00

Temperature readings should not be in percent. Add ignoreDbusMinMax as inheritFromDbus was removed. Tested: modified fan floor by changing stepwise controller Change-Id: I1bf4e15ca78bc894dc82dd68e787fd6fbd3d0aef Signed-off-by: James Feist

Add ignoreDbusMinMax to temp configurations

2019-11-12T00:12:45+00:00

Originally 'inheritFromDBus' was only set for fan configurations. This was removed, so now everything was inheriting from Dbus. Set the inverse of 'inheritFromDBus' of ignoreDbusMinMax to temp configurations so that they get the correct reading. Tested: Used sensor override in a loop on a sensor and saw the reading in the pid be correct Change-Id: I29dab298921f9c5204d29341555f2c5d2d011aa2 Signed-off-by: James Feist

Start phoshphor-pid-control after fansensor

2019-11-07T00:35:31+00:00

Occasionally, phosphor-pid-control fails to start logging: swampd[2688]: terminate called after throwing an instance of 'std::runtime_error' swampd[2688]: what(): ObjectMapper Call Failure This happens multiple times: systemd[1]: phosphor-pid-control.service: Main process exited, code=killed, status=6/ABRT systemd[1]: phosphor-pid-control.service: Failed with result 'signal'. systemd[1]: phosphor-pid-control.service: Service RestartSec=1s expired, scheduling restart. systemd[1]: phosphor-pid-control.service: Scheduled restart job, restart counter is at 2. systemd[1]: Stopped Swampd Margin-based Fan Control Daemon. systemd[1]: phosphor-pid-control.service: Start request repeated too quickly. systemd[1]: phosphor-pid-control.service: Failed with result 'signal'. systemd[1]: Failed to start Swampd Margin-based Fan Control Daemon. and systemd gives up and stops trying to restart the service. $ systemctl --no-page status phosphor-pid-control.service * phosphor-pid-control.service - Swampd Margin-based Fan Control Daemon Loaded: loaded (/lib/systemd/system/phosphor-pid-control.service; enabled; vendor preset: enabled) Active: failed (Result: signal) since Thu 2019-10-31 18:05:11 UTC; 1min 56s ago Process: 2738 ExecStart=/usr/bin/swampd (code=killed, signal=ABRT) Main PID: 2738 (code=killed, signal=ABRT) xyz.openbmc_project.fansensor.service is the service from dbus-sensors that phosphor-pid-control uses to interact with the fans and pwms. phosphor-pid-control should not start until after fansensor. Tested: swampd comes up reliably on a system using xyz.openbmc_project.fansensor.service. I have not tried a system that isn't using dbus-sensors. Signed-off-by: Peter Lundgren Change-Id: Iec019bfabcc77279c7dfe8d4899ac07c1c41a428

conf: add ignoreDbusMinMax option

2019-09-10T17:47:17+00:00

Add an optional field to the sensor configuration, s.t. it'll tell a dbus passive sensor to ignore the MinValue and MaxValue properties from dbus. Signed-off-by: Patrick Venture Change-Id: Ia6a8c802c2dc5bf41e5e860b21d7764cc09e6b6b

build: drop flto option to workaround gcc issue

2019-09-09T20:04:06+00:00

main.o swampd-util.o ./.libs/libswampd.a -lstdc++fs -lphosphor_logging -lsdbusplus -lsystemd -lphosphor_dbus 00:59:59 | lto1: internal compiler error: in add_symbol_to_partition_1, at lto/lto-partition.c:154 Signed-off-by: Patrick Venture Change-Id: I387d1530ff7daaa217dce980e357ea612f7ddfdb

sensors: buildjson: only load min/max if type fan

2019-08-29T17:06:29+00:00

The min/max value in the json configuration only provide meaning in the context of a fan sensor. This patch only loads the configuration options in that case, and reports a warning if otherwise detected. Signed-off-by: Patrick Venture Change-Id: I20898ab3c87f4e9c6005683420a30c6685944c96

sensors: buildjson: minor min/max cleanup

2019-08-29T16:49:43+00:00

Signed-off-by: Patrick Venture Change-Id: I9d01753a40f1146d49e1a03a18dbea704f3fff84

s/swampd.service/phosphor-pid-control.service/g

2019-07-18T18:17:06+00:00

Signed-off-by: Patrick Venture Change-Id: Ia1f08915f5541142cb3e10aa68043d3d2cad0167

rename away from RPM

2019-07-16T22:17:11+00:00

The SetPoint output from a thermal PID is likely RPM, and that value is then fed into a fan controller PID as the set-point (unit: RPM). This does not have to be RPM, however. Continue renaming variables and methods to remove the explicit unit-naming. Signed-off-by: Patrick Venture Change-Id: I570dee0c688338f9a458cac7123314717bee2b42

rename RPMSetPoint to SetPoint

2019-07-16T21:16:01+00:00

The PIDs were originally focused on collecting RPM set points from thermal PIDs and then having fan PIDs use the highest value collected, it doesn't need to be strictly an RPM set point. It does however need to be one type of value. Signed-off-by: Patrick Venture Change-Id: I1d589cf4b2688d7e86030c10496d737dc5bbdadf