phosphor-net-ipmid/command, branch master

Cache the user & channel acces in session

2019-04-02T07:46:45+00:00

Instead of querying the user & channel access for every time cache the same during session creation, and use it for enforcements. Tested-by: Verified that RMCP+ session establishment works as expected including INSUFFICIENT_PRIVILEGE error. Change-Id: Ib5a05bd07cc9aabf2625a18090fd905d93489b24 Signed-off-by: Richard Marian Thomaiyar

RAKP12: Don't allow user with NOACCESS priv.

2019-03-25T11:56:41+00:00

Don't allow user to establish session with NOACCESS user privilege. Tested-by: 1. Updated the user privilege to NO_ACCESS and verified RMCP+ session establishement errors out. Change-Id: I787a787a3198a7e0550ac01962e69aab0041cccf Signed-off-by: Richard Marian Thomaiyar

Handle invalid length for Disable Payload command

2019-03-25T02:00:03+00:00

Invalid length error check added for disable payload command Tested: 1. Verified negative case by providing improper length ipmitool -I lanplus -H x.x.x.x -U root -P 0penBmc raw 6 0x49 0x11 0x01 0x00 0x00 0x00 0x00 0x00 0x00 2. Verified normal case works fine. Change-Id: I1d0dfcadb2dbaf4f538597fbff236540127a3667 Signed-off-by: Sumanth Bhat Signed-off-by: Richard Marian Thomaiyar

Handle input - Get channel auth capabilities

2019-03-12T09:04:35+00:00

Handle channel number input in Get Channel authentication capabilities command. Validate input params, and return data accordingly Tested: 1. Verifid RMCP+ successful session establishement 2. ipmitool -I lanplus -H x.x.x.x -U root -P 0penBmc raw 6 0x38 1 4 with response 01 80 04 02 00 00 00 00 3. Verified negative tests like invalid length, invalid field, invalid channel number (Sessionless) Change-Id: Id8b4068b94ead281f00282fd709a3f7944887201 Signed-off-by: Richard Marian Thomaiyar

Convert host-ipmid -> libipmid

2019-02-19T21:10:57+00:00

phosphor-host-ipmid now exposes a library along with headers for interfacing with the ipmi daemon. Compile and link against the new library. Change-Id: Ifb914004df2b73cff913bf653db14ff2e710434f Signed-off-by: William A. Kennington III

Return the maximum privilege in open session command

2019-02-12T18:07:27+00:00

This commit does the following: - Set the maximum privilege role in the session instead of current privilege in the implementation of the open session request/response. - In open session response, return the maximum privilege of the session instead of the current privilege level. - Update RAKP12 and RAKP34 implementation Tested: Checked the session setup works fine with ipmitool and freeipmi utility ipmipower. Change-Id: I41b63b91f08c2ed96856c4db41eedaa878c663e3 Signed-off-by: Tom Joseph

Null username support is removed from Get Channel Auth command

2019-02-09T17:40:48+00:00

Change-Id: I9340c9da524831a68192424c68efc7a4910407d7 Signed-off-by: Tom Joseph

Fix the order of fields in Get Channel Auth Capabilities command

2019-02-09T17:40:15+00:00

Change-Id: Ifd2542725d7e14e96b05b0eded9a5e6d0062d73e Signed-off-by: Tom Joseph

Fix: Set proper session privilege for RAKP 1

2019-01-29T06:38:21+00:00

As per Set session privilege level command in IPMI specification when creating a session through Activate command / RAKP 1 message, it must be established with CALLBACK privilege if requested for callback. All other sessions are initialy set to USER privilege, regardless of the requested maximum privilege. Unit-Test: Verified the ipmi session establishement through -L command for user with USER privilege, and verified that Get Device ID not executed, when established for callback user privilege. Change-Id: I8196b8e857b726773f6727ec5dd3b835f8759cde Signed-off-by: Richard Marian Thomaiyar

Fix: Get Payload info for non active payload

2019-01-28T17:18:29+00:00

Return 0 as session id, for non active payload instance instead of failure error code. This is as per IPMI specification Get Payload Instance Info command. Unit-test: 1. Verified the reponse of ipmitool -I lanplus -H 127.0.0.1 -U root -P 0penBmc raw 6 0x4B 1 1 with session id 0, when no SOL is session is active, and with proper session id, when SOL session is active Change-Id: I41e5378606f8f4d4c15f1bb07fd635098b837f4a Signed-off-by: Richard Marian Thomaiyar