phosphor-net-ipmid, branch master

Skip IPMI Payload commands - IPMI Mesg disabled

2019-04-02T08:30:10+00:00

Skip IPMI Payload type commands, if IPMI messaging is disabled for the user. Tested-by: Verified that commands are not executed through RMCP+ when IPMI Messaging is disabled for the user through Set Channel Acess command. Verified the reverse too. Change-Id: Ibcfd2a18ccc8b0c498eb06ffb56363b94a735b5e Signed-off-by: Richard Marian Thomaiyar

Cache the user & channel acces in session

2019-04-02T07:46:45+00:00

Instead of querying the user & channel access for every time cache the same during session creation, and use it for enforcements. Tested-by: Verified that RMCP+ session establishment works as expected including INSUFFICIENT_PRIVILEGE error. Change-Id: Ib5a05bd07cc9aabf2625a18090fd905d93489b24 Signed-off-by: Richard Marian Thomaiyar

build: install into bin instead of sbin

2019-04-01T17:09:36+00:00

Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture Change-Id: I6ce824eb1be11356c0b902f90bdc6e8c2ede950c

Update IPMI max session count from 5 to 15

2019-03-29T21:39:54+00:00

According to the IPMI spec,No of possible active session is one byte - BIT5-BIT0 so 63 is the max active session we can have. - 15 was chosen as it seems to be reasonable. Tested: Able to establish the 14 LAN sessions and 1 reserved for sessionless connection. Get session Info command should provide 15 as max no of ipmi session Signed-off-by: Suryakanth Sekar Change-Id: I1bc2003502f35c1d15de18cdf2874cd6ce74006e

RAKP12: Don't allow user with NOACCESS priv.

2019-03-25T11:56:41+00:00

Don't allow user to establish session with NOACCESS user privilege. Tested-by: 1. Updated the user privilege to NO_ACCESS and verified RMCP+ session establishement errors out. Change-Id: I787a787a3198a7e0550ac01962e69aab0041cccf Signed-off-by: Richard Marian Thomaiyar

Handle invalid length for Disable Payload command

2019-03-25T02:00:03+00:00

Invalid length error check added for disable payload command Tested: 1. Verified negative case by providing improper length ipmitool -I lanplus -H x.x.x.x -U root -P 0penBmc raw 6 0x49 0x11 0x01 0x00 0x00 0x00 0x00 0x00 0x00 2. Verified normal case works fine. Change-Id: I1d0dfcadb2dbaf4f538597fbff236540127a3667 Signed-off-by: Sumanth Bhat Signed-off-by: Richard Marian Thomaiyar

Handle input - Get channel auth capabilities

2019-03-12T09:04:35+00:00

Handle channel number input in Get Channel authentication capabilities command. Validate input params, and return data accordingly Tested: 1. Verifid RMCP+ successful session establishement 2. ipmitool -I lanplus -H x.x.x.x -U root -P 0penBmc raw 6 0x38 1 4 with response 01 80 04 02 00 00 00 00 3. Verified negative tests like invalid length, invalid field, invalid channel number (Sessionless) Change-Id: Id8b4068b94ead281f00282fd709a3f7944887201 Signed-off-by: Richard Marian Thomaiyar

netipmid: Remove unused event references

2019-02-25T22:40:59+00:00

Now that all the provider libraries are only loaded by the main ipmid queue, there are no callers for the event object, so it can be removed. The same goes for the event loop; all users of the sd_event object have been replaced with boost::asio, so it can be removed. Change-Id: Id271c4960a2c5386d6163cc9baecdc368e5e328f Signed-off-by: Vernon Mauery

netipmid: make Handler asynchronous

2019-02-25T22:40:59+00:00

The dbus call to the main ipmid queue was up to this point synchronous, which means it blocks all other networking and execution until the main queue returns (which may be on the order of seconds for some commands). This is an unacceptable delay, especially when this queue is responsible for timely updates of SOL traffic. This turns the call into an asynchronous one by leveraging shared pointers and an optional action on destruction. So as long as a reference to the Handler object exists, it will live on, waiting to send its response. Once the async dbus call has returned and set the reply in the Handler, it will drop the reference to the shared pointer and the destructor will send out the response over the channel. Tested-by: Run multiple sessions at the same time while monitoring dbus traffic. See that the requests and responses may be interleaved instead of serial. Change-Id: I16fca8dc3d13624eeb1592ec36d1a9af6575f115 Signed-off-by: Vernon Mauery

netipmid: move to sdbusplus::asio from sdbusplus

2019-02-25T22:40:59+00:00

To be able to support asynchronous dbus calls, the main bus object should be an sdbusplus::asio::connection. Change-Id: Ib7d3474eb32505d2326f0d6db9566528a58ccd03 Signed-off-by: Vernon Mauery