1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
|
Copyright 2017 IBM
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
MBOX
====
This repo contains the protocol definition for the host to BMC mailbox
communication specification which can be found in
Documentation/mbox_procotol.md.
There is also a reference implementation of a BMC mailbox daemon, the details
of which can be found in Documentation/mboxd.md.
Finally there is also an implementation of a mailbox daemon control program, the
details of which can be found in Documentation/mboxctl.md.
Style Guide
===========
Preamble
--------
This codebase is a mix of C (due to its heritage) and C++. This is an ugly
split: message logging and error handling can be vastly different inside the
same codebase. The aim is to remove the split one way or the other over time
and have consistent approaches to solving problems.
phosphor-mboxd is developed as part of the OpenBMC project, which also leads to
integration of frameworks such as
[phosphor-logging](https://github.com/openbmc/phosphor-logging). Specifically
on phosphor-logging, it's noted that without care we can achieve absurd
duplication or irritating splits in where errors are reported, as the C code is
not capable of making use of the interfaces provided.
Rules
-----
1. Message logging MUST be done to stdout or stderr, and MUST NOT be done
directly via journal APIs or wrappers of the journal APIs.
Rationale:
We have two scenarios where we care about output, with the important
restriction that the method must be consistent between C and C++:
1. Running in-context on an OpenBMC-based system
2. Running the test suite
In the first case it is desirable that the messages appear in the system
journal. To this end, systemd will by default capture stdout and stderr of
the launched binary and redirect it to the journal.
In the second case it is *desirable* that messages be captured by the test
runner (`make check`) for test failure analysis, and it is *undesirable* for
messages to appear in the system journal (as these are tests, not issues
affecting the health of the system they are being executed on).
Therefore direct calls to the journal MUST be avoided for the purpose of
message logging.
Note: This section specifically targets the use of phosphor-logging's
`log<T>()`. It does not prevent the use of `elog<T>()`.
|
