diff options
author | Ratan Gupta <ratagupt@in.ibm.com> | 2017-05-05 17:34:00 +0530 |
---|---|---|
committer | Patrick Williams <patrick@stwcx.xyz> | 2017-06-02 03:35:22 +0000 |
commit | 90b92fe48ec72b6c15cce24d33ac983548368b98 (patch) | |
tree | 3bd93add19f4e71dc8ca34d8b1e7cba9bbd90586 | |
parent | b3d88c439278b931863344306ff9b5532dc1028f (diff) | |
download | phosphor-mboxd-90b92fe48ec72b6c15cce24d33ac983548368b98.tar.gz phosphor-mboxd-90b92fe48ec72b6c15cce24d33ac983548368b98.zip |
Make the code compatible with c++ compiler
if we write "int i;" in header file, c compiler treats
as a tentative definition while c++ compiler
treats as a definition.
so when two cpp file includes the same header file
then during linking time compiler says that there are
multiple definitions.
so to overcome this problem we are declaring it as extern
and defining it in the corresponding c file.
Change-Id: I91378c4c587414edf35f8313f2497268be36e2f4
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
-rw-r--r-- | common.c | 4 | ||||
-rw-r--r-- | common.h | 8 | ||||
-rw-r--r-- | test/tmpf.h | 2 |
3 files changed, 10 insertions, 4 deletions
@@ -26,6 +26,10 @@ #include "common.h" +void (*mbox_vlog)(int p, const char *fmt, va_list args); + +enum verbose verbosity; + void mbox_log_console(int p, const char *fmt, va_list args) { struct timespec time; @@ -25,11 +25,13 @@ #define PREFIX "" #endif -enum { +enum verbose { MBOX_LOG_NONE = 0, MBOX_LOG_INFO = 1, MBOX_LOG_DEBUG = 2 -} verbosity; +}; + +extern enum verbose verbosity; /* Error Messages */ #define MSG_ERR(f_, ...) mbox_log(LOG_ERR, f_, ##__VA_ARGS__) @@ -42,7 +44,7 @@ enum { mbox_log(LOG_DEBUG, f_, ##__VA_ARGS__); \ } } while(0) -void (*mbox_vlog)(int p, const char *fmt, va_list args); +extern void (*mbox_vlog)(int p, const char *fmt, va_list args); void mbox_log_console(int p, const char *fmt, va_list args); diff --git a/test/tmpf.h b/test/tmpf.h index 61db73d..ce47191 100644 --- a/test/tmpf.h +++ b/test/tmpf.h @@ -27,7 +27,7 @@ struct tmpf { char path[PATH_MAX]; }; -int tmpf_init(struct tmpf *tmpf, const char *template); +int tmpf_init(struct tmpf *tmpf, const char *template_str); void tmpf_destroy(struct tmpf *tmpf); |