summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Jeffery <andrew@aj.id.au>2018-08-30 12:01:40 +0930
committerAndrew Jeffery <andrew@aj.id.au>2018-09-14 16:52:34 +0930
commitcda29646272d0e44a002087079b588a272603093 (patch)
tree62d2a35bdb22208b1e6a5eddc89eb4448d2431b7
parentc84b8f8f6fec341215f8317173be3603c3bca05a (diff)
downloadphosphor-mboxbridge-cda29646272d0e44a002087079b588a272603093.tar.gz
phosphor-mboxbridge-cda29646272d0e44a002087079b588a272603093.zip
control: Add FIXME in reset handling
windows_reset_all() doesn't perform a flush of the currently open window like the comment suggests. Iron out whether the comment or the behaviour is incorrect. Change-Id: Id10384651c02e397f4c8d2a749b66f8881bfe08b Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
-rw-r--r--control.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/control.c b/control.c
index 7eae29c..ceada6b 100644
--- a/control.c
+++ b/control.c
@@ -43,6 +43,7 @@ int control_reset(struct mbox_context *context)
return -EBUSY;
}
+ /* FIXME: Comment below is wrong: windows_reset_all() does not flush! */
/*
* This will close (and flush) the current window and reset the lpc bus
* mapping back to flash, or memory in case we're using a virtual pnor.
OpenPOWER on IntegriCloud