OpenBMC Phosphor Flash mailbox bridge daemon sources https://git.raptorcs.com/git/phosphor-mboxbridge/atom?h=master 2019-03-19T06:11:19+00:00 2019-03-19T06:11:19+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-19T04:23:01+00:00 urn:sha1:81059e32dfd5e8e629f30bb55f40ade65f2b0953 Better that we try to keep all the conditional junk near the top of the tree. Change-Id: Ic9e8dca892dcf15607bace9f630f4d107e1a4b4e Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:17+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T02:53:46+00:00 urn:sha1:de08ca2d69609f58e7787620f13d3b05c19697e5 Change-Id: I95c5129aa81a7b4a4d88ce2f7edf6a10a3c94b98 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:16+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T02:47:08+00:00 urn:sha1:fb01e14eb11f7862066e1ef29a9b25504a52b4db Change-Id: I7fb3ba5071c94595449c5469625564233cc8d752 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:15+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T02:39:59+00:00 urn:sha1:dec59b47c5ba50a5ece7633b89e227373a1869b8 Change-Id: I1bb919eec2a12403474d58540c52beab8664b8b8 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:12+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T02:32:01+00:00 urn:sha1:035ad76b8b45a01cc7fcc184e7e72eed69c0ece5 Change-Id: Ibf66c3a86c2a50e2304fb968f8c912ede84cf719 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:02+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T01:39:48+00:00 urn:sha1:f4bc335b4fc899509c92c230f746fe90a5aa43d2 Change-Id: I6f0fff4ab54e011c1765fc04186e899754787641 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-18T00:16:11+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-14T06:06:27+00:00 urn:sha1:0297e5b82ea1bf8b151f8208c5f28a121d82eb4c The flash API compatibility was kept to reduce the line noise in the previous backend patch. Remove the compatibility layer now and convert the remaining call-sites. Change-Id: I4b6e54f4463059a7804918add81e7572db7b7c21 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-18T00:16:11+00:00 Evan Lojewski github@meklort.com 2019-03-14T04:04:33+00:00 urn:sha1:f1e547c74563d59f60d918c6fa673bb8cee6e669 Introduce a backend abstraction, enabling multiple implementations to be compiled in at once. This change formally abstracts the two existing backends, mtd and vpnor. With the backend abstraction in place, subsequent backends are easier to implement. This change is based of Evan's work and he retains authorship credit. I (AJ) have reworked the patch to pass the vpnor tests, refactored some parts to enable broader use of const structures and others to clarify the initialisation sequences. Due to the existing lack of abstraction the patch has unfortunately wide-ranging impacts. I've whittled it down as much as I consider reasonable. Change-Id: I29984a36dae4ea86ec00b853d2a756f0b9afb3ec Signed-off-by: Evan Lojewski <github@meklort.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-18T00:16:11+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-14T23:24:33+00:00 urn:sha1:cb93504ed0fefa23186415accca6c0812174f274 Clean up the protocol_negotiate_version() mess. The existing approach came about due to viewing the vpnor implementation as an edge case in its own right. The code becomes much neater if we consider all backends as equal and afford them the callbacks necessary for correct behaviour. Change-Id: Ifaeee9da459818cf22b2f137ddc5b8d0356b9be9 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-15T12:08:43+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-13T23:27:28+00:00 urn:sha1:261f61a1747a9ebf092d4f426e891ff94ad33ffc Include ordering and whether or not C linkage is forced by `extern "C"` blocks can cause headaches at link time. Ensure that all C dependencies are included in an `extern C` block before other includes occur. Also include the C++ versions of string.h and assert.h Change-Id: Ia96f6044d40c8eccb907b65924efcf62ac7a89c3 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>