phosphor-mboxbridge/vpnor/test/Makefile.am.include, branch master

Makefiles: Centralise some use of VIRTUAL_PNOR_ENABLED

2019-03-19T06:11:19+00:00

Better that we try to keep all the conditional junk near the top of the tree. Change-Id: Ic9e8dca892dcf15607bace9f630f4d107e1a4b4e Signed-off-by: Andrew Jeffery

vpnor: Rename pnor_partition_table sources to table

2019-03-19T06:11:17+00:00

Change-Id: I95c5129aa81a7b4a4d88ce2f7edf6a10a3c94b98 Signed-off-by: Andrew Jeffery

vpnor: Rename pnor_partition sources to partition

2019-03-19T06:11:16+00:00

Change-Id: I7fb3ba5071c94595449c5469625564233cc8d752 Signed-off-by: Andrew Jeffery

vpnor: Consolidate backend and mboxd_pnor_partition_table sources

2019-03-19T06:11:12+00:00

Change-Id: Ibf66c3a86c2a50e2304fb968f8c912ede84cf719 Signed-off-by: Andrew Jeffery

mboxd: Add a backend abstraction layer to mboxd.

2019-03-18T00:16:11+00:00

Introduce a backend abstraction, enabling multiple implementations to be compiled in at once. This change formally abstracts the two existing backends, mtd and vpnor. With the backend abstraction in place, subsequent backends are easier to implement. This change is based of Evan's work and he retains authorship credit. I (AJ) have reworked the patch to pass the vpnor tests, refactored some parts to enable broader use of const structures and others to clarify the initialisation sequences. Due to the existing lack of abstraction the patch has unfortunately wide-ranging impacts. I've whittled it down as much as I consider reasonable. Change-Id: I29984a36dae4ea86ec00b853d2a756f0b9afb3ec Signed-off-by: Evan Lojewski Signed-off-by: Andrew Jeffery

flash: Introduce flash_validate()

2019-03-18T00:16:11+00:00

Clean up the protocol_negotiate_version() mess. The existing approach came about due to viewing the vpnor implementation as an edge case in its own right. The code becomes much neater if we consider all backends as equal and afford them the callbacks necessary for correct behaviour. Change-Id: Ifaeee9da459818cf22b2f137ddc5b8d0356b9be9 Signed-off-by: Andrew Jeffery

vpnor: Enforce a read-only FFS ToC regardless of flags

2019-01-08T03:11:04+00:00

The virtual PNOR implementation never properly honoured writes to the FFS ToC, as the ToC's binary representation is generated from the CSV file shipped in the PNOR squashfs image. What *did* happen was that opening a write window to the ToC region succeeded and writes could be flushed, but the flushed writes were never read, and ToC representation internal to mboxd was never updated to match the written state. Thus the written values "persisted" until the ToC's window fell out of the cache (with 64MiB reserved regions, probably on a host reboot). Short circuit the insanity of handling FFS more than we have to by forcefully marking the ToC as read-only, regardless of the flag configuration shipped in the CSV representation. This prevents the host from successfully opening a write window and thus the host can have no expectation of write persistence. Change-Id: Ib2788c56b245da506cb7d607c0758b17785766cf Signed-off-by: Andrew Jeffery

vpnor: test: Add force_readonly_toc

2019-01-08T03:11:04+00:00

This ensures that the ToC presented to the host indicates that it is not writable. The virtual PNOR implementation has never properly honoured writes to the ToC, so lets at least tell the host. As the code has not yet been fixed to implement the desired behaviour, add the test to XFAIL_TESTS. Change-Id: Ia13a0f907f916d6dec3979b17685d54bc578a106 Signed-off-by: Andrew Jeffery

vpnor: Add write-to-writable-ToC test

2019-01-08T03:11:04+00:00

Tests if mutations survive re-opening the window. They don't, so add the test to XFAIL_TESTS. Change-Id: Ic2f844c30a7da35033bf03012ea452718d2843e4 Signed-off-by: Andrew Jeffery

vpnor: Hijack protocol rather than transport

2018-09-12T05:35:51+00:00

By hijacking the transport the changes in behaviour were limited to the mailbox interface. Now that we have a DBus interface as well this would lead to inconsistent behaviour dependent on the transport. Instead of hooking the transport, push the hook down to the protocol level where we will achieve consistent behaviour across all transports. Change-Id: I437866a6dbda107149336c15a00ee1aa058f5875 Signed-off-by: Andrew Jeffery