OpenBMC Phosphor Flash mailbox bridge daemon sources https://git.raptorcs.com/git/phosphor-mboxbridge/atom?h=master 2019-03-19T06:10:59+00:00 2019-03-19T06:10:59+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-15T02:10:41+00:00 urn:sha1:5320f6e02453261e6c75d3bef101ad1bef6de82e Also implement a backend commandline option to mboxctl: `mboxctl --backend ...`, to allow easy run-time switching of the backend from the commandline. Switching between VPNOR and file backends via mboxctl was tested on Witherspoon, and MTD and file backends on Romulus. Change-Id: Iaf0e27ecf1d5cdd9e3a31729fb179096bbc37408 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-18T00:16:11+00:00 Evan Lojewski github@meklort.com 2019-03-14T04:04:33+00:00 urn:sha1:f1e547c74563d59f60d918c6fa673bb8cee6e669 Introduce a backend abstraction, enabling multiple implementations to be compiled in at once. This change formally abstracts the two existing backends, mtd and vpnor. With the backend abstraction in place, subsequent backends are easier to implement. This change is based of Evan's work and he retains authorship credit. I (AJ) have reworked the patch to pass the vpnor tests, refactored some parts to enable broader use of const structures and others to clarify the initialisation sequences. Due to the existing lack of abstraction the patch has unfortunately wide-ranging impacts. I've whittled it down as much as I consider reasonable. Change-Id: I29984a36dae4ea86ec00b853d2a756f0b9afb3ec Signed-off-by: Evan Lojewski <github@meklort.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-18T00:16:11+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-14T23:24:33+00:00 urn:sha1:cb93504ed0fefa23186415accca6c0812174f274 Clean up the protocol_negotiate_version() mess. The existing approach came about due to viewing the vpnor implementation as an edge case in its own right. The code becomes much neater if we consider all backends as equal and afford them the callbacks necessary for correct behaviour. Change-Id: Ifaeee9da459818cf22b2f137ddc5b8d0356b9be9 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-15T12:12:12+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-14T06:12:15+00:00 urn:sha1:2dfc2a22a26b8726b1da336e952c3d05ebe02aed Otherwise we observe invalid memory accesses due to uninitialised variables. Change-Id: I8b9063ccc9a25b225a562ebe120f2a99a28788ca Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-14T07:22:34+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-28T07:20:09+00:00 urn:sha1:c84b8f8f6fec341215f8317173be3603c3bca05a Tests for the condition where the minimum age is less than any window's current age, in which case we can get a NULL dereference if the windows_reset_all() implementation is broken. windows.c:409:23: runtime error: member access within null pointer of type 'struct window_context' ASAN:DEADLYSIGNAL ================================================================= ==31400==ERROR: AddressSanitizer: SEGV on unknown address 0x00000004 (pc 0x0002b658 bp 0x74c00270 sp 0x7eb7c678 T0) ==31400==The signal is caused by a WRITE memory access. ==31400==Hint: address points to the zero page. #0 0x2b657 in window_reset windows.c:410 #1 0x2cc9b in windows_create_map windows.c:572 #2 0x1f3f3 in protocol_v1_create_window protocol.c:167 #3 0x2121b in protocol_v2_create_window protocol.c:417 #4 0x24cd7f in generic_vpnor_create_window vpnor/protocol.cpp:51 #5 0x24d053 in protocol_v2_vpnor_create_window vpnor/protocol.cpp:63 #6 0x2663b in mbox_handle_create_window transport_mbox.c:282 #7 0x276db in handle_mbox_req transport_mbox.c:568 #8 0x276db in transport_mbox_dispatch transport_mbox.c:649 #9 0x17fcb in poll_loop mboxd.c:185 #10 0x17fcb in main mboxd.c:423 #11 0x46b68517 in __libc_start_main (/lib/libc.so.6+0x46b68517) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV windows.c:410 in window_reset ==31400==ABORTING Change-Id: I8161e2ea17953e196d4bb3ca90d19e44ec10c86d Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-12T05:35:51+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-08T02:13:08+00:00 urn:sha1:c7d1947e88d9cf7c3ab7ac73a1b34b312ce5f361 By hijacking the transport the changes in behaviour were limited to the mailbox interface. Now that we have a DBus interface as well this would lead to inconsistent behaviour dependent on the transport. Instead of hooking the transport, push the hook down to the protocol level where we will achieve consistent behaviour across all transports. Change-Id: I437866a6dbda107149336c15a00ee1aa058f5875 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-12T05:35:51+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-07T04:02:57+00:00 urn:sha1:1e531afd1698c5613004e2bf4e73bda4364fa6d6 Change-Id: Ie3338714813bb65f5d37fcd046dd5bebc0ba21f0 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-12T05:32:10+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-08T01:51:08+00:00 urn:sha1:457a6e5fa6a7dad50673222b09b2c7fec2ef0a97 Change-Id: I0f4e206648c02a98fa938a7e582470c8d90904f1 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-05T08:14:24+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-08T01:31:04+00:00 urn:sha1:f593b1bd1a56c562212bcacbd8f9c5c5fe9e5994 Change-Id: I44e110906fd0f751f8f34b175f971e65896a7301 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2018-09-05T08:14:24+00:00 Andrew Jeffery andrew@aj.id.au 2018-08-08T01:17:55+00:00 urn:sha1:cd18611e279b074420f0c643ab070ac38591aec7 Change-Id: I289618c90b2df8911e362397b7eab99403c86c05 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>