OpenBMC Phosphor Flash mailbox bridge daemon sources https://git.raptorcs.com/git/phosphor-mboxbridge/atom?h=master 2019-04-05T04:42:24+00:00 2019-04-05T04:42:24+00:00 Andrew Jeffery andrew@aj.id.au 2019-04-04T06:22:36+00:00 urn:sha1:a804a73c39e12016cb94da9bf2de84be50ed68ad GetDaemonState and GetLpcState were converted from methods to properties and renamed to DaemonState and LpcState respectively in mboxd. mboxctl was overlooked in the change, so update it to match. Change-Id: I34f55a036b14c611925b164e354934769e1e0759 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-04-05T04:42:24+00:00 Andrew Jeffery andrew@aj.id.au 2019-04-04T06:27:12+00:00 urn:sha1:c03b8af168c7478e5bedf0c9312d5f4233f205b1 The grass was greener :) Change-Id: I598a2faddac181684a7924d4db117b534cc7d8ad Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-04-02T05:59:52+00:00 Lei YU mine260309@gmail.com 2019-03-08T05:56:53+00:00 urn:sha1:81d27b0453982623e27bcdec217fc1659203a8bf The tool refernced in table.hpp is renamed to generate-tar. Update the comment in code. Change-Id: I67f75dbe5018ab71d65f87ee14093c3972eb5846 Signed-off-by: Lei YU <mine260309@gmail.com> 2019-03-31T22:58:34+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-31T22:58:23+00:00 urn:sha1:76c73772c356bd62b8708c81094c43620d403e27 Commit e50e654bca8d ("Add --trace support (in blktrace format)") is a broken version of commit ef0c8360065e ("Add --trace support (in blktrace format)") that appears in master's linear history. Merging e50e654bca8d preserves the ability to bisect the openbmc/openbmc respository. The merge was performed as below, which discards any changes performed in e50e654bca8d: > $ git merge -s ours e50e654bca8df8254c15849c793f9279adcb1182 Change-Id: I134be5a54303a561ed3ef21813b1e220c0dbd0a6 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-29T06:40:08+00:00 Stewart Smith stewart@linux.ibm.com 2018-11-19T02:49:46+00:00 urn:sha1:ef0c8360065eba7f353f4ac866a1f6f86bf18cf4 In an effort understand what PNOR requests come from the host, it'd be good to be able to trace what requests come in and visualise them. blktrace is some Linux infrastructure for tracing block device activity all the way through the linux block layer, for which there is a variety of existing tooling. These tools process the (typically) kernel produced blktrace output. We can produce this same output programatically from mboxd though. This patch gives us the (option) to start mboxd in a mode where it will write a blktrace file out, which can be fed into tools like blkparse(1) or tools like iowatcher[1] to generate charts (and video). A quirk of the blktrace format is that it's very geared towards a full IO subsystem, so we can't directly map window operations (what we know in mboxd) to specific IO ops (i.e. we don't get "firmware read one page out of this window before closing it"). So, for each Window opening (or reusing a cached one), we write THREE blktrace events: a Queue, Dispatch, and Complete. We can usk tools like blkparse to do everything from get a detailed list of what windows were opened and for how long: 0,0 0 1 0.000000000 0 Q R 0 + 8 [(null)] 0,0 0 2 0.000000000 0 D R 0 + 8 [(null)] 0,0 0 3 0.000182022 0 C R 0 + 8 [0] 0,0 0 4 0.042416351 0 Q R 4144 + 2040 [(null)] 0,0 0 5 0.042416351 0 D R 4144 + 2040 [(null)] 0,0 0 6 0.060802662 0 C R 4144 + 2040 [0] 0,0 0 7 0.084775813 0 Q R 64 + 288 [(null)] 0,0 0 8 0.084775813 0 D R 64 + 288 [(null)] 0,0 0 9 0.087835720 0 C R 64 + 288 [0] 0,0 0 10 1.429234244 0 Q R 8488 + 2048 [(null)] to getting a simple summary at the end of how many windows were opened read and read/write: CPU0 (0,0): Reads Queued: 90, 74,040KiB Writes Queued: 6, 2,664KiB Read Dispatches: 90, 74,040KiB Write Dispatches: 6, 2,664KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 90, 74,040KiB Writes Completed: 6, 2,664KiB Read Merges: 0, 0KiB Write Merges: 0, 0KiB Read depth: 1 Write depth: 1 IO unplugs: 0 Timer unplugs: 0 If you change the window size to something tiny, like 4096 bytes, you can get detailed paging information for hostboot at the expense of IPL time. Pretty graphs and animations: https://www.flamingspork.com/blog/?p=4419 [1] iowatcher: http://masoncoding.com/iowatcher/ Change-Id: I5dd02b6bc616c441abf54d87a5d67c972cbaf228 Signed-off-by: Stewart Smith <stewart@linux.ibm.com> [AJ: Resolve merge conflicts, some tidy ups] Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-26T06:01:22+00:00 Stewart Smith stewart@linux.ibm.com 2018-11-19T02:49:46+00:00 urn:sha1:e50e654bca8df8254c15849c793f9279adcb1182 In an effort understand what PNOR requests come from the host, it'd be good to be able to trace what requests come in and visualise them. blktrace is some Linux infrastructure for tracing block device activity all the way through the linux block layer, for which there is a variety of existing tooling. These tools process the (typically) kernel produced blktrace output. We can produce this same output programatically from mboxd though. This patch gives us the (option) to start mboxd in a mode where it will write a blktrace file out, which can be fed into tools like blkparse(1) or tools like iowatcher[1] to generate charts (and video). A quirk of the blktrace format is that it's very geared towards a full IO subsystem, so we can't directly map window operations (what we know in mboxd) to specific IO ops (i.e. we don't get "firmware read one page out of this window before closing it"). So, for each Window opening (or reusing a cached one), we write THREE blktrace events: a Queue, Dispatch, and Complete. We can usk tools like blkparse to do everything from get a detailed list of what windows were opened and for how long: 0,0 0 1 0.000000000 0 Q R 0 + 8 [(null)] 0,0 0 2 0.000000000 0 D R 0 + 8 [(null)] 0,0 0 3 0.000182022 0 C R 0 + 8 [0] 0,0 0 4 0.042416351 0 Q R 4144 + 2040 [(null)] 0,0 0 5 0.042416351 0 D R 4144 + 2040 [(null)] 0,0 0 6 0.060802662 0 C R 4144 + 2040 [0] 0,0 0 7 0.084775813 0 Q R 64 + 288 [(null)] 0,0 0 8 0.084775813 0 D R 64 + 288 [(null)] 0,0 0 9 0.087835720 0 C R 64 + 288 [0] 0,0 0 10 1.429234244 0 Q R 8488 + 2048 [(null)] to getting a simple summary at the end of how many windows were opened read and read/write: CPU0 (0,0): Reads Queued: 90, 74,040KiB Writes Queued: 6, 2,664KiB Read Dispatches: 90, 74,040KiB Write Dispatches: 6, 2,664KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 90, 74,040KiB Writes Completed: 6, 2,664KiB Read Merges: 0, 0KiB Write Merges: 0, 0KiB Read depth: 1 Write depth: 1 IO unplugs: 0 Timer unplugs: 0 If you change the window size to something tiny, like 4096 bytes, you can get detailed paging information for hostboot at the expense of IPL time. Pretty graphs and animations: https://www.flamingspork.com/blog/?p=4419 [1] iowatcher: http://masoncoding.com/iowatcher/ Change-Id: I5dd02b6bc616c441abf54d87a5d67c972cbaf228 Signed-off-by: Stewart Smith <stewart@linux.ibm.com> [AJ: Resolve merge conflicts, some tidy ups] Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-20T04:36:16+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-19T04:25:31+00:00 urn:sha1:4519bb82624e8a80905b2914334edd27fbe61029 The merge of phosphor-mboxd and mboxbridge blew away the content. No-one has complained, so remove the broken file. Change-Id: Ic52bb4c3946b03485197efce1f6c6ff7ef714c1c Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:20+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-19T04:44:13+00:00 urn:sha1:4ef0c13275fd1a7c1b86859cfada003670bbbe20 Don't try to cleanup objects we haven't initialised. Change-Id: I218ab785af36bc3a1d3085c9dcd575e812402433 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:19+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-19T04:23:01+00:00 urn:sha1:81059e32dfd5e8e629f30bb55f40ade65f2b0953 Better that we try to keep all the conditional junk near the top of the tree. Change-Id: Ic9e8dca892dcf15607bace9f630f4d107e1a4b4e Signed-off-by: Andrew Jeffery <andrew@aj.id.au> 2019-03-19T06:11:17+00:00 Andrew Jeffery andrew@aj.id.au 2019-03-18T02:53:46+00:00 urn:sha1:de08ca2d69609f58e7787620f13d3b05c19697e5 Change-Id: I95c5129aa81a7b4a4d88ce2f7edf6a10a3c94b98 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>