phosphor-logging/tools, branch master

Empty set for no elog lookup meta data

2019-08-13T15:24:53+00:00

Create an empty set when there is no elog lookup meta data instead of defaulting to add a single empty string entry. Tested: Built image and verified empty string no longer in errors where no meta data is defined. Change-Id: I7bf1ff2ab18f174d4cfa78cf22eeac4918033148 Signed-off-by: Matthew Barth

Remove empty entries in elog lookup meta data

2019-08-12T20:22:01+00:00

A journal entry is produced for failure to find empty string meta data for elogs due to an empty string entry within the generated elog lookup source. This empty string is due to error yamls that do not contain any meta data entry of their own and only inherit from another error yaml. An example of the journal entry for the empty string meta data that is removed with this fix:: CODE_LINE=76 CODE_FUNC=helper_log _SYSTEMD_SLICE=system.slice CODE_FILE=../git/phosphor-logging/log.hpp MESSAGE=Failed to find metadata TRANSACTION_ID=4016514682 META_FIELD= SYSLOG_IDENTIFIER=phosphor-log-manager _PID=181 _COMM=phosphor-log-ma _EXE=/usr/bin/phosphor-log-manager Tested: Built image and verified empty string entry no longer generated on errors without meta data but inherit meta data from other error yaml Change-Id: I3c8745acd86173873827cd59eb6e8d4f687b0e1b Signed-off-by: Matthew Barth

tools/elog-gen: Clean up missing error metadata message

2018-10-05T02:17:39+00:00

Change-Id: I880cf6793e64db29a6eee74839f5a5bdabb1dff2 Signed-off-by: William A. Kennington III

elog-gen: allow inherits from errors without meta

2018-07-20T09:02:20+00:00

Previously, elog-gen only support inherits from errors that have meta, and if we inherit from an error without meta, e.g. Common.InternalFailure, we get build error like: KeyError: 'xyz.openbmc_project.Common.InternalFailure' This commit makes elog-gen to allow such case, so it is possible to allow a base error without meta, and inheriting error with additional error, e.g. # In Common: - name: NotAllowed ## No meta # In Time: - name: NotAllowed inherits: - xyz.openbmc_project.Common.NotAllowed meta: - str: "OWNER=%s" type: string - str: "SYNC_METHOD=%s" type: string Note: the "inherit" here does not mean the the error inherits from base errors in c++ class, it just makes error "logically" inherits base errors. And in future commits we could make it "really" inherits base errors in c++ level. Tested: Verify phosphor-logging builds correctly with above example error interfaces, and service is able to use such errors with elog. Change-Id: I8dccd7112881e3eb77a8f6ec62a532062348d2ef Signed-off-by: Lei YU

templates: Allow use of -fsanitize=undefined

2018-03-07T14:10:55+00:00

Push down the str member to avoid linker errors about the lack of storage for str when using -fsanitize=undefined. Change-Id: I1a6b1ba9632aa6e4294573a6be3252d5230992b9 Signed-off-by: Andrew Jeffery

Spelling fixes

2017-10-31T13:36:25+00:00

Spelling errors found using github.com/lucasdemarchi/codespell A tool to fix common misspellings. This tool is licensed under GNU General Public License, version 2. Change-Id: Idea8f76487125a7c7334b415a369c73d9fac40c4 Signed-off-by: Gunnar Mills

fix checkstop error logged as INFO

2017-06-20T11:31:37+00:00

Fix lookup mako template to use sdbus++ error name in error level and error meta map. Resolves openbmc/openbmc#1800 Change-Id: Id3bd7d8113ad0305f25a8fc321f6b79ab5033bb0 Signed-off-by: Marri Devender Rao

elog-gen: python3 fixes for print

2017-06-03T20:48:42+00:00

In python3 print requires () wrapping around parameters. Change-Id: I830ef0d0e8c9e42c1157b708153bf96599346977 Signed-off-by: Patrick Williams

Remove inheriting from sdbus exception for error metadata

2017-06-03T13:07:31+00:00

For logging/reporting exceptions, applications need to use exceptions generated by using sdbus++. For metadata, use header file generated by elog-gen script. Change-Id: Id8f61f8692bfd694d8875359d883465c1124bedf Signed-off-by: Marri Devender Rao

Allow parsing of error yaml files without metadata yaml file

2017-06-03T13:07:31+00:00

At present parser throws error if metadata yaml file is not found, modified to not to return error. Restruture the code to loop through the entries in the error yaml file rather than through the meta yaml file. Change-Id: Iaae61690201aeffd8d9caa41515b29b7cc0b59a2 Signed-off-by: Marri Devender Rao