phosphor-led-sysfs, branch master

physical: Conform to LED class kernel ABI

2019-04-08T04:18:50+00:00

The kernel says the following about the LED sysfs interface: > LED handling under Linux > ======================== > > In its simplest form, the LED class just allows control of LEDs from > userspace. LEDs appear in /sys/class/leds/. The maximum brightness of the > LED is defined in max_brightness file. The brightness file will set the brightness > of the LED (taking a value 0-max_brightness). Most LEDs don't have hardware > brightness support so will just be turned on for non-zero brightness settings. The existing code assumed that max_brightness always held a value of 255 and defined a constant for it. Instead, use a class variable to cache the max brightness for the associated LED. Change-Id: I2d8f46de0cddac5f9d8ff5444449518bb4056130 Signed-off-by: Andrew Jeffery

physical: Avoid unreachable statement in driveLED()

2019-04-08T04:18:50+00:00

This also slightly improves the branch coverage statistics Change-Id: I27d5168994831789a8f8dafeecc843242a7e406a Signed-off-by: Andrew Jeffery

physical: Cleanup unnecessary variables

2019-04-08T04:18:50+00:00

Change-Id: Ib5897e4f7226993c2deb1feb6e2e39d5a0f0cb5a Signed-off-by: Andrew Jeffery

physical: Rework commentary for brevity

2019-04-08T04:18:50+00:00

Change-Id: I84341c6418853ad7fb44aa6f02ab298cc70842f6 Signed-off-by: Andrew Jeffery

physical: 'frequency' is really periodicity

2019-04-08T04:18:50+00:00

Change-Id: I1007d2a7104fa07351c89c52a860cde83b2d509c Signed-off-by: Andrew Jeffery

test: physical: Capture state(Action::{On,Off}) parameters

2019-04-08T04:18:50+00:00

Implement value sensing to verify the behaviour of the On and Off actions. This constrains future on/off changes to interacting with sysfs in the same manner. Change-Id: Ie0ac063cbda3156ca7f0ef2eab9e700013780e44 Signed-off-by: Andrew Jeffery

test: physical: Capture Action::Blink parameters

2019-04-08T04:18:50+00:00

Implement value sensing to verify behaviour of the blink action. This constrains future blink changes to interacting with sysfs in the same manner. Change-Id: I7ed0a5d52e8dc99192e7938760ce99f618b9cb16 Signed-off-by: Andrew Jeffery

test: physical: Hit both branches of stableStateOperation()

2019-04-08T04:18:50+00:00

Change-Id: Ic32d87dbe996a03e811e1be88fbcc00bf450e1f3 Signed-off-by: Andrew Jeffery

test: physical: Cover trigger:none, brigtness:asserted branch

2019-04-08T04:18:50+00:00

The test causes execution to take the following path in setInitialState(), previously outlined in 264d909d3dc9 ("test: Add tests for Physical class") as being missed: auto brightness = led.getBrightness(); if (brightness == ASSERT) { // LED is in Solid ON sdbusplus::xyz::openbmc_project::Led::server ::Physical::state( Action::On); } This brings the line coverage to 97.6% (function coverage remains unchanged by this patch). Change-Id: I7a04fcd97819559575e69d267c62f16195495010 Signed-off-by: Andrew Jeffery

test: physical: Cover trigger:timer branch in setInitialState()

2019-04-08T04:18:50+00:00

The test causes execution to take the following path in setInitialState(), previously outlined in 264d909d3dc9 ("test: Add tests for Physical class") as being missed: auto trigger = led.getTrigger(); if (trigger == "timer") { // LED is blinking. Get the delay_on and delay_off and compute // DutyCycle. sfsfs values are in strings. Need to convert 'em over to // integer. auto delayOn = led.getDelayOn(); auto delayOff = led.getDelayOff(); // Calculate frequency and then percentage ON frequency = delayOn + delayOff; auto factor = frequency / 100; auto dutyOn = delayOn / factor; // Update. this->dutyOn(dutyOn); } This brings the line coverage to 96.6% (function coverage remains unchanged by this patch). Change-Id: Ie311186f6275d3fdd31de5698c7c14bb335128e1 Signed-off-by: Andrew Jeffery