phosphor-ipmi-blobs, branch master

Various cleanups

2019-11-25T19:02:00+00:00

* Move functions to private as appropriate * Reorder functions to match declaration order * Declare arguments as const when appropriate * Rename to getActionHandler() to match previous method name Signed-off-by: Kun Yi Change-Id: I7d3b5bbb07c218c6c2d6277a1f19d8a0299bd6e6

cleanup: remove getPath

2019-11-25T18:18:55+00:00

The getPath call is only used once. Getting rid of it makes it easier to understand. Signed-off-by: Kun Yi Change-Id: Ifc8859f5fc68bb594003a6db7f7e80b1c1dfed28

Fix openFiles refcount

2019-11-25T18:06:06+00:00

The old code deletes session from the session map before doing a lookup of the path. Fix the order and add a unit test to catch the error case. (The unit test would fail without this fix). Signed-off-by: Kun Yi Change-Id: If043d6aad7bbaafa19ae3b63a6d9cc7a836d25b5

cleanup: Use scoped initializers; move implementation to source file

2019-11-21T18:06:48+00:00

Simplify code and address comments from http://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-blobs/+/27399: * Use C++17 syntax of intializers in conditionals to simplify code. * Move getActionHandle() implementation to .cpp * return false explicitly Tested: Unit tests still pass. Signed-off-by: Kun Yi Change-Id: I08a78125206f284d8c748822912e11828fb39968

cleanup: Operate on members directly and allow empty paths in the lookup table

2019-11-21T18:06:48+00:00

Instead of using private methods to change data, directly operate on it. Currently no test depends on these methods. There is also a minor bug fix: the previous code will not increment or decrement the open session count if the blobId is an empty string, however there is no check on the manager side. If empty blobIds are disallowed they should be checked earlier. Signed-off-by: Kun Yi Change-Id: I8d97e098bed2d5c27a204a86ed688d0d9a98f0a2

test: Add unit tests for session expiration

2019-11-21T18:06:48+00:00

Add simple tests to ensure the session expire method is called when the timeout is set to zero. Signed-off-by: Kun Yi Change-Id: Ic6e973ede760a6a6f15726d5b6c93a892d858c8b

Implement session expiration

2019-11-19T21:50:55+00:00

If the caller opens sessions but doesn't close them, either intentionally or unintentionally, session IDs will leak. Once the maximum number of sessions are reached, no new session can be opened. Implement a cleanup procedure to automatically remove stale sessions. If a session hasn't seen activity for a while, call the expire() functions on the handler, and remove the session from tracking table. For handlers that haven't implemented the expire() call this change will be a no-op. Signed-off-by: Kun Yi Change-Id: I895ae19b4003d2d6f7a0b2e73370fe5aa664adee

Store the last action time in session info

2019-11-19T21:50:11+00:00

Add a timestamp member in SessionStat to capture when the session sees activity last, and update it with every action. The timestamp will be used to check when the session should expire. Signed-off-by: Kun Yi Change-Id: Ic781d54173099bff76b3c37dd296521680fe7986

Refactor various methods to get session or blob handler

2019-11-19T21:47:45+00:00

Use a single method to fetch the handler, if it can be found using session ID. Signed-off-by: Kun Yi Change-Id: I648cbc48ebfae479f63d34e8f2465d2c8cbe9d64

blobs: s/struct BlobMeta/BlobMeta/g

2019-06-17T18:51:19+00:00

Because this structure is not anything special, simply use the cpp idiomatic way of referencing the object. Consistently, structures that are packed still have "struct" used in declarations. However, this distinction is only clear through its usage and nothing in the language. Perhaps a better approach would be notational naming struct PackedXYZ {};. However, that can get out of control quickly. Signed-off-by: Patrick Venture Change-Id: I3b7e48e4b6687ef2e15e9d07c0eeba96eb5d2552