From 5fb14603817baad7418b627ca41927d9ec7c4fc9 Mon Sep 17 00:00:00 2001 From: Aditya Saripalli Date: Thu, 9 Nov 2017 14:46:27 +0530 Subject: Reducing IPMI logging footprint -host-ipmid is very noisy in terms of journal logging. A small step towards cleaning that up. -Also converted printfs to phosphor-logging. Partially Resolves openbmc/openbmc#2507 Change-Id: I749c19c18d1cabf6f0216830c8cb0a08ee43d6de Signed-off-by: Aditya Saripalli Signed-off-by: Nagaraju Goruganti --- systemintfcmds.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'systemintfcmds.cpp') diff --git a/systemintfcmds.cpp b/systemintfcmds.cpp index b98ac12..d363233 100644 --- a/systemintfcmds.cpp +++ b/systemintfcmds.cpp @@ -25,8 +25,6 @@ ipmi_ret_t ipmi_app_read_event(ipmi_netfn_t netfn, ipmi_cmd_t cmd, { ipmi_ret_t rc = IPMI_CC_OK; - printf("IPMI APP READ EVENT command received\n"); - struct oem_sel_timestamped oem_sel = {0}; *data_len = sizeof(struct oem_sel_timestamped); @@ -68,8 +66,6 @@ ipmi_ret_t ipmi_app_get_msg_flags(ipmi_netfn_t netfn, ipmi_cmd_t cmd, // Generic return from IPMI commands. ipmi_ret_t rc = IPMI_CC_OK; - printf("IPMI APP GET MSG FLAGS returning with [bit:2] set\n"); - // From IPMI spec V2.0 for Get Message Flags Command : // bit:[1] from LSB : 1b = Event Message Buffer Full. // Return as 0 if Event Message Buffer is not supported, @@ -93,7 +89,9 @@ ipmi_ret_t ipmi_app_set_bmc_global_enables(ipmi_netfn_t netfn, ipmi_cmd_t cmd, *data_len = 0; // Event and message logging enabled by default so return for now +#ifdef __IPMI_DEBUG__ printf("IPMI APP SET BMC GLOBAL ENABLES Ignoring for now\n"); +#endif return rc; } @@ -111,18 +109,14 @@ void register_netfn_app_functions() { // - printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_READ_EVENT); ipmi_register_callback(NETFUN_APP, IPMI_CMD_READ_EVENT, NULL, ipmi_app_read_event, SYSTEM_INTERFACE); // - printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, - IPMI_CMD_SET_BMC_GLOBAL_ENABLES); ipmi_register_callback(NETFUN_APP, IPMI_CMD_SET_BMC_GLOBAL_ENABLES, NULL, ipmi_app_set_bmc_global_enables, SYSTEM_INTERFACE); // - printf("Registering NetFn:[0x%X], Cmd:[0x%X]\n",NETFUN_APP, IPMI_CMD_GET_MSG_FLAGS); ipmi_register_callback(NETFUN_APP, IPMI_CMD_GET_MSG_FLAGS, NULL, ipmi_app_get_msg_flags, SYSTEM_INTERFACE); -- cgit v1.2.1