| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not all users of ipmid want to use the whitelist. Or they want to have
their own that behaves differently. This change makes it so one can
disable the built-in whitelist so that OEMs can substitute their own
custom filtering or use none at all.
To disable the whitelist, pass --disable-ipmi-whitelist to configure.
This can be done in Yocto via a bbappend for phosphor-ipmi-host:
EXTRA_OECONF_append = " --disable-ipmi-whitelist"
Tested: Built with and without the whitelist enabled to ensure that the
whitelist is present when expected to be.
Change-Id: I63f317b6c29ca73cc3296bb2fe38f836004ec35d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some platforms doe not support safe mode in
set/get system boot options commands, add an compile option to disable it.
Using the below command:
./configure --disable-boot-flag-safe-mode-support
Tested:
After adding this compile option, below command fails:
// set safe mode in set system boot options command
ipmitool raw 0 8 5 0x80 0xc
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0x8 rsp=0xcc):
Invalid data field in request
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ie479a0c68a8e9fc79f99c9d4cc10cdd1e6ceb20e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPMI has four commands that accept "OEM Parameters". The existing IPMI
command handlers do not account for these OEM extensions. This commit
adds OEM Parameters support for the Set/Get LAN Configuration
Parameters commands.
Tested:
ipmitool raw 0xc 1 3 0xc0 0 ;; received 0x80 return code
ipmitool raw 0xc 2 3 0 0 ;; received 0x80 return code
Change-Id: I81135b6d3269cec98ffd7754a03201a74c436c11
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default this white list checking is enabled,
we can disable it by using the below command,
./configure --disable-i2c-whitelist-check
Tested:
Without the --disable-i2c-whitelist-check compile option,
the white list checking works as before
"ipmitool i2c bus=2 0x9c 8 0" command will fail with error message:
Unable to perform I2C Master Write-Read
After adding the compile option, there is no such error.
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I91ced8b0dfb1dbf51292a6b3dea6fd5c03bdbde7
|
|
|
|
|
|
|
|
|
|
| |
Add UPDATE_FUNCTIONAL_ON_FAIL and only when defined, read sensor's
OperationalStatus interface for the functional property and throw if the
sensor is not funcitonal.
Bug: openbmc/phosphor-hwmon#10
Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: I1144a6d3f8145bda73f3363664ca48b848a295db
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I8e14cfd3719c7fbef739f2aa01771bc4321ce290
Signed-off-by: Ofer Yehielli <ofery@google.com>
Tested: Enabled the exclude libuserlayer flag in
recipes-phosphor/ipmi/phosphor-ipmi-host_%.bbappend
+EXTRA_OECONF_append_xxx = " --disable-libuserlayer"
+HOSTIPMI_PROVIDER_LIBRARY_remove_xxx = "libusercmds.so"
+NETIPMI_PROVIDER_LIBRARY_remove_xxx = "libusercmds.so"
Clean build and test that userlayer.so doesn't get included in the build
|
|
|
|
|
|
|
|
| |
When building out of tree the default yamls are not found by the code
generator scripts.
Change-Id: I52a651e99b8a2c41c20dc30a7b4f5f01c16e7c5a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sensor/entity/fru/inventory auto-generated cpp code should
depend on the mako template, the generator python, and the yaml
that it is built with. This modifies the autoconf to export the yaml
and the automake to set the dependencies.
Tested-by: modify one of the dependencies and watch it get rebuilt
Change-Id: Iaab9585c202baf4506e0b7e62aa42a3bf2828ae4
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code coverage macros from the archive changed in a backward
incompatible way. This adds a workaround to autodetect either version
and do the right thing.
Tested:
Against the typical, older autotools and the new autotools
2019.01.09 in the CI environment.
Change-Id: I765ec46051c2666874dce51675092aa4da989ec5
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
Now that ipmid handles all the IPMI commands (for all interfaces),
converge to a single provider path.
Change-Id: Iad938d4440f8486741df491c7bfd0fa5f808afeb
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
| |
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: Iaa5325492d937899c06a5aecad9b6d1beaa81897
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding support for Entity Association Record (SDR type - 0x08h)
This patch includes:
1) Entity Association Record yaml file example
2) Entity Assocation Record related script and mako file changes
3) Adding Entity Association Record in get_sdr IPMI command response
From the host, tested that entity association records can be fetched
Change-Id: I9cf598e5d27d2e8c6751bbaae2176e7c976974b1
Tested: Yes
Signed-off-by: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>
|
|
|
|
|
|
|
| |
Check for the json header during configuration.
Change-Id: I704c653e7fd51b756f65a90e541178cf1f19783b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This starts a transition to common ipmid libraries that providers can
link against. It will allow for a cleaner separation between common
ipmid functionality and daemon type specific code. This is needed so we
can resolve all of the symbols in the providers at link time instead of
discovering bad linkage by building and running a full ipmi daemon.
In future commits libraries will be packaged for libipmid and libipmid-host
which provide all of the symbols used by the current set of ipmid
providers.
This is the first step, it just separates and renames the headers.
Legacy symlinks are still kept around for compatability. It also adds
stub libraries so that external users can start linking as intended.
Change-Id: I6bbd7a146362012d26812a7b039d1c4075862cbd
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
The functionality provided by net.hpp and net.cpp has been moved into
the channel_mgmt class.
Change-Id: I4820609f87f27ebe81d9b36f7b8e95a5262985ac
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 54fad6de0541c2f98e9b511f1d30bbcbcd743db6.
This commit is reverted because the mapping of D-Bus object path to
sensor information is still needed. The mapping is needed to serve
the SEL commands which translate D-Bus logging objects to SEL entries.
Change-Id: I2505299671db1f0bd7f116ef0e2ca4a0273eead8
|
|
|
|
|
| |
Change-Id: Ia9815102064d20795a44b8e6a7d8b324c280756c
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
We need to make sure that libuserlayer is installed before libipmi20
tries to install + relink. Otherwise the relink will fail causing the
build to sometimes fail. We can only guarantee this ordering safely by
using automake SUBDIRS since they are guaranteed to be executed in
order.
Change-Id: I6488eecb504f72273e97cfcf336e5bbd816c4137
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
We need to make all of the contents of AS_IF literal so that they are
not re-interpreted by autoconf.
Change-Id: I220fa6254a16d1f59e0400a9fb1ca909a9e7befb
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The pam_misc was deliberately included by the
Makefile_am, however, no calls into pam_ were made
from libuserlayer. Pam calls were made from
usercommand.cpp, in libipmi20.so. The calls are
part of the primary pam library.
Before:
objdump -t phosphor-host-ipmid/.libs/libipmi20.so\
|grep "UND"|grep -v "@@"|grep "pam"
0000000000000000 *UND* 0000000000000000 pam_end
0000000000000000 *UND* 0000000000000000 pam_chauthtok
0000000000000000 *UND* 0000000000000000 pam_start
Now:
objdump -t ./.libs/libipmi20.so|grep "UND"|grep pam
0000000000000000 F *UND* 0000000000000000 pam_chauthtok@@LIBPAM_1.0
0000000000000000 F *UND* 0000000000000000 pam_end@@LIBPAM_1.0
0000000000000000 F *UND* 0000000000000000 pam_start@@LIBPAM_1.0
Tested: Searched objects for undefined pam calls
and found the information above.
Change-Id: I44aa570a2087affafba09886fbf17fa9d99abe05
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Per TODO in Makefile.am, move the definition of HOST_IPMI_LIB_PATH from
the Makefile to the configure script.
Change-Id: If39bf1193f4502c239a78e21487566b234b746f8
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Exposes user layer library which will be used by both
apphandler and netipmid for RAKP. Password is decrypted
from the special file which is used by pam-ipmi.
Change-Id: Ia6b99d4359a03843f19cd0e18f7269ad2e3cdb44
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
|
|
|
|
|
|
|
|
| |
Tested:
Builds and passes unit tests
Change-Id: I6c37fa7088b7bcfbfc9f8b93185b826782a72c6a
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
| |
Set the language in the build to C++.
Change-Id: Ib1d19c2c05676d7f4bc2095c8492560e8c77f068
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the AX_CXX_COMPILE_STDCXX() instead of
AX_CXX_COMPILE_STDCXX_1{4,7}() so that the error messages we generate
make slightly more sense.
We get errors like:
configure.ac:24: error: invalid first argument `20' to
AX_CXX_COMPILE_STDCXX
Instead of:
./configure: line 5132: syntax error near unexpected token `noext'
./configure: line 5132: `AX_CXX_COMPILE_STDCXX_20(noext)'
Change-Id: I05512c977b8b3215a02b5d4dc6dba30ac2b83728
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
| |
The second check is entirely unnecessary.
Change-Id: I465577c50c0b9476a368373dae1b066b3a758a9e
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
| |
The common timer class from sdbusplus offers all the timer goodness that
we currently use. The unit test is also no longer needed (and has been
added to sdbusplus's version of the timer.hpp implementation).
Change-Id: I278817489433a29ca739f70fdacd8bb897797d66
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
| |
As the project moves forward, we are updating it to use c++17 and some
of the features that it offers, as well as some more boost bits. This
patch makes sure that all the boost libraries are header only, adds in
c++17, and makes sure that the libraries required are linked properly.
Change-Id: I9a25ec971e4bf05c2c3b73e20938cf337e06077c
Signed-off-by: Vernon Mauery <vernon.mauery@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OemRouter adds a facility to register OEM Group Message handlers,
then dispatch matching messages to the registered handler.
Added as a core source so that any dynamic provider can register its
messages without requiring any specific load order.
Includes code fixes for x86 portability.
Change-Id: I47b8fe7873e3c7fdf35a00d3c8a7e17d30c398c4
Signed-off-by: Peter Hanson <peterh@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
| |
Change-Id: I940aadefdf0f78182aad1d4e586e3178e2d2fe97
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
|
|
|
|
|
|
|
|
|
| |
1) Parse the power_reading JSON configuration file to get
the D-Bus object path for the power reading.
2) Read the power reading value from the specified D-Bus object.
Change-Id: I4b9f0703318e8db2c86d0b337e524eee6da33d08
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenBMC is dealing with some performance issues right after
a reboot. Systemd does almost too good a job at parallelizing
all of the services which causes a 6X hit on the processor
during the initial boot once mapper is ready.
In situations where the BMC is rebooted when the host is up,
this performance issue coupled with errors queued up by the
host to send down to the BMC, can cause OpenBMC to exceed
its current 3 second timeout for attentions.
This initial message from OpenBMC to the host is done to
check if the host is running. If the message times out then
it's assumed the host is not running which causes all sorts
of issues for the system.
Testing has shown it can take up to 10 seconds for the
path to complete. Given the uncertainty of future performance,
the unknowns on how many errors the host may have queued up,
and the minimal impact a larger timeout has, this commit is
increasing the timeout to 30 seconds.
Resolves openbmc/openbmc#2832
Change-Id: I0d1baf601b6441a149e786e1f5de607862d86a52
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
| |
Handles converting a yaml file mapping IPMI
channel to ethernet device and using this instead of
a hard-coded map.
Change-Id: Iedfe7cb52a2d0663b9c8a0f6f9d37fe733b63a58
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A fully loaded system can cause the OS to take up
to 45 minutes to properly shut down
Removed "quiesce" from the description of the timeout
since that is used elsewhere for error paths
Resolves openbmc/openbmc#2162
Change-Id: I3800ca8e3bb063be6e5d396fac066014dcce7577
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Since OpenPower Host IPMI OEM also needs to use the Host
Command manager, need to place the files in appropriate
directories and make needed changes.
Change-Id: I7536a0ff1e53a844ec05f73c4e0605cbf4341465
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
| |
Change-Id: Icefce510a3a0022bf0288fa99518459b732a2e04
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Add API to retrieve and cache settings objects of interest.
Change-Id: I8afd58b5b3e9a691e4d3fa6bfba2ba5c92cd2568
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I06dd388ff6060319a21f16ee58a1bcc7379c98a6
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check the DBUS logging entry for callout associations, if there
is a mapping between the inventory path and sensor number then
populate the SEL record. Otherwise log a SEL against the sytem
event sensor.
Resolves openbmc/openbmc#1516
Change-Id: I516bdac70cf39260af1744a9cdb118d763009bd5
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Reusing frup.hpp, example.yaml, fru-gen.py, writefru.mako.cpp from
ipmi-fru-gen repository to generate map of frup properties.
Generated map facilitates in reading data from the inventory.
Change-Id: I6d6dbc55a340dd06b4639f8bded8cc09df815a59
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#1823
Change-Id: I00fbf03561046be34fa8f1bd3039fbffe575737f
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Create a file to ensure the soft power off service is
not run when the host is requesting a power off
or reboot. There's no need to notify the host (i.e.
soft power off) when they are initiating it.
Change-Id: Ic9f8e7110d30f477ceae38bba9d684559d9503d3
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Provide capability for the recipe to pass the config yaml as a
configurable output. Fallback to inventory-sensor-example.yaml
in case no config yaml is passed.
Change-Id: I6a069b0925c3e4c4d56bd1c9767b8fadcdf433b4
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
| |
This sets up the framework for future commits to implement
the required interfaces and signals in Control.Host
Change-Id: I43cd7d3047ed9cfbf1a01e7ba3a0310e9d47c307
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
|
|
|
|
|
|
|
| |
Fixes openbmc/phosphor-host-ipmid#102
Change-Id: I3e7456401b7265a51578f9aa08bef2ae3f326849
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
| |
Change-Id: I6db746adc969a322f463c00143938c7c2339ff86
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
| |
Change-Id: Ia923eff57f855dc88cb04db13590ae1a58a502fd
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
| |
Change-Id: I738be7b70554125e544aa59fe1770e909d3dffb1
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
| |
This commit puts a skeleton layout for the IPMI Soft Power Off
functionality.
Change-Id: I7c3ededc9d4038e172d7f6230270ecfe397330e9
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Make it possible for the phosphor-host-ipmid recipe to be able to
supply the sensor YAML as configurable input.
Use sensor-example.yaml as input.
Change-Id: Iefbfeeff5561e6e90543fc7a69c04aeee5e76dd1
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|