summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* sensorhandler: allow preconfigured unit and scaleEmily Shaffer2017-12-103-22/+46
| | | | | | | | | | | Allow specifying the scale and unit for a sensor in the YAML configuration. This can save clock time by no longer requiring the daemon to reach out to the sensor owner for the information. Change-Id: I5f63286fc32fb9d64ebab7d86d1dbb7ff40591f4 Signed-off-by: Emily Shaffer <emilyshaffer@google.com> Signed-off-by: Patrick Venture <venture@google.com>
* ipmisensor.cpp: Fix msg from "Undetermine" to "Undetermined"Adriana Kobylak2017-12-051-1/+1
| | | | | Change-Id: If647149928f9bafb0e0c2cfa33485b3f46328733 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
* IPMI device ID command mismatch with BMC current side issue fix.Dinesh Chinari2017-12-051-32/+66
| | | | | | | | | | Revisited convert_version sub routine. It should now work for also v1.x.y strings, e.g: ibm-v1.99.10-113-g65edf7d-r3-0-g9e4f715. Resolves: openbmc/openbmc#1480 Signed-off-by: Dinesh Chinari <chinari@us.ibm.com> Change-Id: I5acf028a907af8a1a3bbecd6709bcbac45c877e1
* sensor: Modify the service lookup for set sensor commandTom Joseph2017-12-041-6/+4
| | | | | | | | | | | With the current implementation of the generated code for the sensors, the object path corresponding to the sensor is present. But lookup was done again for the object path which was unnecessary. The current change would would only lookup the service implementing the object path and the interface corresponding to the sensor. Change-Id: I185bc49f6387428d62ab0e5cb8326497837aa67f Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* Document OpenBMC OEM Extension NumberingPeter Hanson2017-11-301-0/+172
| | | | | | | | Includes table of OpenBMC OEM Extension command codes, and describes message layout of I2C extension. Change-Id: Idafce7959348fca1e072c0bad09b58bf6c6931ab Signed-off-by: Peter Hanson <peterh@google.com>
* Fix the getLan configRatan Gupta2017-11-284-32/+36
| | | | | | | | | | | | | | | We did the filtering during IPAddress parameter to avoid link local address but left it for subnetMask and vlan parameter. With the introduction of zeroconfig IP we have multiIPaddress can exist on the interface. This commit introduces the filtering for subnetmask and vlan parameter also. Resolves openbmc/openbmc#2664 Change-Id: I244bfe8b9d7efbf55fc1b7051489a8a204182906 Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
* transporthandler: lan_set_in_progress to per channelPatrick Venture2017-11-222-23/+22
| | | | | | | | | The IPMI specification indicates that this value is per channel, therefore goes in the channelconfig object. Change-Id: Iab5861651518ac80d797faa9d9f092933cc1886e Signed-off-by: Patrick Venture <venture@google.com>
* transporthandler: minor cleanup unused variablesPatrick Venture2017-11-141-6/+0
| | | | | | | | | Simple cleanup to remove obj, ifc, and nwinterface varibles likely holdovers from before the refactor to using util methods. Change-Id: Icf55cdcbe8cb75a08d1d32df4f23112b142bf55b Signed-off-by: Patrick Venture <venture@google.com>
* watchdog: cleanup style and similar fixesPatrick Venture2017-11-102-25/+40
| | | | | | | Some style cleanup. Change-Id: I4f8ce595294797cc015a55cc6c9477aee7b6938a Signed-off-by: Patrick Venture <venture@google.com>
* Commit a MaintenanceProcedure log entry on a 0xDE SEL recordTom Joseph2017-11-035-2/+214
| | | | | | | | | | | | In the case of a procedure callout, HB sends a eSEL of 0xDF type. It is followed by a Add SEL record with OEM record type 0xDE and byte 11 in the record indicate the procedure associated with the eSEL. Resolves openbmc/openbmc#2368 Change-Id: Ia57f423c9d533cd8968b613d7522b409a9820198 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* Fixed the duplicated event string in error messageMarri Devender Rao2017-11-033-15/+6
| | | | | | | | | | The message for the host event was org.open_power.Host.Event.Error.Event, it is corrected to org.open_power.Host.Error.Event. Resolves openbmc/openbmc#1960 Change-Id: I86304b1f2e4bec740e2e9ec58f98ea9df0d752ea Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
* Spelling fixesGunnar Mills2017-10-3111-12/+12
| | | | | | | | | Spelling errors found using github.com/lucasdemarchi/codespell A tool to fix common misspellings. This tool is licensed under GNU General Public License, version 2. Change-Id: I78e9d126f19fd9fb2e3f2fa9fe8c2404dc505f82 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* apphandler: channel: split out commandsPatrick Venture2017-10-265-415/+490
| | | | | | | | | | | | | | I split out the channel commands into their own subordinate file from the apphandler.cpp. There are three commands in apphandler for the channel information. There are other commands in the transporthandler that correlate. Moving this is step one in a larger task to enable multiple channels. Change-Id: I2e434a1da942325fc420079415edb39622f4e346 Signed-off-by: Patrick Venture <venture@google.com>
* watchdog: split out commandsPatrick Venture2017-10-254-169/+208
| | | | | | | | | | I split out the watchdog command handlers into their own subordinate file from the apphandler. This reduces the size of the contents of the apphandler file, and logically cuts out code into its own files. Change-Id: Idc70acad6c93c12456cc7092786715643c9c1ffb Signed-off-by: Patrick Venture <venture@google.com>
* Add IBM OEM NetFn(0x3A)Tom Joseph2017-10-251-1/+2
| | | | | Change-Id: If6c4b2c031981f0dba70799dc8cb42840def2dd2 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* Update Journal Variable Names in utils.cppGunnar Mills2017-10-191-8/+8
| | | | | | | | | Journal entry variable names should be uppercase. https://www.freedesktop.org/software/systemd/man/sd_journal_print.html Also fixed indentation. Change-Id: I02d30971123c2bb526f19e00b534e06fbcd9ee59 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update Journal Variable NamesGunnar Mills2017-10-193-6/+9
| | | | | | | | | Journal entry variable names should be uppercase. https://www.freedesktop.org/software/systemd/man/sd_journal_print.html Also, fixed indentation. Change-Id: I2c838332ab7811ccc9a2c99f5b1f558c48f25f76 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* storagehandler: Use new phosphor-timemanager interfaceLei YU2017-10-191-89/+84
| | | | | | | | Update SEL-Time handlers to use sdbusplus and new phosphor-timemanager interface. Change-Id: Ib931a6bedc14037fc1a0a7c25698f67272520bb5 Signed-off-by: Lei YU <mine260309@gmail.com>
* storagehandler: sort include filesLei YU2017-10-171-11/+14
| | | | | Change-Id: Iaf49ed787a2e077af27f28d22507456e8efa2b41 Signed-off-by: Lei YU <mine260309@gmail.com>
* Add DCMI Get/Set Management Controller Id StringVladislav Vovchenko2017-10-162-1/+187
| | | | | | | Resolves openbmc/openbmc#1855 Change-Id: I878c7bcb1ea8b46cd3e932b1cbb2290fe612f652 Signed-off-by: Vladislav Vovchenko <vlad.vovchenko93@gmail.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
* Don't set/get zeroconfig address if other IP address is presentNagaraju Goruganti2017-10-114-14/+82
| | | | | | | Resolves openbmc/openbmc#2265 Change-Id: I65b54358f13231c78b3c6488a59b94bc9323484c Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
* IPMI changes to mark non present as non functionalDhruvaraj Subhashchandran2017-10-114-33/+103
| | | | | | | | | When marking a unit as functional, both functional state and presence need to be checked to avoid marking non-present units as functional. Change-Id: If7b710c39f1c2590b82378ebdb7014dc924599ff Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
* IPMI changes to skip updating non present coresDhruvaraj Subhashchandran2017-10-114-6/+65
| | | | | | | | | Cores which are not present need not to be updated to inventory. This change is for skipping several updates to inventory based on skipOn value. Change-Id: I29e005a715ccae1df6eeaf35561a20896ecde0ac Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
* Revert "Remove legacy reading of PS derating"Dhruvaraj Subhashchandran2017-10-041-0/+1
| | | | | | | This reverts commit 1bf3b749e9217f03fbc55bbb45802df9e715e3b0. Change-Id: Ib364199f4d676c2003450cad4b4d3d6077356fc1 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
* boot policy: Support boot parameter #4 (boot info)Tom Joseph2017-10-042-2/+10
| | | | | | | Resolves openbmc/openbmc#2356 Change-Id: If775a01a97f29a60575c03f26d32bba0315af920 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* Handle std::runtime_error exception in get sensor readingTom Joseph2017-10-031-0/+9
| | | | | | | Resolves openbmc/openbmc#2374 Change-Id: I596b5f0662b2506c8af4143ffa6438320d7bf4a2 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* boot policy: Correct the logic of setting the boot policyTom Joseph2017-09-281-53/+34
| | | | | | | Resolves openbmc/openbmc#2355 Change-Id: Ic7b0efb35887c987a1626e5d88f8a9513d22004f Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* Use static path for inventory managerDhruvaraj Subhashchandran2017-09-261-5/+2
| | | | | | | | | | | During boot after sending the inventory details host is asking for the a sensor value, that request is getting blocked because the ipmid on BMC is busy with processing the inventory data. Adding an optimization in processing inventory, which will reduce the wait. Change-Id: I490c98220e0244fb6c766432aa1ea8cf25ae1502 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
* Remove legacy reading of PS deratingDhruvaraj Subhashchandran2017-09-251-1/+0
| | | | | | | Resolves openbmc/openbmc#2154 Change-Id: Ia5e150951fd077eddb4ee5a11d361eceee404e44 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
* typofix: s/impelmented/implemented/gPatrick Venture2017-09-211-2/+2
| | | | | | | Just noticed in my systemd journal. Change-Id: I0f958750cd5936079e41e819956d079baec26875 Signed-off-by: Patrick Venture <venture@google.com>
* Move error msg for trying wildcard into debug onlyPatrick Venture2017-09-201-0/+3
| | | | | | | | | | My logs are effectively full of this message, hiding out other useful messages because we run a lot of OEM traffic. Also, until the daemon fails to find the command via wildcard, it's not really an error worth reporting in most cases. Change-Id: Id6674f3e9a2f237de6bd37d6c9f89931a99d0951 Signed-off-by: Patrick Venture <venture@google.com>
* sensor: Pass the dbus property type as a template parameterTom Joseph2017-09-141-64/+7
| | | | | | | | | | | | readingAssertion and reading type of sensors, take the dbus property type as template parameters. Instead of generating code to handle that, the function parameter is updated with the template parameter. Resolves openbmc/openbmc#2220 Change-Id: Ib9e15727ba96e3a53c46f17bffc9ef68dbf73194 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Correct the offset field in reading calculationTom Joseph2017-09-141-2/+2
| | | | | Change-Id: If85dd3d6705ccc86a8e3406ef5f90fcc6e2967d1 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Use getFunc for TPM and RebootAttempt sensorTom Joseph2017-09-141-71/+0
| | | | | Change-Id: I8d7581e2c14344425683870daf395fc895d1034c Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Use getFunc to handle the get sensor readingTom Joseph2017-09-141-3/+22
| | | | | Change-Id: If0f3185e7ce1d300be20b58ee5004a58e35c222d Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Handle the response of find_openbmc_pathTom Joseph2017-09-141-9/+12
| | | | | | | | | | | The sensor path of the inventory items does not include the inventory root, so would fail in the case of find_openbmc_path. If the return code of find_openbmc_path indicates failure, then it is logged and allowed to continue. The call to find_openbmc_path would be eventually removed. Change-Id: I7513bf4ab9b897ff5b64cfb77fd504e6ef4e227a Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Modify mako template to generate sensor getter funcTom Joseph2017-09-142-1/+29
| | | | | Change-Id: If198d9a9fb1145bbaeda528e3f80356527b80059 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Map dbus info to sensor's reading fieldTom Joseph2017-09-142-0/+47
| | | | | Change-Id: I3e35bf78260b1fa29e992b00279f2dd166cd2fe1 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Add function to support sensor with readingAssertion typeTom Joseph2017-09-142-0/+48
| | | | | | | | readingAssertion is special type where the entire assert bitfield serves as the value or reading. Change-Id: Iaddbe846e04d2a53cff69d71670a96ccc66636a8 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Add function to map dbus info to reading fieldTom Joseph2017-09-143-0/+57
| | | | | | | | | For sensor's with reading type eventData2, the eventdata2 field is mapped to the reading field in the get sensor reading command response. Change-Id: I9ad85ddb48d6c273a22e476e29ea9bbb34c13e24 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensor: Add function to map dbus info to assertion statusTom Joseph2017-09-145-22/+195
| | | | | Change-Id: I30aae9abd7905ae3299856d798d41e10859fed7f Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
* sensorhandler: support setting analog sensorsEmily Shaffer2017-09-135-62/+196
| | | | | | | | | | | | | | | | | | Refactor YAML format to denote mutability of sensors. Sensors which expect different formats for reads and writes should present two entries in the sensor YAML, one with the read interface and one with the write interface. Sensors which share a format for both reads and writes may present only one entry in the YAML with both readable and writable enums specified. If a sensor receives a write which has an interface of Sensor.Value, the "Set" message is sent via DBus to the path provided in the YAML. The previous codepath is maintained. Change-Id: I292f95b6fe936de759fd65ce72c842a1bfe66448 Signed-off-by: Emily Shaffer <emilyshaffer@google.com> Signed-off-by: Patrick Venture <venture@google.com>
* Modify mako script to generate code for empty interfacesMarri Devender Rao2017-09-132-5/+12
| | | | | | | | Allow generating empty interfaces in the FRU map, which are used to determine the type of the inventory object. Change-Id: I6dc97514b0bdf7ef9d3a63ee6790a7933b3e7cd9 Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
* Independently set the watchdog Interval when setPatrick Venture2017-09-121-6/+6
| | | | | | | | When we receive a set watchdog command, this will now set the Interval value directly. Change-Id: I34b82507cbad95f2ad56932d03a48a80b2dfc11d Signed-off-by: Patrick Venture <venture@google.com>
* Refactor reading and parsing of inventory dataMarri Devender Rao2017-09-081-24/+24
| | | | | | | | Refactored to use 'GetAll' dbus method call over multiple 'Get' dbus method calls to read the properties of a inventory object. Change-Id: I0ddc2150830961666fafa661cf29042f66137977 Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
* boot settings: use the new 'one time' settingDeepak Kodihalli2017-09-083-117/+247
| | | | | | | Resolves openbmc/openbmc#2008. Change-Id: Id79d1f61a3e627fef28b071e2a415e94de14634f Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
* settings: handle multiple objects/interfacesDeepak Kodihalli2017-09-084-14/+22
| | | | | | | | | Handle the fact that a settings object can now implement multiple interfaces, and also the fact that multiple settings objects can implement the same interface. Change-Id: Icf55b08fe2d355a10f7007489dfddb128e05d90e Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
* SetLan: Make changes in set channel access to support ipsrc paramRatan Gupta2017-09-081-88/+215
| | | | | | | Resolves openbmc/openbmc#2138 Change-Id: I4b4b8e915bcfea6ed5f913ede5f714290483e4f9 Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
* GetLan: Support for get/set of ipsrc parameterRatan Gupta2017-09-085-59/+265
| | | | | Change-Id: Id9c52bb0963c5924f80f9e273b53ed5556b16a2c Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
* Support Power Supply derating sensorTom Joseph2017-09-071-5/+4
| | | | | Change-Id: I893d09a4ecb88507386e8b89015c4b53b18951c3 Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
OpenPOWER on IntegriCloud