diff options
author | Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> | 2018-12-03 15:08:59 +0530 |
---|---|---|
committer | Vernon Mauery <vernon.mauery@linux.intel.com> | 2018-12-11 14:29:30 +0000 |
commit | a45cb34ff6e6c778e2d2b86518afb8bc0a54d189 (patch) | |
tree | 605604911d40cc575c6be9fa927e6922de1e571c /user_channel/user_mgmt.cpp | |
parent | ae4b040bd08839efcbc08a78d4f6ce6d77e66050 (diff) | |
download | phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.tar.gz phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.zip |
Update const uint8_t& to const uint8_t
Update const uint8_t& to const uint8_t usage. Passing by reference
for small types are costly than passing it by value and hence the
change is done
Unit-Test
1. Performed build and verified regular user account creation
and RMCP+ login
Change-Id: Ic2dd76795749148f82564677dde2a5db08520454
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Diffstat (limited to 'user_channel/user_mgmt.cpp')
-rw-r--r-- | user_channel/user_mgmt.cpp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/user_channel/user_mgmt.cpp b/user_channel/user_mgmt.cpp index af72540..8ba4a94 100644 --- a/user_channel/user_mgmt.cpp +++ b/user_channel/user_mgmt.cpp @@ -508,13 +508,13 @@ UserAccess::UserAccess() : bus(ipmid_get_sd_bus_connection()) } } -UserInfo* UserAccess::getUserInfo(const uint8_t& userId) +UserInfo* UserAccess::getUserInfo(const uint8_t userId) { checkAndReloadUserData(); return &usersTbl.user[userId]; } -void UserAccess::setUserInfo(const uint8_t& userId, UserInfo* userInfo) +void UserAccess::setUserInfo(const uint8_t userId, UserInfo* userInfo) { checkAndReloadUserData(); std::copy(reinterpret_cast<uint8_t*>(userInfo), @@ -523,17 +523,17 @@ void UserAccess::setUserInfo(const uint8_t& userId, UserInfo* userInfo) writeUserData(); } -bool UserAccess::isValidChannel(const uint8_t& chNum) +bool UserAccess::isValidChannel(const uint8_t chNum) { return (chNum < ipmiMaxChannels); } -bool UserAccess::isValidUserId(const uint8_t& userId) +bool UserAccess::isValidUserId(const uint8_t userId) { return ((userId <= ipmiMaxUsers) && (userId != reservedUserId)); } -bool UserAccess::isValidPrivilege(const uint8_t& priv) +bool UserAccess::isValidPrivilege(const uint8_t priv) { return ((priv >= PRIVILEGE_CALLBACK && priv <= PRIVILEGE_OEM) || priv == privNoAccess); @@ -633,7 +633,7 @@ bool UserAccess::isValidUserName(const char* userNameInChar) return true; } -ipmi_ret_t UserAccess::setUserEnabledState(const uint8_t& userId, +ipmi_ret_t UserAccess::setUserEnabledState(const uint8_t userId, const bool& enabledState) { if (!isValidUserId(userId)) @@ -660,8 +660,8 @@ ipmi_ret_t UserAccess::setUserEnabledState(const uint8_t& userId, return IPMI_CC_OK; } -ipmi_ret_t UserAccess::setUserPrivilegeAccess(const uint8_t& userId, - const uint8_t& chNum, +ipmi_ret_t UserAccess::setUserPrivilegeAccess(const uint8_t userId, + const uint8_t chNum, const UserPrivAccess& privAccess, const bool& otherPrivUpdates) { @@ -747,7 +747,7 @@ uint8_t UserAccess::getUserId(const std::string& userName) return usrIndex; } -ipmi_ret_t UserAccess::getUserName(const uint8_t& userId, std::string& userName) +ipmi_ret_t UserAccess::getUserName(const uint8_t userId, std::string& userName) { if (!isValidUserId(userId)) { @@ -759,7 +759,7 @@ ipmi_ret_t UserAccess::getUserName(const uint8_t& userId, std::string& userName) return IPMI_CC_OK; } -ipmi_ret_t UserAccess::setUserName(const uint8_t& userId, +ipmi_ret_t UserAccess::setUserName(const uint8_t userId, const char* userNameInChar) { if (!isValidUserId(userId)) |