diff options
author | Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> | 2018-12-03 15:08:59 +0530 |
---|---|---|
committer | Vernon Mauery <vernon.mauery@linux.intel.com> | 2018-12-11 14:29:30 +0000 |
commit | a45cb34ff6e6c778e2d2b86518afb8bc0a54d189 (patch) | |
tree | 605604911d40cc575c6be9fa927e6922de1e571c /user_channel/channel_mgmt.hpp | |
parent | ae4b040bd08839efcbc08a78d4f6ce6d77e66050 (diff) | |
download | phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.tar.gz phosphor-host-ipmid-a45cb34ff6e6c778e2d2b86518afb8bc0a54d189.zip |
Update const uint8_t& to const uint8_t
Update const uint8_t& to const uint8_t usage. Passing by reference
for small types are costly than passing it by value and hence the
change is done
Unit-Test
1. Performed build and verified regular user account creation
and RMCP+ login
Change-Id: Ic2dd76795749148f82564677dde2a5db08520454
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Diffstat (limited to 'user_channel/channel_mgmt.hpp')
-rw-r--r-- | user_channel/channel_mgmt.hpp | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/user_channel/channel_mgmt.hpp b/user_channel/channel_mgmt.hpp index 5c35041..09d2a71 100644 --- a/user_channel/channel_mgmt.hpp +++ b/user_channel/channel_mgmt.hpp @@ -75,7 +75,7 @@ class ChannelConfig * * @return true if valid, false otherwise */ - bool isValidChannel(const uint8_t& chNum); + bool isValidChannel(const uint8_t chNum); /** @brief determines valid authentication type * @@ -84,7 +84,7 @@ class ChannelConfig * * @return true if valid, false otherwise */ - bool isValidAuthType(const uint8_t& chNum, const EAuthType& authType); + bool isValidAuthType(const uint8_t chNum, const EAuthType& authType); /** @brief determines supported session type of a channel * @@ -92,7 +92,7 @@ class ChannelConfig * * @return EChannelSessSupported - supported session type */ - EChannelSessSupported getChannelSessionSupport(const uint8_t& chNum); + EChannelSessSupported getChannelSessionSupport(const uint8_t chNum); /** @brief determines number of active sessions on a channel * @@ -100,7 +100,7 @@ class ChannelConfig * * @return numer of active sessions */ - int getChannelActiveSessions(const uint8_t& chNum); + int getChannelActiveSessions(const uint8_t chNum); /** @brief provides channel info details * @@ -109,7 +109,7 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t getChannelInfo(const uint8_t& chNum, ChannelInfo& chInfo); + ipmi_ret_t getChannelInfo(const uint8_t chNum, ChannelInfo& chInfo); /** @brief provides channel access data * @@ -118,7 +118,7 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t getChannelAccessData(const uint8_t& chNum, + ipmi_ret_t getChannelAccessData(const uint8_t chNum, ChannelAccess& chAccessData); /** @brief to set channel access data @@ -129,9 +129,9 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t setChannelAccessData(const uint8_t& chNum, + ipmi_ret_t setChannelAccessData(const uint8_t chNum, const ChannelAccess& chAccessData, - const uint8_t& setFlag); + const uint8_t setFlag); /** @brief to get channel access data persistent data * @@ -140,7 +140,7 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t getChannelAccessPersistData(const uint8_t& chNum, + ipmi_ret_t getChannelAccessPersistData(const uint8_t chNum, ChannelAccess& chAccessData); /** @brief to set channel access data persistent data @@ -151,9 +151,9 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t setChannelAccessPersistData(const uint8_t& chNum, + ipmi_ret_t setChannelAccessPersistData(const uint8_t chNum, const ChannelAccess& chAccessData, - const uint8_t& setFlag); + const uint8_t setFlag); /** @brief provides supported authentication type for the channel * @@ -162,7 +162,7 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t getChannelAuthTypeSupported(const uint8_t& chNum, + ipmi_ret_t getChannelAuthTypeSupported(const uint8_t chNum, uint8_t& authTypeSupported); /** @brief provides enabled authentication type for the channel @@ -173,8 +173,8 @@ class ChannelConfig * * @return IPMI_CC_OK for success, others for failure. */ - ipmi_ret_t getChannelEnabledAuthType(const uint8_t& chNum, - const uint8_t& priv, + ipmi_ret_t getChannelEnabledAuthType(const uint8_t chNum, + const uint8_t priv, EAuthType& authType); /** @brief conver to channel privilege from system privilege @@ -203,7 +203,7 @@ class ChannelConfig * * @return 0 for success, -errno for failure. */ - ChannelData* getChannelDataPtr(const uint8_t& chNum); + ChannelData* getChannelDataPtr(const uint8_t chNum); uint32_t signalFlag = 0; @@ -231,7 +231,7 @@ class ChannelConfig * @param[in] chNum - channel number * @param[in] chName - channel name */ - void setDefaultChannelConfig(const uint8_t& chNum, + void setDefaultChannelConfig(const uint8_t chNum, const std::string& chName); /** @brief function to load all channel configuration @@ -335,7 +335,7 @@ class ChannelConfig * * @return access mode in string */ - std::string convertToAccessModeString(const uint8_t& value); + std::string convertToAccessModeString(const uint8_t value); /** @brief function to convert privilege value to string * @@ -343,7 +343,7 @@ class ChannelConfig * * @return privilege in string */ - std::string convertToPrivLimitString(const uint8_t& value); + std::string convertToPrivLimitString(const uint8_t value); /** @brief function to convert session support string to value type * @@ -376,7 +376,7 @@ class ChannelConfig * * @return channel index */ - uint8_t convertToChannelIndexNumber(const uint8_t& chNum); + uint8_t convertToChannelIndexNumber(const uint8_t chNum); /** @brief function to convert channel name to network interface name * |