diff options
| author | Patrick Venture <venture@google.com> | 2018-10-13 13:00:42 -0700 |
|---|---|---|
| committer | Patrick Venture <venture@google.com> | 2018-10-31 01:46:08 +0000 |
| commit | 4491a46fb05d1d9c90fed3452157645b339b9dab (patch) | |
| tree | c1f49a319df811b5f4bfd7b582f1f53186f53b7f /ipmisensor.cpp | |
| parent | 85f9819177505a6930be1443d755eaf2f7cfaf2e (diff) | |
| download | phosphor-host-ipmid-4491a46fb05d1d9c90fed3452157645b339b9dab.tar.gz phosphor-host-ipmid-4491a46fb05d1d9c90fed3452157645b339b9dab.zip | |
cleanup: scope reduction
[app/channel.cpp:102]: (style) The scope of the variable 'resp' can be reduced.
[ipmisensor.cpp:310]: (style) The scope of the variable 'i' can be reduced.
[ipmid.cpp:506]: (style) The scope of the variable 'num_handlers' can be reduced.
[read_fru_data.cpp:82]: (style) The scope of the variable 'fruId' can be reduced.
[sensorhandler.cpp:256]: (style) The scope of the variable 'p' can be reduced.
[storageaddsel.cpp:68]: (style) The scope of the variable 'p' can be reduced.
Also delete two extra vertical lines.
Change-Id: I8e72f8e1d94381f456674abf523d2f2fbdd8046d
Signed-off-by: Patrick Venture <venture@google.com>
Diffstat (limited to 'ipmisensor.cpp')
| -rw-r--r-- | ipmisensor.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/ipmisensor.cpp b/ipmisensor.cpp index 5a629a8..3db1d1b 100644 --- a/ipmisensor.cpp +++ b/ipmisensor.cpp @@ -283,7 +283,6 @@ int findindex(const uint8_t sensor_type, int offset, int* index) bool shouldReport(uint8_t sensorType, int offset, int* index) { - bool rc = false; if (findindex(sensorType, offset, index)) @@ -304,10 +303,9 @@ bool shouldReport(uint8_t sensorType, int offset, int* index) int updateSensorRecordFromSSRAESC(const void* record) { - auto pRec = static_cast<const sensorRES_t*>(record); uint8_t stype; - int index, i = 0; + int index; stype = find_type_for_sensor_number(pRec->sensor_number); @@ -316,7 +314,6 @@ int updateSensorRecordFromSSRAESC(const void* record) // function if (stype == 0xC3) { - shouldReport(stype, 0x00, &index); reportSensorEventAssert(pRec, index); } @@ -324,7 +321,7 @@ int updateSensorRecordFromSSRAESC(const void* record) { // Scroll through each bit position . Determine // if any bit is either asserted or Deasserted. - for (i = 0; i < 8; i++) + for (int i = 0; i < 8; i++) { if ((ISBITSET(pRec->assert_state7_0, i)) && |
