phosphor-host-ipmid/app, branch master

Don't report serviceable action if the watchdog service is not present

2020-01-14T12:12:45+00:00

There were a few cases where a service action was reported because the watchdog service was not present. It was because of a race condition where the power down operation is trigerred and the watchdog service is shutdown but if was followed by a watchdog reset. Since the watchdog service is absent it resulted in an error log which calls for serviceable action. The IPMI error response code will report the failure to the host platform software. Change-Id: Iaf0a860b53fbd85dc451fc4d4a337406ba74e0d6 Signed-off-by: Tom Joseph

app/watchdog: Always use resetTimeRemaining

2020-01-06T23:37:15+00:00

The SetWatchdog function currently sets the intervals and then the time remaining on the watchdog. It uses the user provided interval for both values. Recently, the watchdog was extended to allow for the interval to be capped above a certain value to prevent the user from setting watchdogs that are known to be too short. In order to keep the timeRemaining in sync with the value in the watchdog, just use the resetTimeRemaining() function which reads the current interval to set the timeRemaining. Change-Id: I3f15030a85c625fcb1ed8040add03496618a5ece Signed-off-by: William A. Kennington III

Expiration flags fix for watchdog get/set commands

2019-11-01T14:50:13+00:00

The expiration flags should be retain their state across system resets and power cycles. Tested: Set “BIOS FRB2” and start ipmitool raw 0x06 0x24 0x01 0x00 0x00 0x00 0x30 0x00 ipmitool mc watchdog reset after stopped: Timer Expiration Flags should be : (0x02) * BIOS FRB2 Then Set “BIOS/POST” and start, ipmitool raw 0x06 0x24 0x02 0x00 0x00 0x00 0x30 0x00 ipmitool mc watchdog reset after stopped: Timer Expiration Flags should be : (0x06) * BIOS FRB2 * BIOS/POST “impitool mc watchdog get” displays the correct Timer Expiration Flags when the timer is running; Signed-off-by: Yong Li Change-Id: Ic0c27c6c1e8bed2db8ce30fc0eec2a6538bb1992

channel:Fix get channel ciphersuite - payloadtypes

2019-10-24T18:11:42+00:00

Issue: Get channel CipherSuite command passed with invalid payload type Fix: Added the check now to allow only valid payload types Tested: Command: ipmitool raw 0x06 0x54 0x01 0xff 0x80 Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54 rsp=0x80): Unknown (0x80) Command: ipmitool raw 0x06 0x54 0x01 0x12 0x80 Response: 01 c0 03 01 41 81 c0 11 03 44 81 Command: ipmitool raw 0x06 0x54 0x01 0x09 0x80 Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54 rsp=0x80): Unknown (0x80) Command: ipmitool raw 0x06 0x54 0x01 0x02 0x00 Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54 rsp=0x80): Unknown (0x80) Command: ipmitool raw 0x06 0x54 0x01 0x12 0x00 Response: 01 01 03 41 44 81 Signed-off-by: jayaprakash Mutyala Change-Id: I552250736d7e898191ddbb45fd1bff42681b9c63

Data checking fix for watchdog set/get commands

2019-10-11T15:27:52+00:00

data length check for timeout action and byte 1 reserved field check are missing, causing not to throw the error; Log flags is on bit 7, also needs to right-shift this flag; This commit fixes these issues; Tested: Set different timer use/actions: ipmitool raw 0x06 0x24 0x85 0x0 0x0 0x0 0x64 0x00 ipmitool raw 0x06 0x24 0x84 0x1 0x0 0x0 0x64 0x00 Check the settings are correct: ipmitool raw 0x06 0x25 Signed-off-by: Yong Li Change-Id: Ia4226bb4597d2c670f93522aa763e43d15eb6cf1

transporthandler: Rewrite + New Handler

2019-09-27T17:18:29+00:00

This rewrites the old transport handler to use the new ipmi handler registration functions. It attempts to clean up the old code, by refactoring any business logic out of the code that parses the IPMI messages. This makes the code paths easier to understand and allows for better code re-use. This also gets rid of the concept of the settings change timer. Clients expect to see their settings take effect as soon as they are set, regardless of the "Set In Progress" flag. This means we no longer need a cache for our network settings that are about to be set by the daemon, and a client can hold the BMC in "Set In Progress" while it verifies settings like other BMC implementations. Change-Id: I5406a674f087600afdfc2c0b3adeacde10986abc Signed-off-by: William A. Kennington III

Fix: execute get channel cipher suite in lan chan

2019-09-25T05:36:40+00:00

Get channel cipher suites command was executed for non lan channels. Fixing the same by adding active lan channel support check. Tested: ipmitool raw 0x06 0x54 0x01 0x00 0x80 01 c0 03 01 41 81 c0 11 03 44 81 //cmd executed for lan chan 1 ipmitool raw 0x06 0x54 0x00 0x00 0x80 Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x54 rsp=0xcc): Invalid data field in request //cc resulted for non lan chan 0 Signed-off-by: Ayushi Smriti Change-Id: Ic3c2dfa3f4537be789e2afc912fa8f4c2a49bda4

Fix: refactor get channel cipher suite command

2019-09-25T05:31:25+00:00

Get channel cipher suites command updated as per new ipmi structure. Tested: ipmitool raw 0x06 0x54 0x01 0x00 0x80 01 c0 03 01 41 81 c0 11 03 44 81 //response Also verified by issuing cmd: ipmitool channel getciphers ipmi 0x01 which listed supported CIA algorithms as response Signed-off-by: Ayushi Smriti Change-Id: Ibc942f5b197c72071cd35a138fbe244db7519824

Static code analysis scan issue fix

2019-09-23T17:50:41+00:00

Fix the issues found during code static scan Tested: test in board, function works fine. 1. busctl set-property for watchdog, it works fine. 2. It works by running "ipmitool chassis power soft". 3. run "ipmitool raw 0x6 0x46 1", get expected user information. Change-Id: I7a2cc3c934db6a7531f8a8ea05956cb6d6337633 Signed-off-by: Chen,Yugang

Watchdog: move get and set watchdog to new api.

2019-09-10T23:39:02+00:00

Rewrite "get and set watchdog" command to use the newly introduced ipmi api. Tested: Verified using ipmitool "get and set watchdog", timer behavior is same before and after the changes. Testing Procedure: default watchdog timer is 11.2 seconds. ipmitool raw 0x06 0x25 ---> Get Output: 00 00 00 00 70 17 70 17 Note: Here 70 count(hex value)->112 count(decimal value)->112*100=11200ms [100ms per count]->11.2sec (watchdog timer) watchdog timer set to 20 seconds. ipmitool raw 0x06 0x24 0x44 0x01 0x00 0x10 0xc8 0x00 ----> Set output: ipmitool raw 0x06 0x25 ---> Get output: 04 01 00 00 c8 00 c8 00 Note: Here 20sec->20000ms->200count->c8 (hex value) Signed-off-by: Deepak Kumar Sahu Change-Id: Id8c096bc1635d1900ee842a9726c49fb690fa8bc