phosphor-host-ipmid, branch master

ipmid: allow command not found for filtered commands

2020-02-11T00:26:25+00:00

Filters are executed first and the actual ipmi command handler will not execute if the filter rejects it for any reason. However, if a filter returns a value for a command that is not even implemented, the old logic would return that value instead of command not implemented (C1h). This is incorrect behavior. This fix will run the filter and then check to see if the command is registered. If the command is registered AND the filter has returned some error, only then will the filter error get returned. If the command is registered and the filter returns no error, the command is executed. If the command is not registered, C1h is returned, as per the spec. Tested: 1) Add some bogus command definitions to the whitelist filter 2) Run the bogus command 3) See that C1h is returned, not insufficient privilege Change-Id: I069df8f47a169d6b2961460a561bf9cae6ae285c Signed-off-by: Vernon Mauery

Remove unused oemrouter.cpp

2020-02-10T15:27:58+00:00

The original implementation of the oem routing is not needed anymore. It was rewritten via the legacy oem routing mechanism as part of the ipmi architecture rewrite. Change-Id: I815e5d116cc02092887ce0342d499aff26988aac Signed-off-by: Vernon Mauery

Remove useless wildcard handlers

2020-02-06T21:35:26+00:00

The default action is to return Command Not Found, which is exactly what the wildcard handlers are doing. This just removes that extra code that is not needed. Change-Id: I0a25153395858efcdf56384ececaabc7eaf4e1af Signed-off-by: Vernon Mauery

Make ipmi whitelist optional

2020-02-05T17:03:54+00:00

Not all users of ipmid want to use the whitelist. Or they want to have their own that behaves differently. This change makes it so one can disable the built-in whitelist so that OEMs can substitute their own custom filtering or use none at all. To disable the whitelist, pass --disable-ipmi-whitelist to configure. This can be done in Yocto via a bbappend for phosphor-ipmi-host: EXTRA_OECONF_append = " --disable-ipmi-whitelist" Tested: Built with and without the whitelist enabled to ensure that the whitelist is present when expected to be. Change-Id: I63f317b6c29ca73cc3296bb2fe38f836004ec35d Signed-off-by: Vernon Mauery

Return an error when assigning static values to a DHCP enabled NIC

2020-01-31T15:56:38+00:00

Assigning static IP addresses, subnet masks, and gateway values to a DHCP enabled NIC should be flagged with an error response to indicate the operation was not completed successfully. Tested: Used some raw commands to witness the return code directly -- Enable DHCP for NIC 3 ipmitool lan set 3 ipsrc dhcp -- Assign a static IPv4 Address, expect a failure ipmitool raw 0xc 1 3 3 192 168 20 12 # returns 0xd5 error message -- Assign a static IPv4 Subnet mask, expect a failure ipmitool raw 0xc 1 3 6 255 255 255 0 # returns 0xd5 error message -- Assign a static IPv4 Gateway, expect a failure ipmitool raw 0xc 1 3 12 192 168 20 1 # returns 0xd5 error message -- Enable Static address assignment for NIC 3 ipmitool lan set 3 ipsrc static -- Assign a static IPv4 Address, expect success ipmitool raw 0xc 1 3 3 192 168 20 12 # returns successfully -- Assign a static IPv4 Subnet mask, expect success ipmitool raw 0xc 1 3 6 255 255 255 0 # returns successfully -- Assign a static IPv4 Gateway, expect success ipmitool raw 0xc 1 3 12 192 168 20 1 # returns successfully IPv4 settings have been updated. Change-Id: I807ec45a0c86b33dd46bfeb64724b91d5afad408 Signed-off-by: Johnathan Mantey

MAINTAINERS: remove Emily Shaffer

2020-01-31T15:52:56+00:00

See https://lists.ozlabs.org/pipermail/openbmc/2020-January/020345.html Signed-off-by: Emily Shaffer Change-Id: Idbb3ffeb3041acacbdcdb0ce40e02c9059929fa5

[channel-mgmt]: Handle out of range error in path

2020-01-30T17:30:49+00:00

Function must assume that object path without any network name may be advertised, and must handle the condition accordingly. Tested: 1. Verified that ipmi user is properly enabled with channel based permission and it works fine. Change-Id: Id51f09bb7c19a9750cb06c2c55f7271afc6b1d2a Signed-off-by: Richard Marian Thomaiyar

[user-mgmt]: Handle out of range error in path

2020-01-30T16:33:06+00:00

Function must assume that object path without user name may exist, and must handle the condition accordingly. Tested: 1. Verified when InterfacesAdded signal sent out from Phosphor-user-manager under base user object for global attributes, ipmid is not crashed. Resolves openbmc/phosphor-net-ipmid#10 Change-Id: Ib19af7ca8f05fd9f4553010caf347c677d9897e2 Signed-off-by: Richard Marian Thomaiyar

[channel-mgmt]: Misc fixes for log messge tag.

2020-01-27T14:30:28+00:00

Fixed wrong log entry tags to list the entries properly. Tested: Verified it is comming in journalctl logs Change-Id: I5352f9f87eb43414b4b04335ba43219e452785c6 Signed-off-by: Richard Marian Thomaiyar

[Fix]: Check ipmi groups list before creating user

2020-01-23T09:58:43+00:00

When phosphor-user-manager is started later than ipmid, then ipmid misses to get the AvailableGroups list from phosphor-user-manager. Further creation of user through ipmi will end up creating user which doesn't belong to any group at all. This fixes, by making sure, ipmi creates user only if ipmi group is in available groups lists, and will do re-query if it is empty. Tested: 1. Verified the user creation behaviour with having dependency to phosphor-user-manager and without. 2. Manually tested the following. a. Stopped phosphor-user-manager & all ipmi b. Started phosphor-host-ipmid c. started phosphor-user-manager d. using ipmitool user set name created user and verified that it belongs to proper group as expected. Change-Id: I5810babda0e70eb7b6bca577af2031da90dbb068 Signed-off-by: Richard Marian Thomaiyar