path: root/cooling-type
diff options
authorBrandon Wyman <>2017-07-27 15:37:55 -0500
committerBrandon Wyman <>2017-08-01 14:29:11 -0500
commit4253fcaa5af69241ddc06ae72d3f94fd3b8818c9 (patch)
tree9c37a426ecc2780414129574c008376727731021 /cooling-type
parentce75b511690b68822882ed04a232bb07ec7696ff (diff)
Switch which GPIO value sets air or water cooled
During the coding and testing of this application there was some miscommunication on the jumper position for a Witherspoon system. The system was jumpered for Air when intended to be jumpered for the Water cooled position. Further examination of the documentation and the jumper settings on systems found that the logic was reversed. This change should correct the problem and report the correct cooling properties. Resolves openbmc/openbmc#2041 Change-Id: I7e25bd72342fde40df1fec8f6a1a444eac401f09 Signed-off-by: Brandon Wyman <>
Diffstat (limited to 'cooling-type')
1 files changed, 2 insertions, 2 deletions
diff --git a/cooling-type/cooling_type.cpp b/cooling-type/cooling_type.cpp
index c1f96aa..3cb19ab 100644
--- a/cooling-type/cooling_type.cpp
+++ b/cooling-type/cooling_type.cpp
@@ -68,11 +68,11 @@ void CoolingType::readGpio(const std::string& gpioPath, unsigned int keycode)
// TODO openbmc/phosphor-fan-presence#6
if (value > 0)
- setWaterCooled();
+ setAirCooled();
- setAirCooled();
+ setWaterCooled();
OpenPOWER on IntegriCloud