diff options
author | Matthew Barth <msbarth@us.ibm.com> | 2018-01-11 13:53:49 -0600 |
---|---|---|
committer | Matthew Barth <msbarth@us.ibm.com> | 2018-03-06 13:45:15 -0600 |
commit | e3d1c4a9f155cdd05660eb1cf5c334972a5b0aea (patch) | |
tree | c914c43439806239bfb629d1f0a9fab4c133da1e /control | |
parent | 6c050693b6ac5a067013baadce62007e42678b6c (diff) | |
download | phosphor-fan-presence-e3d1c4a9f155cdd05660eb1cf5c334972a5b0aea.tar.gz phosphor-fan-presence-e3d1c4a9f155cdd05660eb1cf5c334972a5b0aea.zip |
Make event actions optional
Event actions should be made optional for events that only require
subscribing to group signals.
This is in preparation for separating signal and timer based event
actions. A use case would be where one event can be used to subscribe to
signals that update cached property values without performing an action,
and another timer based event performs an action based on those
property values the signal event provides.
Tested:
Events without an action are generated correctly
Events without an action are handled correctly and run no action
Change-Id: I757a82ce6c45ac637ce7cea8f82a62b98b600e3e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Diffstat (limited to 'control')
-rwxr-xr-x | control/gen-fan-zone-defs.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/control/gen-fan-zone-defs.py b/control/gen-fan-zone-defs.py index 40bec2c..b89e5bc 100755 --- a/control/gen-fan-zone-defs.py +++ b/control/gen-fan-zone-defs.py @@ -393,8 +393,11 @@ def getEvent(zone_num, zone_conditions, e, events_data): return event['groups'] = grps - # Add set speed actions and function parameters - event['action'] = getActions(e, e, events_data) + # Add optional set speed actions and function parameters + event['action'] = [] + if ('actions' in e) and \ + (e['actions'] is not None): + event['action'] = getActions(e, e, events_data) # Add signal handlers signals = [] |