summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2019-02-13 14:48:21 -0800
committerPatrick Venture <venture@google.com>2019-02-13 14:49:44 -0800
commit4b258ac8b679b8d160d0c3f290c0ecee6a99a1e3 (patch)
tree0dc82bbfe454c8737486bc937b678a6b239bde28
parent0a1f686cb44a19a4c459cfe2cbb3cc565749066d (diff)
downloadphosphor-fan-presence-4b258ac8b679b8d160d0c3f290c0ecee6a99a1e3.tar.gz
phosphor-fan-presence-4b258ac8b679b8d160d0c3f290c0ecee6a99a1e3.zip
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: Id750ce7c0fb89f94c0da53868f695ac161475674 Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r--configure.ac18
1 files changed, 6 insertions, 12 deletions
diff --git a/configure.ac b/configure.ac
index 0421801..9f1ffcf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -26,18 +26,12 @@ AX_CXX_COMPILE_STDCXX_17([noext])
AX_APPEND_COMPILE_FLAGS([-Wall -Werror], [CXXFLAGS])
# Checks for libraries.
-PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus], ,
-[AC_MSG_ERROR([The openbmc/sdbusplus package is required])])
-PKG_CHECK_MODULES([SDEVENTPLUS], [sdeventplus], ,
-[AC_MSG_ERROR([The openbmc/sdeventplus package is required])])
-PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging], ,
-[AC_MSG_ERROR([The openbmc/phosphor-logging package is required])])
-PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221], ,
-[AC_MSG_ERROR([Could not find systemd...systemd development package required])])
-PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces], ,
-[AC_MSG_ERROR([Could not find phosphor-dbus-interfaces...openbmc/phosphor-dbus-interfaces package required])])
-PKG_CHECK_MODULES([LIBEVDEV], [libevdev], ,
-[AC_MSG_ERROR([The libevdev package is required])])
+PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus])
+PKG_CHECK_MODULES([SDEVENTPLUS], [sdeventplus])
+PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging])
+PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221])
+PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces])
+PKG_CHECK_MODULES([LIBEVDEV], [libevdev])
# Checks for library functions.
LT_INIT # Required for systemd linking
OpenPOWER on IntegriCloud