| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I9f21e6378f74bf9dd7d413557a80b47ec9c9f829
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ie80bff38947a79cc686eaf9db9c80453d28a4fb6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
| |
The callout to resolve is specified in the YAML.
Change-Id: If613fae1959c6a54279b2a50c7d858f3e7d831b9
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Fill in the function that sets the Resolved property
on an error log entry.
Change-Id: I78b57c413a7047508b7fc95e0cf27e1ae6e871cf
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
In order to find the error logs that have a specific callout,
the code needs to look in the 'endpoints' property of the
'<callout>/fault' D-Bus object.
Change-Id: Idb9c06a6d815195ed47fb6ec914ba8f89539cb85
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Add a function to SDBusPlus to get the D-Bus bus
name for an object path and interface.
Change-Id: I7d7a533c7430fcf42e1e0f6a21a2453e6c8197ea
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is a type of callback, and when triggered will
resolve all error log entries that have the specified callout.
It does this by setting the Resolved property on the log entry.
It can be used to do things like resolve all errors against a
particular part when that part is replaced, which would be done
by specifying this class as a callback on a watch on the Present
property for the part in the inventory.
Change-Id: I50557938c9e15a91744ee2a16d67eaa7f367ef04
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Change-Id: I83c844373ea41d762367085cb16b01d31676e33d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
| |
Add tests to callbackgroupgentest/test.yaml
Change-Id: I0b9d4799dd3ed3a4876115594aacbd80caa3f9d0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I97f73dd310cae4b2d67122bc51414e2a5397f0b3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I58a6ac714cfa80462ab53d4487dc727e40038b06
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Added support for metadata in elog.hpp, elog mako file, and pdmgen.
This metadata will be added with the error log.
Change-Id: Iaf0fe24d71f6bdd02b51df208b2c1d66c68319d3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for "callback: elog" in PDM.
templates/elog.mako.cpp is used to generate the Elog call.
templates/errors.mako.hpp is used to generate the errors.hpp
used by generated.hpp to include any error.hpp files like
"xyz/openbmc_project/Common/error.hpp"
Change-Id: Id0ae3aca4282095f58a8939b70e398bec706d7f5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Created new Elog callback, which will create an error log.
This is just the base, more to come.
Change-Id: I50c12c8bff0942b5cb027e38d0cc8691e8a241b4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ia9ae40f1bd590945e2fee662e4437b92c8bd9b09
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
phosphor-msl-verify is a oneshot application for basic
minimum ship level (MSL) verification.
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/README.msl.md
Change-Id: Ifa036bb0a45255af7c7773bd910e83c64842d868
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Remove a number of unused files.
Change-Id: If7e40d2be7eb3f5d84538a3c86f911df268a1f34
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Prefer implicit conversion for readability.
Change-Id: I64d04b926edea0531a5414a416c04b36ae3d5e2a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Switch from sd_bus process to sd_event run so that sd event
handlers are invoked.
Change-Id: If7c1f046f30cc845c6e9fcc72eb99c5bdfb36052
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow watch class users to explicitly invoke the watch
callback.
Since watches and callbacks share a common pool of state
all watches must complete their initialization prior to
invoking their callback methods.
Change-Id: I62ebad64da88a145f3d5006b07c01381b0eb6728
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Add a simple test that invokes all the callbacks. There
are no assertions but there is some value in ensuring
the application will at least run without crashing.
Change-Id: I117bff261202ae7e642094a659a954328351eac1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Fix a number of bugs related to rendering and instantiation of
string and bool templates.
Change-Id: Ic75842b4016f4d96bf5850f9c4ad778d82e075ed
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
journald ignores lowercase metadata keys so require them
to be uppercase. Abort the config file parse when lowercase
keys are found.
Change-Id: Icffffdc6680b4d305329c3395f8e2fda6210964f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: Id6e14414c6f15c11d1476039e3781d719f693d21
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Deferrable callbacks delay callback invocation until a
pre configured length of time has elapsed. One example
scenario where deferrable callbacks help is to avoid
oscillation when testing a condition and making callbacks
frequently.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I180c99b57ec1c9bde4da76d947a026f809341c8a
|
|
|
|
|
|
|
|
| |
Add an sd-event interface abstraction to facilitate
mocking and unit test.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I5880617565fc6eab54335adc30033d4b132568f8
|
|
|
|
|
|
|
|
|
|
|
| |
Add C++ wrappers around select sd-event APIs, for a more C++ like
programming API.
Includes support for core sd_event and timer related sd_event_source
APIs.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I10ac5406c9f8831b4efb294d3aef36026469d4a5
|
|
|
|
|
| |
Change-Id: Id4157b9f40c80c5bb7d54d10f74ba7ecdeb199e5
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Add support for a method callback. The method callback enables
arbitrary DBus method calls. A sample use case could be
starting a systemd unit via the sytemd DBus API.
Change-Id: If25131d11497c82f862ae1f47da066c5fd8b2e2e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add core support for rendering argument lists. Add a number of
decorators like:
-literal: Render a literal value.
-cast: Render a C++ cast.
-fixbool: Work around yaml boolean capitalization.
-quote: Quote a string literal.
Change-Id: I4364d9f7a8cb7bb932d347d34bfabb88e694020a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Callbacks must ultimately be triggered when a property
is updated by a watch. Add that support.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I20130a11c19ddcf2c4ae45800f2068b31950bcd6
|
|
|
|
|
| |
Change-Id: I94059c0be78d5b97e7e0e11c78d4a164a98a483e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Enable conditional application of callbacks.
Change-Id: I9d765e5f585aac40994b65da3b51ea891beae9bf
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: Icbdc8612d73bed065227d9edfde1426206886652
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Allow named collections of callbacks to be defined and used anywhere
callbacks are used.
Change-Id: I3224aa06b2250e9a055bc70d20c186caecd033af
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: Iff1ddb9c18b5384d05a4d2dbfba95ade8cc1783c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Callbacks are the response in the PDM 'trigger->response' model.
Add general support for implementing callbacks and implement
a log to systemd journal using that framework.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I8bead5368ee5472a02b47e8bba9e9df3a1f346bc
|
|
|
|
|
|
|
|
| |
Add a template for obtaining a format string at build for a
built-in C++ type.
Change-Id: I8e5d26d4481b3ddafb5ffddbb058a1c75b3a2257
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I9e9266901414c71a34d9686f2a45bc4764602d53
|
|
|
|
|
|
|
|
|
| |
Property watches cache DBus property values given an externally
supplied index of property names and paths, in an externally
supplied storage location.
Change-Id: I155081da88c3ab0e4f6a13b012fc9719203b1888
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
Add a DBus interface abstraction to facilitate
mocking and unit test.
Change-Id: I914cba7500d79bc4d3022cb12e4c02adf6a78c19
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I4b30d0729a704d6833c840ea08daeee961a5730b
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Add support for defining groups of DBus properties. Groups are
a list of property/interface/metadata tuples. Metadata can be used to
give a property context when required.
Change-Id: I5fc27f4d815b53332a2ddea2d270fde8e355dcbc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I296de0e0cb30e0e25f6677a06bd04fe15c2fd015
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Add support for defining groups of object paths. Groups are
a list of path/metadata tuples. Metadata can be used to
give a path context when required.
Change-Id: I355ebf76b40f2ffc8d783e94e888b930cde8ee9c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add logic to parse each yaml file in three stages.
1 - Invoke factory methods for config file directives, generating
more factory methods.
2 - Invoke factory methods from 1 for the full set of renderable
items.
3 - Run 'setup' on all renderable items to resolve item cross
references.
Change-Id: I428a9ae1c41cf65e1efc05f3ec7177375822d772
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add convenience type aliases for working with references:
RefKeyMap: A map with references as keys.
TupleRefMap: A map with a tuple of references as keys.
RefVector: A vector or references.
TupleOfRefs: A tuple of references.
Add DBus related convenience type aliases:
MapperPath: The Phosphor mapper currently uses a std::string for
object paths. This is a bug and will someday be switched
to sdbusplus::message::object_path. Add an alias for easy
refactoring.
InterfacesAdded: The C++ type for the
org.freedesktop.DBus.ObjectManager.InterfacesAdded signal
argument.
PropertiesChanged: The C++ type for the
org.freedesktop.DBus.Properties.PropertiesChanged signal
argument.
GetObject: The C++ type for the
xyz.openbmc_project.ObjectMapper.GetMethod method response.
Change-Id: I719aa7c610b3312ce8e52825cb07b33a348bf896
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Add a test directory to host future unit tests.
Change-Id: I5072cb3055386f7b1718edc45241c723d9e63a54
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add vars.mk for variable sharing across makefiles.
Stub and rename example YAML file and template.
Content to be re-introduced as support is added.
Move generated C++ to a header file.
Add input YAML path option to configure.
Change-Id: Ia06e392e8b120b1e1d8614046064fa432a6f9e18
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
| |
Add an option for specifying an alternate template for testcases.
Update the output option to include the desired output filename as
well as the directory.
Add an option for specifying the mako template search path.
Change-Id: I88634fee193409b25988eb1e7d7680aa866cc2e9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|