summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Spinler <spinler@us.ibm.com>2018-06-13 13:51:40 -0500
committerMatt Spinler <spinler@us.ibm.com>2018-06-13 14:12:33 -0500
commit195550c6071571aa01945cf061efe26d12dba4cc (patch)
treebe8d50ae181dab37a4709cf6740472ee916f8f44
parent0049c98b6e4ee5fa5e78054a5a666b1e29598ab7 (diff)
downloadphosphor-dbus-monitor-195550c6071571aa01945cf061efe26d12dba4cc.zip
phosphor-dbus-monitor-195550c6071571aa01945cf061efe26d12dba4cc.tar.gz
Remove journal entries for failed sdbusplus calls
Calling code is already handling any missing method call response data appropriately, and many times the failed call is expected. For example, any time there is a dbus monitor rule that watches a property, it will try to read that property right away on startup to cache the value if possible. It's possible that some D-Bus objects may not exist at that moment in time, and the code already expects that. Tested: No more 'Failed to parse method response' journal entries. Change-Id: Iaa84020a34a96395abf7a3460c96ec0dc255fa23 Signed-off-by: Matt Spinler <spinler@us.ibm.com>
-rw-r--r--src/sdbusplus.hpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/sdbusplus.hpp b/src/sdbusplus.hpp
index 4339bad..f37f7de 100644
--- a/src/sdbusplus.hpp
+++ b/src/sdbusplus.hpp
@@ -83,9 +83,8 @@ class SDBusPlus
}
catch (const SdBusError& e)
{
- log<level::ERR>("Failed to parse method response",
- entry("ERROR=%s", e.what()),
- entry("REPLY_SIG=%s", respMsg.get_signature()));
+ // Empty responses are expected sometimes, and the calling
+ // code is set up to handle it.
}
return resp;
}
OpenPOWER on IntegriCloud