openpower-pnor-code-mgmt/test, branch master

Fix ECC usage of being cleaned partitions

2019-12-20T07:23:22+00:00

Reset procedure of PNOR works improperly for our P8 based VESNIN hardware and makes the host unbootable. The problem is in incorrect partition cleaning. Hostboot for P8 has no support for CLEARECC bit and PNOR flash has no partitions with flag 'C'. P9 based hardware is not affected until PNOR has partitions with ECC flag only. This commit modifies the reset procedure to make it use the flag 'E' (ECC) instead of 'C' (CLEARECC). * The flag 'E' means that the partition requires ECC. * The flag 'C' means that the partition might be cleaned by hostboot when ECC is wrong. For details see: https://github.com/open-power/hostboot/blob/75c0908b91275dc10bd17cb0f10b452f32ce0b91/src/include/usr/pnor/pnor_const.H#L128 Tested: All PNOR partitions with enabled flags 'E' and 'F' should be cleaned with ECC. Change-Id: I632e90c8e256df3445fc3d1f45c830d155a1d208 Signed-off-by: Alexander Filippov

msl: Support for v-xx.xx.xx format version ID

2019-09-17T00:47:17+00:00

The version ID of the pnor we have released is similar to the following format. Inspur-Dubai-v-4.1.01 This change adds support for parsing version ID in v-xx.xx.xx format Signed-off-by: John Wang Change-Id: I1a7dd04256d1901e3dafef14baf338b853e2ff97

Move to new association interface

2019-09-17T00:47:17+00:00

A new association interface is defined in phosphor-dbus-interfaces It would be nice to move the local version of the interface to the new one. The behavior of how association work is described here: https://github.com/openbmc/docs/blob/master/object-mapper.md#associations Partially resolves openbmc/openbmc#3584 Tested: See the org.openbmc.Associations interface has been replaced by the xyz one in /xyz/openbmc_project/software/version_id object and only when the version number is less than PNOR_MSL, "PNOR Minimum Ship Level NOT met" is reported. Signed-off-by: John Wang Change-Id: If4afeb69a9bd8bc494b77826f2ec2854a71f56f5

Static layout: support image verification

2019-04-04T20:13:55+00:00

Add support of image verification for static layout PNOR code update. Tested: Verify the PNOR code update succeeds with valid-signed PNOR; and fails with invalid-signed PNOR or a PNOR tarball without signature. Change-Id: I1aafeb4e8e07eaa16c170f33f4f21940f7c9c146 Signed-off-by: Lei YU

Refactor: Use hiomapd instead of mboxd

2019-03-18T03:25:47+00:00

mbox service is renamed to hiomapd and provides "Suspend" and "Resume" method calls, which is more appropriate for raw "cmd" calls. Use the new methods to suspend and resume hiomapd. Move "getService()" function into utils so it is shared by multiple files. Tested: Verify the reset works on Romulus Change-Id: I8f89de134b13126697bfc69a21a3148a01c34cca Signed-off-by: Lei YU

test: Add test for getPartsToClear

2019-03-13T03:01:53+00:00

Add the test for getPartsToClear(), and fix issues found by the unit test case with malformed input. Tested: Verify test builds and passes. Change-Id: I67c8bbd184e7e0c0f7f0f0fca678d1952a07cd66 Signed-off-by: Lei YU

test: Add test for GetVersions()

2019-03-13T03:01:53+00:00

Also split and rename the cases in utest.cpp into test_signature and test_version. Tested: Verify test is built and passed. Change-Id: Ibe59355936d9366be8e3f56760bff7384a28a28c Signed-off-by: Lei YU

test: Add sources of static PNOR

2019-03-13T03:01:53+00:00

Add sources in static dir to test. It generates a link error about duplcated GardReset::reset(). Then an issue is found that GardReset::~GardReset() is not virtual, this will casuse the destructor not calling its super class' dtor. To fix the above link error, add GardReset[Ubi|Static] to make ubi/static specific implementation in its own class. Tested: Verify the test build works fine. Change-Id: I41bd4d522e8b9c4053283c0cf4373807ef4f2d1c Signed-off-by: Lei YU

test: Fix parallel build error on tests

2019-03-13T03:01:53+00:00

The test was using LDADD to link the objects, this results in below error when building with `make check -j` *** No rule to make target '../openpower_update_manager-activation.o', needed by 'utest'. Stop. Because the test depends on the objects to be pre-build, but there is no rule in test/Makefile.am to build t he objects. This commit changes it to add sources instead of linking to objects, so parallel build works fine. Tested: run `make check -j` without error. Change-Id: Ie7aaac49756fdd3b8941c1dec8f693ec66f659ab Signed-off-by: Lei YU

Refactor: Move serialize to ubi

2019-03-08T06:25:37+00:00

Functions in serialize are specific to UBI, move it to ubi dir. Tested: On the last commit of the patch series, run code update and factory reset on Witherspoon and all work fine. Change-Id: I9176e638d9f3bfe0d424b57f8da4667a751cb5bd Signed-off-by: Lei YU