openpower-pnor-code-mgmt, branch master

generate-tar: Add machine name

2020-01-21T02:37:25+00:00

The openbmc image manager expects "MachineName" in MANIFEST that matches the BMC's OPENBMC_TARGET_MACHINE in /etc/os-release. * If there is no MachineName in MANIFEST, it logs a warning for now; * If they do not match, an error is reported and the version is deleted. Add -m, --machine argument for generate-tar to make it support the "MachineName". Tested: Verify that when a correct machine name is given, the tarball is processed by image manager correctly; And if an invalid machine name is given, the tarball uploaded will get "Machine name doesn't match" error and is deleted. Signed-off-by: Lei YU Change-Id: I8fbb5060cb1be348c39e0688fe7306426cc4ed77

generate-tar: Add --interactive=never for rm

2020-01-20T03:06:08+00:00

On generating Witherspoon PNOR tarball, rm is asking for confirmation on removing the files in the temp dir, because the partitions are read-only now. Add --interactive=never so that it does not ask for interaction. Tested: Run the script to generate Witherspoon PNOR and verify it does not ask for interfaction to remove the files in temp dir. Signed-off-by: Lei YU Change-Id: I89e94e47e02fab53eaca952a70dc672407b75cc7

Fix ECC usage of being cleaned partitions

2019-12-20T07:23:22+00:00

Reset procedure of PNOR works improperly for our P8 based VESNIN hardware and makes the host unbootable. The problem is in incorrect partition cleaning. Hostboot for P8 has no support for CLEARECC bit and PNOR flash has no partitions with flag 'C'. P9 based hardware is not affected until PNOR has partitions with ECC flag only. This commit modifies the reset procedure to make it use the flag 'E' (ECC) instead of 'C' (CLEARECC). * The flag 'E' means that the partition requires ECC. * The flag 'C' means that the partition might be cleaned by hostboot when ECC is wrong. For details see: https://github.com/open-power/hostboot/blob/75c0908b91275dc10bd17cb0f10b452f32ce0b91/src/include/usr/pnor/pnor_const.H#L128 Tested: All PNOR partitions with enabled flags 'E' and 'F' should be cleaned with ECC. Change-Id: I632e90c8e256df3445fc3d1f45c830d155a1d208 Signed-off-by: Alexander Filippov

Host.Updater.service: Move dependency on ubi service to the ubi service

2019-10-28T19:11:08+00:00

The org.open_power.Software.Host.Updater.service is a service common to the static and ubi layout, but it had a dependency on a ubi service. It doesn't cause a failure on the static layout because the dependency is a Wants vs a Required, but it should not be there. Move the dependency instead to the ubi service. Tested: Verified on witherspoon that the org.open_power.Software.Host.Updater.service started followed by the obmc-flash-bios-ubipatch.service as it did before. Change-Id: I9c850e312d0b11faaf2a08db6b3ccb17cdfcbcb6 Signed-off-by: Adriana Kobylak

Move updatesymlinks to new vpnor feature

2019-10-25T14:20:20+00:00

The updatesymlinks functionality is to support virtual pnor and it does not depend on the filesystem type. Move it to a new vpnor feature so that users can make use of this feature without being tied to UBI, for example on a eMMC that has a combined BMC+PNOR image. Tested: Verified that the witherspoon image contained the new script and service file and that it powered on to the host. Change-Id: Ic5e51dfde81718e5e285f010be67afbd58eac2e1 Signed-off-by: Adriana Kobylak

generate-tar: Set permissions of partition files to read only

2019-10-15T15:10:14+00:00

Set file permissions to 440 since the PNOR partition files are intended to be read-only and managed by the mbox application, so the permissions should be set accordingly for cases where the BMC root filesystem is not read-only. Tested: Before: -rw-r--r-- 1 root root 1179648 Oct 9 18:43 HBD After: -r--r----- 1 root root 1179648 Oct 9 15:33 HBD Change-Id: I9eaf773fc09a12c4c0ed02302a41eb959719013f Signed-off-by: Adriana Kobylak

generate-tar: Call mksquashfs with -all-root option

2019-10-09T18:54:50+00:00

The mksquashfs command preserves the owner of the files it squashes, which is the login name of the user that runs generate-tar since the partiton files are extracted into a local directory by pflash. Bitbake sets the owner for the filesystem files to root as default, so makes sense that the PNOR partition files are also owned by root instead of a user name that doesn't exist on the BMC. Tested: Before: root@witherspoon:~# ls -l /media/pnor-ro-652c7b59/ -rw-rw-r-- 1 253760 401855 32768 Aug 15 14:39 ATTR_PERM After: root@witherspoon:~# ls -l /media/pnor-ro-944751fd/ -rw-rw-r-- 1 root root 32768 Sep 11 15:07 ATTR_PERM -rw-rw-r-- 1 root root 32768 Sep 11 15:07 ATTR_TMP Change-Id: Ic2cbed13e0da687e51a5c15041f54fef93c07be9 Signed-off-by: Adriana Kobylak

msl: Support for v-xx.xx.xx format version ID

2019-09-17T00:47:17+00:00

The version ID of the pnor we have released is similar to the following format. Inspur-Dubai-v-4.1.01 This change adds support for parsing version ID in v-xx.xx.xx format Signed-off-by: John Wang Change-Id: I1a7dd04256d1901e3dafef14baf338b853e2ff97

Move to new association interface

2019-09-17T00:47:17+00:00

A new association interface is defined in phosphor-dbus-interfaces It would be nice to move the local version of the interface to the new one. The behavior of how association work is described here: https://github.com/openbmc/docs/blob/master/object-mapper.md#associations Partially resolves openbmc/openbmc#3584 Tested: See the org.openbmc.Associations interface has been replaced by the xyz one in /xyz/openbmc_project/software/version_id object and only when the version number is less than PNOR_MSL, "PNOR Minimum Ship Level NOT met" is reported. Signed-off-by: John Wang Change-Id: If4afeb69a9bd8bc494b77826f2ec2854a71f56f5

Use wc to calculate file sizes

2019-08-19T17:28:13+00:00

Milton pointed out that for the du command the -b and -k options aren't really compatible. From the man page: -b, --bytes equivalent to '--apparent-size --block-size=1' -k like --block-size=1K As a result 'du -bk' will act as if the following args were used: --apparent-size --block-size=1K However, it's probably not safe to assume this. Fix this by replacing the use of du with "wc -c". POSIX requires that wc -c prints size of each input file in bytes so it should be safe (and portable). Fixes: adf91f58dac9 ("Fix generate-tar on ppc64 hosts") Signed-off-by: Oliver O'Halloran Change-Id: I1baf96b4c5304a27ddedf3384cf23d2c346134d8