From db58b749f74d86a5fc0b9b959c3711ff8098fa11 Mon Sep 17 00:00:00 2001 From: Patrick Venture Date: Wed, 13 Feb 2019 15:38:39 -0800 Subject: build: pkg anti-pattern: use defaults Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: Iba453ba564da46c020e9cf72d7fb6c998d9904ab Signed-off-by: Patrick Venture --- configure.ac | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 07521ba..a0b7cd1 100644 --- a/configure.ac +++ b/configure.ac @@ -46,17 +46,13 @@ AS_IF([test "x$enable_install_error_yaml" != "xyes"], [ AC_SUBST([OESDK_TESTCASE_FLAGS], [$testcase_flags]) ) - PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],,\ - AC_MSG_ERROR(["Requires sdbusplus package."])) - PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],,\ - AC_MSG_ERROR(["Requires phosphor-logging package."])) - PKG_CHECK_MODULES([OPENPOWER_DBUS_INTERFACES], [openpower-dbus-interfaces],,\ - AC_MSG_ERROR(["Requires openpower-dbus-interfaces package."])) - PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],,\ - AC_MSG_ERROR(["Requires phosphor-dbus-interfaces package."])) + PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) + PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging]) + PKG_CHECK_MODULES([OPENPOWER_DBUS_INTERFACES], [openpower-dbus-interfaces]) + PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces]) # Check for sdbusplus - PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],, [AC_MSG_ERROR(["sdbusplus packaged required and not found"])]) + PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) # Check for sdbus++ tool AC_PATH_PROG([SDBUSPLUSPLUS], [sdbus++]) -- cgit v1.2.1