jsnbd, branch master

js: Allow serving files > 4GB in size

2019-03-27T00:54:38+00:00

Currently, the javascript NBD server only handles files of sizes that are representable in 32 bits. Although we can't do full 64-bit offsets with Javascript's number representation, we should be able to handle up to Number.MAX_SAFE_INTEGER. This change adds support for using the top-32 bit field in file sizes and read request offsets. Reported-by: Lei YU Signed-off-by: Jeremy Kerr Change-Id: I41dee58c3913cba49c5cd73ebdd5d6fb56786d25

client: fix gcc8 stringop-truncation warnings

2018-10-29T12:47:33+00:00

| In function 'open_nbd_socket.isra.2', | inlined from 'main' at ../git/nbd-proxy.c:835:7: | ../git/nbd-proxy.c:102:2: error: 'strncpy' specified bound 108 equals destination size [-Werror=stringop-truncation] | strncpy(addr.sun_path, path, sizeof(addr.sun_path)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I9f412d789f4e5ef1dffe05b37d903a5375fea8ec Signed-off-by: Brad Bishop

nbd-proxy: run start hook asynchronously

2018-08-13T05:13:16+00:00

Currently, we run the start hook synchronously, and wait() for it to complete. This means that the proxy process will be blocked during the execution of that hook, and no servicing any read/write requests from the nbd device. If any part of the hook implementation needs to access the device, it'll block waiting for the device (which is waiting for the nbd-proxy, which is waiting for the hook). This change runs the hook (for the "start" action) in the background, while still servicing requests. This allows hooks to access the device. Signed-off-by: Jeremy Kerr

nbd-proxy: replace hook dir with a single executable

2018-08-13T03:48:23+00:00

A future change will run the executable asynchronously. With a directory of hooks, this gets overly complicated. Replace the directory-of-hooks concept with a single hook. The hook itself can then spawn multiple hooks if required (eg, with run-parts). Signed-off-by: Jeremy Kerr

nbd-proxy: listen for udev change event before running start hook

2018-08-10T04:44:47+00:00

Currently, we run the start state-change hook as soon as the nbd session has been established. However, at that point the nbd device isn't connected, as we haven't processed any read/write operations on the block device. This change defers running the start script until we know that the device is initialised - when we see a udev change event occur. To do this, we establish a udev monitor. Once we see that state change, we run the state change hooks and shut down the udev monitor. Signed-off-by: Jeremy Kerr

nbd-proxy: clear errors from checking hook presence

2018-08-10T03:14:54+00:00

We don't want to report an error if a hook is inacessable (and is the last hook we check), so clear rc in these conditions. Signed-off-by: Jeremy Kerr

autotools: use localstatedir, not runstatedir

2018-08-10T03:13:03+00:00

.. runstatedir is only present in autoconf 2.70+ Signed-off-by: Jeremy Kerr

nbd-proxy: use CLOEXEC

2018-08-09T05:46:19+00:00

We spawn a couple of subprocesses, and want to make sure we don't leak file descriptors to those. Rather than closing before exec, set CLOEXEC on sockets and internal pipes. Signed-off-by: Jeremy Kerr

nbd-proxy: Add state hook facility

2018-08-09T05:46:19+00:00

Signed-off-by: Jeremy Kerr

nbd-proxy: Add metadata facility

2018-08-09T05:46:19+00:00

Signed-off-by: Jeremy Kerr