From 524ba9c1bd349141c79f213c56afc3b25f699593 Mon Sep 17 00:00:00 2001 From: Patrick Venture Date: Sat, 20 Oct 2018 20:52:27 -0700 Subject: IPMIFruArea: move private area under public For standard readability a class is typically written with public preceding private. Change-Id: Icdce1ee8426d651293d16f9a1ba16176a3f767c3 Signed-off-by: Patrick Venture --- fru_area.hpp | 74 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/fru_area.hpp b/fru_area.hpp index 2a6eed0..8cb9c00 100644 --- a/fru_area.hpp +++ b/fru_area.hpp @@ -13,43 +13,6 @@ using std::uint8_t; class IPMIFruArea { - private: - // Unique way of identifying a FRU - uint8_t fruid = 0; - - // Type of the fru matching offsets in common header - ipmi_fru_area_type type = IPMI_FRU_AREA_INTERNAL_USE; - - // Name of the fru area. ( BOARD/CHASSIS/PRODUCT ) - std::string name; - - // Length of a specific fru area. - size_t len = 0; - - // Special bit for BMC readable eeprom only. - bool bmc_fru = false; - - // If a FRU is physically present. - bool isPresent = false; - - // Whether a particular area is valid ? - bool isValid = false; - - // Actual area data. - uint8_t* data = nullptr; - - // fru inventory dbus name - std::string bus_name; - - // fru inventory dbus object path - std::string obj_path; - - // fru inventory dbus interface name - std::string intf_name; - - // Default constructor disabled. - IPMIFruArea(); - public: // constructor IPMIFruArea(const uint8_t fruid, const ipmi_fru_area_type type, @@ -117,6 +80,43 @@ class IPMIFruArea // Sets the dbus parameters void update_dbus_paths(const char*, const char*, const char*); + + private: + // Unique way of identifying a FRU + uint8_t fruid = 0; + + // Type of the fru matching offsets in common header + ipmi_fru_area_type type = IPMI_FRU_AREA_INTERNAL_USE; + + // Name of the fru area. ( BOARD/CHASSIS/PRODUCT ) + std::string name; + + // Length of a specific fru area. + size_t len = 0; + + // Special bit for BMC readable eeprom only. + bool bmc_fru = false; + + // If a FRU is physically present. + bool isPresent = false; + + // Whether a particular area is valid ? + bool isValid = false; + + // Actual area data. + uint8_t* data = nullptr; + + // fru inventory dbus name + std::string bus_name; + + // fru inventory dbus object path + std::string obj_path; + + // fru inventory dbus interface name + std::string intf_name; + + // Default constructor disabled. + IPMIFruArea(); }; #endif -- cgit v1.2.1