From 1012b4bf4d380ce226e43a6cdeba48e4b480cfce Mon Sep 17 00:00:00 2001 From: Patrick Venture Date: Thu, 18 Oct 2018 14:56:11 -0700 Subject: writefrudata: drop function parameter set [writefrudata.cpp:570]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? Change-Id: Ie4162c28c10aa5964ebabb5f0db5f3f477ffa831 Signed-off-by: Patrick Venture --- writefrudata.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/writefrudata.cpp b/writefrudata.cpp index e704f04..704df12 100644 --- a/writefrudata.cpp +++ b/writefrudata.cpp @@ -561,13 +561,13 @@ int ipmi_validate_common_hdr(const uint8_t* fru_data, const size_t data_len) //------------------------------------------------------------ // Cleanup routine +// Must always be called as last reference to fru_fp. //------------------------------------------------------------ int cleanup_error(FILE* fru_fp, fru_area_vec_t& fru_area_vec) { if (fru_fp != NULL) { std::fclose(fru_fp); - fru_fp = NULL; } if (!(fru_area_vec.empty())) -- cgit v1.2.1