| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Use vector of bytes instead of raw byte pointer.
Change-Id: I20a2beec3cbbc44c8cc3a48cefd73f3f27bdcc8f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style dictates conditional statements needs curly braces.
Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
OpenBMC style dictates member variables be lower camel and not snake
case.
Change-Id: I3e217b51f910612c3e5ecf1480340a27ef29d774
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Set the language in the build to C++.
Change-Id: Iaf56356269617c0546d2b42a225bf8732fe6356c
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
| |
Change-Id: I56b9100c0d7ee8bee84c00eba4fd0d0899aa50e8
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
|
|
|
|
|
|
|
| |
Drop unused sd-bus.h header.
Change-Id: I0a55cd3aa5a551d7fa04706d7e0c5b6b275efcf5
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Function names should be lower camel and not snake case.
Change-Id: I6f8683850ce017e63641415846e8a0f031fccba7
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style declares variables be lower camel and not snake case.
Change-Id: I4a448b84ae3d930049d4cb761216459799a698fa
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style declares variables be lower camel and not snake case.
Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Fixup function naming to lowerCamelCase for OpenBMC style guide.
Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Update code to use sdbusplus instead of raw sd_bus pointers.
Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Set iterator to const reference where possible.
Change-Id: I2d5d766990d49df3e6a6fef743698053413152fc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Default constructor marked private, but should be deleted.
Change-Id: I324516c51bd5f59b68284d9adcbf117cd74115af
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.
Change-Id: Icf47bf376947d1afb0753c18be66417e2bac4507
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Apply naming convention to member functions.
Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
For standard readability a class is typically written with public
preceding private.
Change-Id: Icdce1ee8426d651293d16f9a1ba16176a3f767c3
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Drop iv_ prefix from class members.
Renamed class members where necessary and updated some method
parameters to avoid name conflicts.
Change-Id: Id888dab9fcc020c4dff68d689a38f869c0de3525
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused member methods.
Change-Id: I1bf78f8a896173deacc0f55e3e3b8f1f0c64302a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move member assignment to constructor list.
Change-Id: I140aabc92533c07f6c50eb19a323e6c52dbf43a4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move the implementation of the class into its own source file.
Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Cleanup headers, dropping sd-bus header and c-headers. Add in cstdint
for uint8_t.
Change-Id: I751478a83ac807b688bb9b7d9efff2efc7578a4a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Rename fru_area_vec_t to FruAreaVector and declare with using instead of
typedef.
Change-Id: I482c8ce7cedef1c67efb49b2e066ba9867547e93
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Rename fru-area.hpp header file per the openbmc file naming convention.
Change-Id: I751c8d5650bb5e71238923c4728a9cdedccc7c7f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop the sdbusplus/server.hpp for sdbusplus/bus.hpp header.
Change-Id: I8ea1ae95812ceb911ac6f70f259b5884e0c4ab3b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
| |
Rename ipmi_fru to IPMIFruArea
FRU is an acronym for Field Replaceable Unit, but is consistently Fru in
this codebase.
Change-Id: I53f82b51bbf01416c8a666082612cd70945cc9a5
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused sd_bus pointer from fru_info class.
Change-Id: Id93412c17d15118e8e6f66736c9dc74289392fa4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused member functions from fru_info class.
Change-Id: Iedf108979892cf12639652bd649efb5c2d7a74ef
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused lib mapper header.
Change-Id: Ia7d2aad793d49d0c0cd5c5636e1e240147c25188
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused header: dlfcn.h
Change-Id: I1ea305913572003fabf0c2b76e75f04640bb55cb
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add header writefrudata.hpp to corresponding file.
Change-Id: I2bec36d3c0744e7c496e7b7c161dfc6cf14bdf72
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add missing header map to add to standard namespace.
Change-Id: I719fd0d194cb6fd8fa2e67f8acb784b498cf122a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
[writefrudata.cpp:176] -> [writefrudata.cpp:242]: (style) Local
variable path shadows outer symbol
Change-Id: I9fc35d6d67f51a0b9a2b9174c314e560d8531119
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Move ipmi_update_inventory into an anonymous namespace and rename per
the openbmc style naming conventions.
Change-Id: I931bd9a50ca695d667eb5703089f1ca020ca6995
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move getService into an anonymous namespace.
Change-Id: I75df449858bdc8347fafe3c0ab839ff18b5a2496
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Move getFRUValue into anonymous namespace. A later step may move this
into a global scope to enable testing, or it may be replaced by an
interface.
Change-Id: Ie4299ab713a455dd8c18b91c842ded5dfc26e85b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Move cleanup_error into an anonymous namespace and rename per the
openbmc style naming conventions.
Change-Id: Ib307ce2e89ecaff241c7b2d2403b75dbce794dbb
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Apply openbmc style naming convention to ipmi_validate_fru_area as part
of a multi-step cleanup process.
Change-Id: I082189030441e57579d072501279ff698fe1b7e3
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
| |
Change-Id: Ibfe32351e04ace02cb830399a56cf1860a74df87
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Cleanup header from unnecessary guarding. The guards may have been
required in earlier compilations if the source was in a mixed
environment.
Change-Id: Id03a524ad8bd1375f1aefc0bec8661e4d929543a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add missing header "utility" provides std::pair<>.
Change-Id: I5d303c5f41f7af16ef3dc75fdd9818ed17978a5a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Fixup types.hpp to include the message header that provides the types
used.
Change-Id: If75a3288aa9a1ecd8313d50caf8d93f76e1ce06d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Use log<level::ERR>() instead of fprintf(stderr,...) on failure to
connect to sdbus.
Change-Id: Ie32d4f02c83a2d204ab71f0ab178d60c136dff97
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
[writefrudata.cpp:570]: (warning) Assignment of function parameter has
no effect outside the function. Did you forget dereferencing it?
Change-Id: Ie4162c28c10aa5964ebabb5f0db5f3f477ffa831
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.
Change-Id: I1b5c6327897c30be1be2f34212138b8cacb0bc84
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.
Change-Id: Iafdf71122e93e68f8da950f3b632460590dc3433
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
[strgfnhandler.cpp:29]: (style) C-style pointer casting
Change-Id: I12082f872362c913ecf0ad5abdcee0d1dfbc86e9
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
| |
[frup.cpp:628] -> [frup.cpp:694]: (style) The expression 'sdr < 0'
is always false.
This is true because the value is set to 0 and never re-assigned.
Change-Id: I668f5cc5a13a0c87afa3af978c341fb60f51b70d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Include cpp libraries for c-library calls.
Change-Id: Id082853977b2d0e3dde2bafa5a9eafe5252d9e0f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Catch sdbusplus call exceptions.
Change-Id: Iff0b2a4265061c90ebac78f90e4183f5e36037ef
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Add phosphor-logging flags throughout to enable dropping in logging
calls.
Change-Id: I6fdde8aebb6cdbacc8a779195bebdc112fb54d35
Signed-off-by: Patrick Venture <venture@google.com>
|