| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The type of the generated fru data contained a map of a map
of a map of a map, but for all except the outermost map, all
elements were iterated over when using the map. Therefore,
change them to a vector<pair<...>> instead.
Vector should generate smaller code and allow faster iteration.
Vector insert and iteration are both linear where as map
is O(n lg n).
Change-Id: I475e5a40b4051e4ce9478a565c889c1751241987
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminate one level of the generated "frus" map by creating
a structure for the lowest-level member.
This should reduce the impact of a gcc bug that consumes
excessive memory when compiling the generated map. Also
removed the runtime calculation of the 'delimiter' character
and instead generated it in the fru_gen python script.
Resolves openbmc/openbmc#1441.
Resolves openbmc/openbmc#1166.
Change-Id: Iafe049d034354d58b68d357b4f49fd5e21b2c8c7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
| |
The iter{keys,items} functions have become just 'keys' and 'items'
in python3. Python2 also has keys and items, which is slightly
less efficient for iteration but none of these maps are large enough
to be of concern.
Change-Id: If6e8f36ad39074e0a6c022fb09e3a43b0928af19
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
| |
sdbusplus's bus object has a change in semantics that no longer
require a 'sd_bus_ref' call. See changes for openbmc/openbmc#1432.
Change-Id: I853b9d88aa5711d29be3edce5d4ad67bfd27b3d1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
| |
There were references to the skeleton because it was still updating
items in the old namespace. This trims those out, however, doesn't
clean up all the extra bits. That will be a subsequent commit.
Fixes openbmc/openbmc#1425.
Change-Id: Ibe9af614458bced70f478f70ffb5b5195034bc7e
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Partially fixes openbmc/openbmc#875.
Change-Id: Ieaaa65fa8432ffa873dcf2f4f96f9c1e09de3008
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
| |
Partial fix for openbmc/openbmc#1112.
Change-Id: I467a9ffa68d9539c5c1f71e2dfa3281a347d5951
Signed-off-by: Leonel Gonzalez <lgonzalez@us.ibm.com>
|
|
|
|
|
|
|
| |
Add a script for generating PIM rules.
Change-Id: I9de54785938fcbf8de3a1ac8f42fa37a52f99d2c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
/xyz/openbmc_project/Inventory becomes
/xyz/openbmc_project/inventory
Change-Id: I95c1174b3cdbcd73a88c6bc004016e089c12f3e4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I8b403f07855cccb001eb63d6c5f11c5e1f58c874
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Make it possible for the openpower-vpd-parser recipe to be able to
supply the extra properties YAML as configurable input.
Use extra-properties-example.yaml as input.
Change-Id: I3cfffa6bb9709b4dbf5c487ab198960cc52e3863
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While the IPMI FRU parser, in order to update inventory, receives
most properties from the host IPMI, there could be some properties
whose values could be provided by other sources, such as the Machine
Readable Workbook.
Provide a mechanism to enable the above by having the extra property
information and values supplied via a YAML file, via which code is
generated, which in turn can be used by the parser to update inventory.
Change-Id: I30a2a9129d97485a0c31c3dec0155d5e1a008101
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I51f0decd8c71c4442556ce4d5fcfc10bd82efa48
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Idc83199d584ffe6d1b66debcb36244dd393495d0
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I9286045c3c10cd8bed840f03cfcc92a5b236d9ca
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I11784dd3faf3d4c6d76b8484b224e71a2817a95c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Id29024e34ac0c930fd4ff51c9886736324ea68e1
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
The logic assumed IPMI FRU data is encoded in ascii always, but the data
could be ascii or binary. Handle both encodings.
Change-Id: Ie89bb077fd32a23bb96bd4cda78b66d2ccdd9774
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
One of the IPMI FRU area checks deals with the old openbmc skeleton
interfaces, which is no longer valid. Fixed that.
Change-Id: Id406d4967d130136d4ac2a8efff94dac65d7ee0e
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
The class ipmi_fru has a disabled default ctor, and the custom one
doesn't initialise all class members. Fix this issue.
Change-Id: I9a0364743ba5afe41a319f9091fd8b0bd85f1777
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I83efc8ad799aaa879525d84b97779d5b98f168c4
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Id83220e5e2876f4112ba76d698b2062e2a08dd3d
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
| |
This header contains c++ code.
Change-Id: I4bc6cf0ddfbdc6ac4d93580a5203bb59537bbb04
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Allow the build to work in the event of an empty
YAML file.
Change-Id: I3d36b57852446959aeb836ab69958c16387c02fc
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
| |
Make a call to the inventory manager to construct
inventory objects for IPMI FRUs
Change-Id: I4b36ecc85bc78214c9c47032bafd013f6ff27fe9
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
The write FRU command now figures out properties to be written for a FRU
via a generated header file, which in turn is generated via scrips
deriving their inputs from MRW and Inventory d-bus interfaces.
Change-Id: I9939aeec24566cf518f4e63dc6ae344b236a541f
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
| |
It is required as we would be using c++ containers.
Change-Id: Ifefc468ac7b2e94d1b9948a6aeb7f8d42d8e6555
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
| |
fru-gen.hpp needs as input a YAML file. Enable this to be provided
via autotools configuration.
Change-Id: I586c14651840b6a9697a93261f79c2a48f14071f
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Add a script that generates c++ structures
based on system dependent configuration.
Change-Id: I3a005b2dd31d7db3137bed9be6df2a0658c48d82
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Add privilege level and package the provider library into
/usr/lib/ipmid-providers
Change-Id: I33be3ab696ba477a938b1c0272119420353d6d99
Signed-off-by: Tom <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Replaced the use of a manual Makefile with the use of autotools to
automatically verify and generate the necessary build files. Follow the
steps outlined within the README.md file to build the package.
Change-Id: Iaef09f17006ee51ac45f84c6c59826dcc567e279
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I4bb8cf7a58c517f348a524d3e027ebcd1dcd0dea
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Added -Werror to CFLAGS & CXXFLAGS.
Also corrected resulting compiler errors, including commenting out
possible future-use variables.
Change-Id: If70c7fdbf1d02f29e3d2cab5fa12b51bf5302cd5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
A number of arguments to printf were 'size_t', which is the
same size as 'int' only on 32-bit architectures. Replace all
%d format strings with %zd where size_t is the type passed.
Change-Id: Ida863312d692f47ca8240f32b75b8c55a8accc19
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
| |
Improper const was added in 804077 to one of the variables
used as a parameter to mapper_get_service.
Change-Id: I29eeb255794af381c48b505e12a7d68db6d5c54a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sd_bus_message_read(..."s"...) gives a pointer to a char*
from within the message. Even though the message is in
writable memory, it is generally bad to write to the char* from
within it. Also, as a reviewer it is less of a concern to see a
const char* that is lacking a free than it is a char*. Changing to
const char* hopefully avoids the confusion as to why the c-string
does not have a corresponding free.
Eventually this code will likely transition over to the sdbusplus
interfaces and this will be irrelevant.
Change-Id: I0dfe948bb2f0eee03042ba9b9dc7563995f59027
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
| |
Prefer mapper queries to hardcoded busnames.
React to /org/openbmc/managers/system GetObjectById
API change.
Change-Id: I651b820622c3bff51c05365b811b41e73fde997c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|\
| |
| | |
Fixes openbmc/ipmi-fru-parser#3
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IPMI fru record format can contain BINARY and ASCII encodings.
There was an error in the way FRU parser was handling the BINARY
encoded data and that resulted in incorrect updates to FRU Inventory object.
The reason why it was done like that was to workaround a limitation
encountered while creating the dictionary having a name and value pair
where value is an array of bytes.
This proposed fix will convert the array of binary encoded data into ascii
string and updates the FRU inventory as a string. Since string is a single
element, it fits in within the limits of dictionary.
Fixes openbmc/ipmi-fru-parser#3
|
|\
| |
| | |
Add shared library versioning
|
| |
| |
| |
| |
| |
| | |
Use -soname and install a library symlink.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
| |
| |
| |
| |
| |
| | |
A couple spaces at the end of line.
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|/
|
|
| |
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
| |
Fixes openbmc/ipmi-fru-parser#12.
|
|\
| |
| | |
Using new getFRUOjbect() API to fix 'not found in lookup' error message
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The ipmi-fru-parser calls the dbus method
SystemManager::getObjectFromId('FRU_STR', fru_area_name) for each fru areas
to get the dbus object path of fru area, even if the fru area does not exist.
Also ipmi_validate_fru_area() may be invoked multipul times before
full fru data is parsed. This will generate duplicated error
messages from SystemManager:, e.g:
"ERROR SystemManager: dbus.String(u'INTERNAL_13') not found in lookup".
In this case, "INTERNAL" area does not exists for FRU
In another pull request for skeleton, a new method:
getFRUArea(fru_id) is added specially for ipmi-fru-parser.
See PR: https://github.com/openbmc/skeleton/pull/62.
ipmi-fru-parser gets fru area names defined in Skeleton, and it calls
getObjectFromId() only for fru_aream_name already defined.
This way the 'not found in lookup' error message can be avoided.
Signed-off-by: Yi Li <adamliyi@msn.com>
|
|\ \
| |/
|/| |
Increase size of buffer length variable
|
|/
|
|
|
|
|
|
|
|
|
| |
The latest Barreleye vpd contains additional custom fields in one
of the board sections, pushing the size of the buffer over 0x100.
The current variable that stores the buffer size is set to be
size_t, but the function using it crops it to uint8_t which
doesn't fit the extended size. Changing the function to use size_t.
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|\
| |
| | |
Set Fault and Present status while handling fru
|
|/ |
|