summaryrefslogtreecommitdiffstats
path: root/writefrudata.cpp
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2018-10-18 14:56:11 -0700
committerPatrick Venture <venture@google.com>2018-10-18 14:56:11 -0700
commit1012b4bf4d380ce226e43a6cdeba48e4b480cfce (patch)
treee550e0d7bdf36b28326a4f65d05f1962cdd24dc9 /writefrudata.cpp
parent5c787214b16ecc36cb2e460eda3f90def3b54b7a (diff)
downloadipmi-fru-parser-1012b4bf4d380ce226e43a6cdeba48e4b480cfce.tar.gz
ipmi-fru-parser-1012b4bf4d380ce226e43a6cdeba48e4b480cfce.zip
writefrudata: drop function parameter set
[writefrudata.cpp:570]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? Change-Id: Ie4162c28c10aa5964ebabb5f0db5f3f477ffa831 Signed-off-by: Patrick Venture <venture@google.com>
Diffstat (limited to 'writefrudata.cpp')
-rw-r--r--writefrudata.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/writefrudata.cpp b/writefrudata.cpp
index e704f04..704df12 100644
--- a/writefrudata.cpp
+++ b/writefrudata.cpp
@@ -561,13 +561,13 @@ int ipmi_validate_common_hdr(const uint8_t* fru_data, const size_t data_len)
//------------------------------------------------------------
// Cleanup routine
+// Must always be called as last reference to fru_fp.
//------------------------------------------------------------
int cleanup_error(FILE* fru_fp, fru_area_vec_t& fru_area_vec)
{
if (fru_fp != NULL)
{
std::fclose(fru_fp);
- fru_fp = NULL;
}
if (!(fru_area_vec.empty()))
OpenPOWER on IntegriCloud