ipmi-fru-parser, branch master

build: install into bin instead of sbin

2019-03-28T18:05:58+00:00

Installs into bin instead of sbin per guidelines. Signed-off-by: Patrick Venture Change-Id: Ifbf3b709c08bbd892060291530a906e88430f5be

transition to cli11 instead of custom arg parser

2019-03-28T18:05:25+00:00

Transition to use cli11 for argument parsing instead of a custom argument parser. Tested: Not tested on hardware. Signed-off-by: Patrick Venture Change-Id: I9c516c8c2d76e35c6c31592f96e8f281e9d47ad6

add autom4te.cache/ to .gitignore

2019-03-28T18:05:11+00:00

Add missing "autom4te.cache/" to .gitignore file. Tested: Not tested on hardware. Signed-off-by: Patrick Venture Change-Id: Ie06d1b22bb2a74e2f6e2901d213fffa0cacac2c4

Convert host-ipmid -> libipmid

2019-02-19T21:12:11+00:00

phosphor-host-ipmid now exposes a library along with headers for interfacing with the ipmi daemon. Compile and link against the new library. Change-Id: Ib222df1605afe277457f34eb69a3d65c663325b7 Signed-off-by: William A. Kennington III

build: pkg anti-pattern: use defaults

2019-02-13T23:04:38+00:00

Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: Iccc91bcdd4ad57980a4731184b448936c1968f85 Signed-off-by: Patrick Venture

readeeprom: Allow FRU ID 0 to be selected

2019-02-11T18:22:28+00:00

We incorrectly checked that FRU ID != 0, which is the default FRU ID. Actually, the IPMI spec specifies FRU ID 0xff as reserved, so the check was changed to prevent that ID from being used instead. Split out fruid parsing code to its own function to cover various edge and failure cases. Tested: Ran 'phosphor-read-eeprom --eeprom fru.bin --fruid=0' and checked that values are reported to inventory as expected. Ran with '--fruid=ff' ('invalid' FRU ID): rejected Ran with '--fruid=xx' (non-HEX FRU ID): rejected Ran with '--fruid=100' (out-of-range FRU ID): rejected Ran with '--fruid="0 0"' (invalid number): rejected Ran with '--fruid=10.0' (non-integer): rejected Ran with '--fruid=0x12' (valid HEX FRU ID): accepted Ran with '--fruid=fe' (valid HEX FRU ID): accepted Change-Id: Ic1fb79cefc6931f21d0b5cb4363ad5fd44f47c92 Signed-off-by: Oskar Senft

writefrudata: Fix verifyFruData to skip CRC check for internal use area.

2019-01-08T15:49:55+00:00

The contents of the internal use area are not defined beyond the first byte, which means that we should not expect its last byte to be a CRC for the area. Change-Id: I15aba7f48e13f8a93c5a6b7e3262d9227da5dad7 Signed-off-by: Oskar Senft

frup: gcc8: swap abusive use strncpy w/ memcpy

2018-11-21T21:04:13+00:00

Fix the following warning under gcc8: | ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)': | ../git/frup.cpp:664:24: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation] | strncpy(bin_in_ascii, "0x", 2); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ia35d0ae733f0879f6c9d23126bab5fc899e89def Signed-off-by: Brad Bishop

writefrudata: add doxygen for methods

2018-11-12T23:36:04+00:00

Add doxygen comments for methods. Change-Id: Ifc155279a21b258300dadd409abfb617652159dc Signed-off-by: Patrick Venture

IPMIFruArea: Add doxygen to class

2018-10-31T19:52:20+00:00

Add doxygen to IPMIFruArea class. Change-Id: Ie28dd84c25df939671771741d7e4faca931e613e Signed-off-by: Patrick Venture