From 9f99ec21e51e4a9a47d7383dcd7391d2a9aa5050 Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Mon, 25 Jan 2016 00:07:51 +0100 Subject: icu: remove BR2_ARCH_HAS_ATOMICS dependency The BR2_ARCH_HAS_ATOMICS was added because on ARC, atomic instructions may not be provided by the architecture and therefore the compiler does not provide the __sync_*() built-ins. However, since then, icu was changed and is now able to use C++11 atomics, or even no atomic operations at all. In fact, icu will: * If possible, it will use C++11 atomics, which internally rely on the __atomic built-ins. These are available since gcc 4.7, and all architectures provide it. On some architectures, you *must* link with libatomic, on some other architectures, they are available built-in, but in all cases, linking against libatomic does not harm. Thanks to this, even ARC with no atomic support (which was the original reason for adding the BR2_ARCH_HAS_ATOMICS) dependency builds fine, provided -latomic is added to LIBS. * If C++11 atomics are not available, then it falls back to __sync_*() built-ins, which allows compilers older than 4.7 to be supported. * If really no atomic mechanism is available, then it falls back to a basic implementation based on a mutex. Conclusion: - The BR2_ARCH_HAS_ATOMICS dependency is no longer needed. - We need to link with -latomic when gcc >= 4.7 is used. Note that reverse dependencies of icu are also changed accordingly. Signed-off-by: Thomas Petazzoni Reviewed-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni --- package/qt5/qt5base/Config.in | 1 - 1 file changed, 1 deletion(-) (limited to 'package/qt5/qt5base/Config.in') diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in index 7cadcb2b89..64a7f65386 100644 --- a/package/qt5/qt5base/Config.in +++ b/package/qt5/qt5base/Config.in @@ -259,7 +259,6 @@ config BR2_PACKAGE_QT5BASE_DBUS config BR2_PACKAGE_QT5BASE_ICU bool "Enable ICU support" select BR2_PACKAGE_ICU - depends on BR2_ARCH_HAS_ATOMICS # icu depends on !BR2_BINFMT_FLAT # icu help This option enables ICU support in Qt5. This is for example -- cgit v1.2.1