From 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf Mon Sep 17 00:00:00 2001 From: Thomas De Schampheleire Date: Fri, 20 Dec 2013 22:31:30 +0100 Subject: Config.in files: use if/endif instead of 'depends on' for main symbol In the Config.in file of package foo, it often happens that there are other symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense when foo itself is enabled. There are two ways to express this: with depends on BR2_PACKAGE_FOO in each extra symbol, or with if BR2_PACKAGE_FOO ... endif around the entire set of extra symbols. The if/endif approach avoids the repetition of 'depends on' statements on multiple symbols, so this is clearly preferred. But even when there is only one extra symbol, if/endif is a more logical choice: - it is future-proof for when extra symbols are added - it allows to have just one strategy instead of two (less confusion) This patch modifies the Config.in files accordingly. Signed-off-by: Thomas De Schampheleire Signed-off-by: Thomas Petazzoni --- package/pppd/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'package/pppd') diff --git a/package/pppd/Config.in b/package/pppd/Config.in index dc16b22cb3..a1105136a0 100644 --- a/package/pppd/Config.in +++ b/package/pppd/Config.in @@ -7,8 +7,9 @@ config BR2_PACKAGE_PPPD http://www.samba.org/ppp/ +if BR2_PACKAGE_PPPD + config BR2_PACKAGE_PPPD_FILTER - depends on BR2_PACKAGE_PPPD select BR2_PACKAGE_LIBPCAP bool "filtering" help @@ -17,11 +18,12 @@ config BR2_PACKAGE_PPPD_FILTER are available. config BR2_PACKAGE_PPPD_RADIUS - depends on BR2_PACKAGE_PPPD bool "radius" help Install RADIUS support for pppd +endif + comment "pppd needs a toolchain w/ dynamic library" depends on BR2_PREFER_STATIC_LIB depends on BR2_USE_MMU -- cgit v1.2.1