From 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf Mon Sep 17 00:00:00 2001 From: Thomas De Schampheleire Date: Fri, 20 Dec 2013 22:31:30 +0100 Subject: Config.in files: use if/endif instead of 'depends on' for main symbol In the Config.in file of package foo, it often happens that there are other symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense when foo itself is enabled. There are two ways to express this: with depends on BR2_PACKAGE_FOO in each extra symbol, or with if BR2_PACKAGE_FOO ... endif around the entire set of extra symbols. The if/endif approach avoids the repetition of 'depends on' statements on multiple symbols, so this is clearly preferred. But even when there is only one extra symbol, if/endif is a more logical choice: - it is future-proof for when extra symbols are added - it allows to have just one strategy instead of two (less confusion) This patch modifies the Config.in files accordingly. Signed-off-by: Thomas De Schampheleire Signed-off-by: Thomas Petazzoni --- package/cppcms/Config.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'package/cppcms') diff --git a/package/cppcms/Config.in b/package/cppcms/Config.in index c5d64cedd0..2df83ba42d 100644 --- a/package/cppcms/Config.in +++ b/package/cppcms/Config.in @@ -20,14 +20,17 @@ config BR2_PACKAGE_CPPCMS http://cppcms.com +if BR2_PACKAGE_CPPCMS + config BR2_PACKAGE_CPPCMS_ICU bool "enable icu support" - depends on BR2_PACKAGE_CPPCMS depends on !BR2_arc # icu -> atomic builtins select BR2_PACKAGE_ICU help Using ICU allows advanced localization features into CppCMS, in another hand ICU is heavier than iconv. +endif + comment "cppcms needs an (e)glibc toolchain w/ C++" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC -- cgit v1.2.3