diff options
| author | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2016-01-25 00:07:51 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2016-01-26 21:26:08 +0100 |
| commit | 9f99ec21e51e4a9a47d7383dcd7391d2a9aa5050 (patch) | |
| tree | 0e0b5ecc84cb0a1669d65a5413ea5e85e0f4b251 /package/qt5 | |
| parent | 1e1333fd8f1aa53b90f28187ad811f32bb0e79f4 (diff) | |
| download | buildroot-9f99ec21e51e4a9a47d7383dcd7391d2a9aa5050.tar.gz buildroot-9f99ec21e51e4a9a47d7383dcd7391d2a9aa5050.zip | |
icu: remove BR2_ARCH_HAS_ATOMICS dependency
The BR2_ARCH_HAS_ATOMICS was added because on ARC, atomic instructions
may not be provided by the architecture and therefore the compiler
does not provide the __sync_*() built-ins.
However, since then, icu was changed and is now able to use C++11
atomics, or even no atomic operations at all. In fact, icu will:
* If possible, it will use C++11 atomics, which internally rely on
the __atomic built-ins. These are available since gcc 4.7, and all
architectures provide it. On some architectures, you *must* link
with libatomic, on some other architectures, they are available
built-in, but in all cases, linking against libatomic does not
harm. Thanks to this, even ARC with no atomic support (which was
the original reason for adding the BR2_ARCH_HAS_ATOMICS) dependency
builds fine, provided -latomic is added to LIBS.
* If C++11 atomics are not available, then it falls back to
__sync_*() built-ins, which allows compilers older than 4.7 to be
supported.
* If really no atomic mechanism is available, then it falls back to a
basic implementation based on a mutex.
Conclusion:
- The BR2_ARCH_HAS_ATOMICS dependency is no longer needed.
- We need to link with -latomic when gcc >= 4.7 is used.
Note that reverse dependencies of icu are also changed accordingly.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/qt5')
| -rw-r--r-- | package/qt5/qt5base/Config.in | 1 | ||||
| -rw-r--r-- | package/qt5/qt5webkit/Config.in | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in index 7cadcb2b89..64a7f65386 100644 --- a/package/qt5/qt5base/Config.in +++ b/package/qt5/qt5base/Config.in @@ -259,7 +259,6 @@ config BR2_PACKAGE_QT5BASE_DBUS config BR2_PACKAGE_QT5BASE_ICU bool "Enable ICU support" select BR2_PACKAGE_ICU - depends on BR2_ARCH_HAS_ATOMICS # icu depends on !BR2_BINFMT_FLAT # icu help This option enables ICU support in Qt5. This is for example diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in index eee82e8df6..96d97cc8d1 100644 --- a/package/qt5/qt5webkit/Config.in +++ b/package/qt5/qt5webkit/Config.in @@ -9,7 +9,6 @@ config BR2_PACKAGE_QT5WEBKIT # This module does not support static linking depends on !BR2_STATIC_LIBS depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - depends on BR2_ARCH_HAS_ATOMICS # icu depends on !BR2_BINFMT_FLAT # icu help Qt is a cross-platform application and UI framework for |
